* [PATCH] arm64: dts: allwinner: h5: remove Mali GPU PMU module
@ 2020-08-22 6:27 Qiang Yu
2020-08-25 8:42 ` Maxime Ripard
0 siblings, 1 reply; 2+ messages in thread
From: Qiang Yu @ 2020-08-22 6:27 UTC (permalink / raw)
To: Rob Herring, Maxime Ripard, Chen-Yu Tsai, devicetree,
linux-arm-kernel, linux-kernel
Cc: linux-sunxi, lima, Qiang Yu
H5's Mali GPU PMU is not present or working corretly although
H5 datasheet record its interrupt vector.
Adding this module will miss lead lima driver try to shutdown
it and get waiting timeout. This problem is not exposed before
lima runtime PM supoprt is added.
Fixes: bb39ed07e55b ("arm64: dts: allwinner: h5: Add device node for Mali-450 GPU")
Signed-off-by: Qiang Yu <yuq825@gmail.com>
---
arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
index 6735e316a39c..6c6053a18413 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
@@ -139,8 +139,7 @@ mali: gpu@1e80000 {
<GIC_SPI 104 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 105 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 106 IRQ_TYPE_LEVEL_HIGH>,
- <GIC_SPI 107 IRQ_TYPE_LEVEL_HIGH>,
- <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>;
+ <GIC_SPI 107 IRQ_TYPE_LEVEL_HIGH>;
interrupt-names = "gp",
"gpmmu",
"pp",
@@ -151,8 +150,7 @@ mali: gpu@1e80000 {
"pp2",
"ppmmu2",
"pp3",
- "ppmmu3",
- "pmu";
+ "ppmmu3";
clocks = <&ccu CLK_BUS_GPU>, <&ccu CLK_GPU>;
clock-names = "bus", "core";
resets = <&ccu RST_BUS_GPU>;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arm64: dts: allwinner: h5: remove Mali GPU PMU module
2020-08-22 6:27 [PATCH] arm64: dts: allwinner: h5: remove Mali GPU PMU module Qiang Yu
@ 2020-08-25 8:42 ` Maxime Ripard
0 siblings, 0 replies; 2+ messages in thread
From: Maxime Ripard @ 2020-08-25 8:42 UTC (permalink / raw)
To: Qiang Yu
Cc: Rob Herring, Chen-Yu Tsai, devicetree, linux-arm-kernel,
linux-kernel, linux-sunxi, lima
[-- Attachment #1: Type: text/plain, Size: 545 bytes --]
On Sat, Aug 22, 2020 at 02:27:55PM +0800, Qiang Yu wrote:
> H5's Mali GPU PMU is not present or working corretly although
> H5 datasheet record its interrupt vector.
>
> Adding this module will miss lead lima driver try to shutdown
> it and get waiting timeout. This problem is not exposed before
> lima runtime PM supoprt is added.
>
> Fixes: bb39ed07e55b ("arm64: dts: allwinner: h5: Add device node for Mali-450 GPU")
> Signed-off-by: Qiang Yu <yuq825@gmail.com>
Fixed the typo (s/supoprt/support) and applied, thanks!
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-25 13:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-22 6:27 [PATCH] arm64: dts: allwinner: h5: remove Mali GPU PMU module Qiang Yu
2020-08-25 8:42 ` Maxime Ripard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).