* [PATCH] soc: imx: gpcv2: Use dev_err_probe() to simplify error handling
@ 2020-08-11 3:04 Anson Huang
2020-08-11 7:03 ` Guido Günther
2020-08-22 12:58 ` Shawn Guo
0 siblings, 2 replies; 3+ messages in thread
From: Anson Huang @ 2020-08-11 3:04 UTC (permalink / raw)
To: shawnguo, s.hauer, kernel, festevam, daniel.baluta, agx,
linux-arm-kernel, linux-kernel
Cc: Linux-imx
dev_err_probe() can reduce code size, uniform error handling and record the
defer probe reason etc., use it to simplify the code.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
drivers/soc/imx/gpcv2.c | 15 +++++----------
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c
index 6cf8a7a..db7e7fc 100644
--- a/drivers/soc/imx/gpcv2.c
+++ b/drivers/soc/imx/gpcv2.c
@@ -487,22 +487,17 @@ static int imx_pgc_domain_probe(struct platform_device *pdev)
domain->regulator = devm_regulator_get_optional(domain->dev, "power");
if (IS_ERR(domain->regulator)) {
- if (PTR_ERR(domain->regulator) != -ENODEV) {
- if (PTR_ERR(domain->regulator) != -EPROBE_DEFER)
- dev_err(domain->dev, "Failed to get domain's regulator\n");
- return PTR_ERR(domain->regulator);
- }
+ if (PTR_ERR(domain->regulator) != -ENODEV)
+ return dev_err_probe(domain->dev, PTR_ERR(domain->regulator),
+ "Failed to get domain's regulator\n");
} else if (domain->voltage) {
regulator_set_voltage(domain->regulator,
domain->voltage, domain->voltage);
}
ret = imx_pgc_get_clocks(domain);
- if (ret) {
- if (ret != -EPROBE_DEFER)
- dev_err(domain->dev, "Failed to get domain's clocks\n");
- return ret;
- }
+ if (ret)
+ return dev_err_probe(domain->dev, ret, "Failed to get domain's clocks\n");
ret = pm_genpd_init(&domain->genpd, NULL, true);
if (ret) {
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] soc: imx: gpcv2: Use dev_err_probe() to simplify error handling
2020-08-11 3:04 [PATCH] soc: imx: gpcv2: Use dev_err_probe() to simplify error handling Anson Huang
@ 2020-08-11 7:03 ` Guido Günther
2020-08-22 12:58 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Guido Günther @ 2020-08-11 7:03 UTC (permalink / raw)
To: Anson Huang
Cc: shawnguo, s.hauer, kernel, festevam, daniel.baluta,
linux-arm-kernel, linux-kernel, Linux-imx
Hi,
On Tue, Aug 11, 2020 at 11:04:42AM +0800, Anson Huang wrote:
> dev_err_probe() can reduce code size, uniform error handling and record the
> defer probe reason etc., use it to simplify the code.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> drivers/soc/imx/gpcv2.c | 15 +++++----------
> 1 file changed, 5 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c
> index 6cf8a7a..db7e7fc 100644
> --- a/drivers/soc/imx/gpcv2.c
> +++ b/drivers/soc/imx/gpcv2.c
> @@ -487,22 +487,17 @@ static int imx_pgc_domain_probe(struct platform_device *pdev)
>
> domain->regulator = devm_regulator_get_optional(domain->dev, "power");
> if (IS_ERR(domain->regulator)) {
> - if (PTR_ERR(domain->regulator) != -ENODEV) {
> - if (PTR_ERR(domain->regulator) != -EPROBE_DEFER)
> - dev_err(domain->dev, "Failed to get domain's regulator\n");
> - return PTR_ERR(domain->regulator);
> - }
> + if (PTR_ERR(domain->regulator) != -ENODEV)
> + return dev_err_probe(domain->dev, PTR_ERR(domain->regulator),
> + "Failed to get domain's regulator\n");
> } else if (domain->voltage) {
> regulator_set_voltage(domain->regulator,
> domain->voltage, domain->voltage);
> }
>
> ret = imx_pgc_get_clocks(domain);
> - if (ret) {
> - if (ret != -EPROBE_DEFER)
> - dev_err(domain->dev, "Failed to get domain's clocks\n");
> - return ret;
> - }
> + if (ret)
> + return dev_err_probe(domain->dev, ret, "Failed to get domain's clocks\n");
>
> ret = pm_genpd_init(&domain->genpd, NULL, true);
> if (ret) {
Reviewed-by: Guido Günther <agx@sigxcpu.org>
-- Guido
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] soc: imx: gpcv2: Use dev_err_probe() to simplify error handling
2020-08-11 3:04 [PATCH] soc: imx: gpcv2: Use dev_err_probe() to simplify error handling Anson Huang
2020-08-11 7:03 ` Guido Günther
@ 2020-08-22 12:58 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2020-08-22 12:58 UTC (permalink / raw)
To: Anson Huang
Cc: s.hauer, kernel, festevam, daniel.baluta, agx, linux-arm-kernel,
linux-kernel, Linux-imx
On Tue, Aug 11, 2020 at 11:04:42AM +0800, Anson Huang wrote:
> dev_err_probe() can reduce code size, uniform error handling and record the
> defer probe reason etc., use it to simplify the code.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-22 12:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-11 3:04 [PATCH] soc: imx: gpcv2: Use dev_err_probe() to simplify error handling Anson Huang
2020-08-11 7:03 ` Guido Günther
2020-08-22 12:58 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).