From: Maxime Ripard <maxime@cerno.tech>
To: "Kévin L'hôpital" <kevin.lhopital@bootlin.com>
Cc: linux-media@vger.kernel.org, mchehab@kernel.org,
robh+dt@kernel.org, mark.rutland@arm.com, wens@csie.org,
yong.deng@magewell.com, p.zabel@pengutronix.de,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
paul.kocialkowski@bootlin.com, thomas.petazzoni@bootlin.com
Subject: Re: [PATCH 2/7] dt-bindings: media: i2c: Add documentation for ov8865
Date: Mon, 24 Aug 2020 18:59:10 +0200 [thread overview]
Message-ID: <20200824165910.tnsalyxfuimfx5rd@gilmour.lan> (raw)
In-Reply-To: <20200821145935.20346-3-kevin.lhopital@bootlin.com>
[-- Attachment #1: Type: text/plain, Size: 2297 bytes --]
Hi,
On Fri, Aug 21, 2020 at 04:59:30PM +0200, Kévin L'hôpital wrote:
> Add a documentation for the sensor ov8865 from Omnivision.
>
> Signed-off-by: Kévin L'hôpital <kevin.lhopital@bootlin.com>
In order to ease the submission of both drivers, you should probably
split this series into two, one with the MIPI-CSI driver, and one with
the ov8865 driver.
> ---
> .../devicetree/bindings/media/i2c/ov8865.txt | 51 +++++++++++++++++++
> 1 file changed, 51 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/i2c/ov8865.txt
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/ov8865.txt b/Documentation/devicetree/bindings/media/i2c/ov8865.txt
> new file mode 100644
> index 000000000000..ac5a662288de
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/ov8865.txt
> @@ -0,0 +1,51 @@
> +* Omnivision OV8865 MIPI CSI-2
> +
> +Required Properties:
> +- compatible: should be "ovti,ov8865"
> +- clocks: reference to the xclk input clock.
> +- clock-names: should be "xclk".
> +- DOVDD-supply: Digital I/O voltage supply, 2.8 volts
> +- AVDD-supply: Analog voltage supply, 2.8 volts
> +- AFVDD-supply: Analog voltage supply, 2.8 volts
> +- DVDD-supply: Digital core voltage supply, 1.2 volts
> +- reset-gpios: reference to the GPIO connected to the reset pin.
> + This is an active low signal to the OV8865.
> +- powerdown-gpios: reference to the GPIO connected to the powerdown pin.
> + This is an active low signal to the OV8865.
> +- rotation: as defined in
> + Documentation/devicetree/bindings/media/video-interfaces.txt,
> + valid values are 0 (sensor mounted upright) and 180 (sensor
> + mounted upside down).
> +- remote-endpoint: a phandle to the bus receiver's endpoint node.
> +- clock-lanes: should be set to <0> (clock lane on hardware lane 0).
> +- data-lanes: should be set to <4> (four CSI-2 lanes supported).
> +
> +The device node must contain one 'port' child node for its digital output video
> +port, in accordance with the video interface bindings defined in
> +Documentation/devicetree/bindings/media/video-interfaces.txt.
Free form DT documentation is deprecated nowadays, you should be doing a
YAML schema instead (like the ov8856 driver).
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2020-08-25 13:36 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-21 14:59 [PATCH 0/7] Support of MIPI CSI-2 for A83T and OV8865 camera Kévin L'hôpital
2020-08-21 14:59 ` [PATCH 1/7] media: sun6i-csi: Fix the bpp for 10-bit bayer formats Kévin L'hôpital
2020-08-24 16:55 ` Maxime Ripard
2020-08-25 15:23 ` Kévin L'hôpital
2020-08-25 15:50 ` Chen-Yu Tsai
2020-08-26 9:18 ` Kévin L'hôpital
2020-08-21 14:59 ` [PATCH 2/7] dt-bindings: media: i2c: Add documentation for ov8865 Kévin L'hôpital
2020-08-24 16:59 ` Maxime Ripard [this message]
2020-08-25 15:17 ` Kévin L'hôpital
2020-08-21 14:59 ` [PATCH 3/7] media: i2c: Add support for the OV8865 image sensor Kévin L'hôpital
2020-08-21 17:18 ` kernel test robot
2020-08-21 17:20 ` kernel test robot
2020-08-21 14:59 ` [PATCH 4/7] media: sunxi: sun6i-csi: Move the sun6i_csi_dev structure to the common header Kévin L'hôpital
2020-08-21 14:59 ` [PATCH 5/7] media: sunxi: sun6i-csi: Add support of MIPI CSI-2 for A83T Kévin L'hôpital
2020-08-25 14:37 ` Maxime Ripard
2020-08-26 9:17 ` Kévin L'hôpital
2020-08-27 15:41 ` Maxime Ripard
2020-08-28 7:32 ` Kévin L'hôpital
2020-08-21 14:59 ` [PATCH 6/7] ARM: dts: sun8i: a83t: Add support for the MIPI CSI-2 in CSI node Kévin L'hôpital
2020-08-21 14:59 ` [PATCH 7/7] [NOT FOR MERGE] ARM: dts: sun8i: a83t: bananapi-m3: Enable OV8865 camera Kévin L'hôpital
2020-08-25 14:40 ` Maxime Ripard
2020-08-26 8:58 ` Kévin L'hôpital
2020-08-27 15:38 ` Maxime Ripard
2020-08-28 7:31 ` Kévin L'hôpital
2020-08-24 16:52 ` [PATCH 0/7] Support of MIPI CSI-2 for A83T and " Maxime Ripard
2020-08-25 15:20 ` Kévin L'hôpital
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200824165910.tnsalyxfuimfx5rd@gilmour.lan \
--to=maxime@cerno.tech \
--cc=devicetree@vger.kernel.org \
--cc=kevin.lhopital@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=paul.kocialkowski@bootlin.com \
--cc=robh+dt@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=wens@csie.org \
--cc=yong.deng@magewell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).