From: "Kévin L'hôpital" <kevin.lhopital@bootlin.com>
To: Maxime Ripard <maxime@cerno.tech>
Cc: linux-media@vger.kernel.org, mchehab@kernel.org,
robh+dt@kernel.org, mark.rutland@arm.com, wens@csie.org,
yong.deng@magewell.com, p.zabel@pengutronix.de,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
paul.kocialkowski@bootlin.com, thomas.petazzoni@bootlin.com
Subject: Re: [PATCH 0/7] Support of MIPI CSI-2 for A83T and OV8865 camera
Date: Tue, 25 Aug 2020 17:20:22 +0200 [thread overview]
Message-ID: <20200825172022.3c951ab2@lhopital-XPS-13-9360> (raw)
In-Reply-To: <20200824165244.x5rnon47kmtxojg2@gilmour.lan>
Le Mon, 24 Aug 2020 18:52:44 +0200,
Maxime Ripard <maxime@cerno.tech> a écrit :
> Hi,
>
> On Fri, Aug 21, 2020 at 04:59:28PM +0200, Kévin L'hôpital wrote:
> >
> > Kévin L'hôpital (7):
> > media: sun6i-csi: Fix the bpp for 10-bit bayer formats
> > dt-bindings: media: i2c: Add documentation for ov8865
> > media: i2c: Add support for the OV8865 image sensor
> > media: sunxi: sun6i-csi: Move the sun6i_csi_dev structure to the
> > common header
> > media: sunxi: sun6i-csi: Add support of MIPI CSI-2 for A83T
> > ARM: dts: sun8i: a83t: Add support for the MIPI CSI-2 in CSI node
> > [NOT FOR MERGE] ARM: dts: sun8i: a83t: bananapi-m3: Enable OV8865
> > camera
>
> You should have a cover letter here to provide some context.
>
> There's a bunch of things that would need to be explained and / or
> argued for here, in particular:
> - Why did you need to plumb it into sun6i-csi?
> - You're naming the CSI part as the A83t CSI, while MIPI-CSI has
> been supported since the A31(?), is there a reason for that?
> - This is not documented anywhere, what did you base this work on?
>
> Also, I think that documenting the general challenges you faced (which
> were likely because of the first bullet point above) and how you
> solved them here would be great to start a discussion if needed.
>
> Finally, iirc, Hans requires a v4l2-compliance run for any new driver,
> which isn't strictly the case for this driver, but isn't really *not*
> the case either.
>
> Maxime
Thank you very much for the review, I will add all this context.
Kévin
--
Kevin L'Hopital, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
prev parent reply other threads:[~2020-08-25 15:20 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-21 14:59 [PATCH 0/7] Support of MIPI CSI-2 for A83T and OV8865 camera Kévin L'hôpital
2020-08-21 14:59 ` [PATCH 1/7] media: sun6i-csi: Fix the bpp for 10-bit bayer formats Kévin L'hôpital
2020-08-24 16:55 ` Maxime Ripard
2020-08-25 15:23 ` Kévin L'hôpital
2020-08-25 15:50 ` Chen-Yu Tsai
2020-08-26 9:18 ` Kévin L'hôpital
2020-08-21 14:59 ` [PATCH 2/7] dt-bindings: media: i2c: Add documentation for ov8865 Kévin L'hôpital
2020-08-24 16:59 ` Maxime Ripard
2020-08-25 15:17 ` Kévin L'hôpital
2020-08-21 14:59 ` [PATCH 3/7] media: i2c: Add support for the OV8865 image sensor Kévin L'hôpital
2020-08-21 17:18 ` kernel test robot
2020-08-21 17:20 ` kernel test robot
2020-08-21 14:59 ` [PATCH 4/7] media: sunxi: sun6i-csi: Move the sun6i_csi_dev structure to the common header Kévin L'hôpital
2020-08-21 14:59 ` [PATCH 5/7] media: sunxi: sun6i-csi: Add support of MIPI CSI-2 for A83T Kévin L'hôpital
2020-08-25 14:37 ` Maxime Ripard
2020-08-26 9:17 ` Kévin L'hôpital
2020-08-27 15:41 ` Maxime Ripard
2020-08-28 7:32 ` Kévin L'hôpital
2020-08-21 14:59 ` [PATCH 6/7] ARM: dts: sun8i: a83t: Add support for the MIPI CSI-2 in CSI node Kévin L'hôpital
2020-08-21 14:59 ` [PATCH 7/7] [NOT FOR MERGE] ARM: dts: sun8i: a83t: bananapi-m3: Enable OV8865 camera Kévin L'hôpital
2020-08-25 14:40 ` Maxime Ripard
2020-08-26 8:58 ` Kévin L'hôpital
2020-08-27 15:38 ` Maxime Ripard
2020-08-28 7:31 ` Kévin L'hôpital
2020-08-24 16:52 ` [PATCH 0/7] Support of MIPI CSI-2 for A83T and " Maxime Ripard
2020-08-25 15:20 ` Kévin L'hôpital [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200825172022.3c951ab2@lhopital-XPS-13-9360 \
--to=kevin.lhopital@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maxime@cerno.tech \
--cc=mchehab@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=paul.kocialkowski@bootlin.com \
--cc=robh+dt@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=wens@csie.org \
--cc=yong.deng@magewell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).