From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: "Ramuthevar,
Vadivel MuruganX" <vadivel.muruganx.ramuthevar@linux.intel.com>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
Andy Shevchenko <andriy.shevchenko@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
thomas.langer@intel.com, cheol.yong.kim@intel.com,
qi-ming.wu@intel.com, yin1.li@intel.com
Subject: Re: [PATCH v1 0/9] extcon: extcon-ptn5150: Add the USB external connector support
Date: Tue, 25 Aug 2020 11:19:35 +0300 [thread overview]
Message-ID: <20200825081935.GE189773@kuha.fi.intel.com> (raw)
In-Reply-To: <b9187c39-8d94-6b41-9e1c-b95161b17c1c@linux.intel.com>
On Wed, Aug 19, 2020 at 04:45:38PM +0800, Ramuthevar, Vadivel MuruganX wrote:
> Hi Andy,
>
> On 19/8/2020 3:55 pm, Andy Shevchenko wrote:
> > On Wed, Aug 19, 2020 at 8:38 AM Ramuthevar, Vadivel MuruganX
> > <vadivel.muruganx.ramuthevar@linux.intel.com> wrote:
> > > On 18/8/2020 4:40 pm, Andy Shevchenko wrote:
> > > > On Tue, Aug 18, 2020 at 02:57:18PM +0800, Ramuthevar,Vadivel MuruganX wrote:
> > > > > USB external connector chip PTN5150 used on the Intel LGM SoC
> > > > > boards to detect the USB type and connection.
> > > > Internally I meant you can send cleanups, but couple of patches here are the
> > > > features and were still under discussion... But here we are.
> > >
> > > you mean asking us to implement the Heikki suggested as below..
> > >
> > > Heikki Krogerus: register the port and the partner attached to it with
> > > the USB Type-C connector class in the driver. Is my understaanding
> > > right? if not, please explain it. Thanks!
> >
> > When you mention somebody, don't forget to Cc them (now done by me).
> Sure, Thank you
So the patches 1-5 are fine. The rest needs to be rewritten.
thanks,
--
heikki
next prev parent reply other threads:[~2020-08-25 8:19 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-18 6:57 [PATCH v1 0/9] extcon: extcon-ptn5150: Add the USB external connector support Ramuthevar,Vadivel MuruganX
2020-08-18 6:57 ` [PATCH v1 1/9] extcon: extcon-ptn5150: Switch to GENMASK() for vendor and device ID's Ramuthevar,Vadivel MuruganX
2020-08-26 6:57 ` Krzysztof Kozlowski
2020-08-18 6:57 ` [PATCH v1 2/9] extcon: extcon-ptn5150: Switch to GENMASK() for VBUS detection macro Ramuthevar,Vadivel MuruganX
2020-08-26 6:59 ` Krzysztof Kozlowski
2020-08-26 7:33 ` Ramuthevar, Vadivel MuruganX
2020-08-18 6:57 ` [PATCH v1 3/9] extcon: extcon-ptn5150: Switch to BIT() macro for cable attach Ramuthevar,Vadivel MuruganX
2020-08-26 6:59 ` Krzysztof Kozlowski
2020-08-26 7:50 ` Ramuthevar, Vadivel MuruganX
2020-08-18 6:57 ` [PATCH v1 4/9] extcon: extcon-ptn5150: Switch to BIT() for cable detach macro Ramuthevar,Vadivel MuruganX
2020-08-26 7:00 ` Krzysztof Kozlowski
2020-08-18 6:57 ` [PATCH v1 5/9] extcon: extcon-ptn5150: Switch to GENMASK() for port attachment macro Ramuthevar,Vadivel MuruganX
2020-08-26 7:00 ` Krzysztof Kozlowski
2020-08-18 6:57 ` [PATCH v1 6/9] extcon: extcon-ptn5150: Set and get the VBUS and POLARITY property state Ramuthevar,Vadivel MuruganX
2020-08-18 6:57 ` [PATCH v1 7/9] extcon: extcon-ptn5150: Add USB debug accessory support Ramuthevar,Vadivel MuruganX
2020-08-18 6:57 ` [PATCH v1 8/9] extcon: extcon-ptn5150: Add USB analog audio " Ramuthevar,Vadivel MuruganX
2020-08-18 6:57 ` [PATCH v1 9/9] extcon: extcon-ptn5150: Remove unused variable and extra space Ramuthevar,Vadivel MuruganX
2020-08-18 8:40 ` [PATCH v1 0/9] extcon: extcon-ptn5150: Add the USB external connector support Andy Shevchenko
2020-08-19 5:35 ` Ramuthevar, Vadivel MuruganX
2020-08-19 7:55 ` Andy Shevchenko
2020-08-19 8:45 ` Ramuthevar, Vadivel MuruganX
2020-08-25 8:19 ` Heikki Krogerus [this message]
2020-08-26 2:51 ` Ramuthevar, Vadivel MuruganX
2020-08-26 9:18 ` Andy Shevchenko
2020-08-26 9:43 ` Ramuthevar, Vadivel MuruganX
2020-08-26 9:50 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200825081935.GE189773@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=cheol.yong.kim@intel.com \
--cc=cw00.choi@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=qi-ming.wu@intel.com \
--cc=thomas.langer@intel.com \
--cc=vadivel.muruganx.ramuthevar@linux.intel.com \
--cc=yin1.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).