linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Ramuthevar,Vadivel MuruganX" 
	<vadivel.muruganx.ramuthevar@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, myungjoo.ham@samsung.com,
	cw00.choi@samsung.com, andriy.shevchenko@intel.com,
	thomas.langer@intel.com, cheol.yong.kim@intel.com,
	qi-ming.wu@intel.com, yin1.li@intel.com
Subject: Re: [PATCH v1 2/9] extcon: extcon-ptn5150: Switch to GENMASK() for VBUS detection macro
Date: Wed, 26 Aug 2020 08:59:20 +0200	[thread overview]
Message-ID: <20200826065920.GB12271@pi3> (raw)
In-Reply-To: <20200818065727.50520-3-vadivel.muruganx.ramuthevar@linux.intel.com>

On Tue, Aug 18, 2020 at 02:57:20PM +0800, Ramuthevar,Vadivel MuruganX wrote:
> From: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
> 
> Switch to GENMASK() for VBUS detection macro.
> 
> Signed-off-by: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
> ---
>  drivers/extcon/extcon-ptn5150.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)

This is too simple change, should be squashed with 1, 3, 4 and 5.

There is no point to split each change a define to use BIT or GENMASK.

Best regards,
Krzysztof

> 
> diff --git a/drivers/extcon/extcon-ptn5150.c b/drivers/extcon/extcon-ptn5150.c
> index 5d9a8767646b..c816a6c1e05c 100644
> --- a/drivers/extcon/extcon-ptn5150.c
> +++ b/drivers/extcon/extcon-ptn5150.c
> @@ -42,9 +42,7 @@ enum ptn5150_reg {
>  #define PTN5150_REG_CC_PORT_ATTACHMENT_MASK	\
>  	(0x7 << PTN5150_REG_CC_PORT_ATTACHMENT_SHIFT)
>  
> -#define PTN5150_REG_CC_VBUS_DETECTION_SHIFT	7
> -#define PTN5150_REG_CC_VBUS_DETECTION_MASK	\
> -	(0x1 << PTN5150_REG_CC_VBUS_DETECTION_SHIFT)
> +#define PTN5150_REG_CC_VBUS_DETECTION		BIT(7)
>  
>  #define PTN5150_REG_INT_CABLE_ATTACH_SHIFT	0
>  #define PTN5150_REG_INT_CABLE_ATTACH_MASK	\
> @@ -130,9 +128,8 @@ static void ptn5150_irq_work(struct work_struct *work)
>  			case PTN5150_UFP_ATTACHED:
>  				extcon_set_state_sync(info->edev, EXTCON_USB,
>  						false);
> -				vbus = ((reg_data &
> -					PTN5150_REG_CC_VBUS_DETECTION_MASK) >>
> -					PTN5150_REG_CC_VBUS_DETECTION_SHIFT);
> +				vbus = FIELD_GET(PTN5150_REG_CC_VBUS_DETECTION,
> +						 reg_data);
>  				if (vbus)
>  					gpiod_set_value(info->vbus_gpiod, 0);
>  				else
> -- 
> 2.11.0
> 

  reply	other threads:[~2020-08-26  6:59 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-18  6:57 [PATCH v1 0/9] extcon: extcon-ptn5150: Add the USB external connector support Ramuthevar,Vadivel MuruganX
2020-08-18  6:57 ` [PATCH v1 1/9] extcon: extcon-ptn5150: Switch to GENMASK() for vendor and device ID's Ramuthevar,Vadivel MuruganX
2020-08-26  6:57   ` Krzysztof Kozlowski
2020-08-18  6:57 ` [PATCH v1 2/9] extcon: extcon-ptn5150: Switch to GENMASK() for VBUS detection macro Ramuthevar,Vadivel MuruganX
2020-08-26  6:59   ` Krzysztof Kozlowski [this message]
2020-08-26  7:33     ` Ramuthevar, Vadivel MuruganX
2020-08-18  6:57 ` [PATCH v1 3/9] extcon: extcon-ptn5150: Switch to BIT() macro for cable attach Ramuthevar,Vadivel MuruganX
2020-08-26  6:59   ` Krzysztof Kozlowski
2020-08-26  7:50     ` Ramuthevar, Vadivel MuruganX
2020-08-18  6:57 ` [PATCH v1 4/9] extcon: extcon-ptn5150: Switch to BIT() for cable detach macro Ramuthevar,Vadivel MuruganX
2020-08-26  7:00   ` Krzysztof Kozlowski
2020-08-18  6:57 ` [PATCH v1 5/9] extcon: extcon-ptn5150: Switch to GENMASK() for port attachment macro Ramuthevar,Vadivel MuruganX
2020-08-26  7:00   ` Krzysztof Kozlowski
2020-08-18  6:57 ` [PATCH v1 6/9] extcon: extcon-ptn5150: Set and get the VBUS and POLARITY property state Ramuthevar,Vadivel MuruganX
2020-08-18  6:57 ` [PATCH v1 7/9] extcon: extcon-ptn5150: Add USB debug accessory support Ramuthevar,Vadivel MuruganX
2020-08-18  6:57 ` [PATCH v1 8/9] extcon: extcon-ptn5150: Add USB analog audio " Ramuthevar,Vadivel MuruganX
2020-08-18  6:57 ` [PATCH v1 9/9] extcon: extcon-ptn5150: Remove unused variable and extra space Ramuthevar,Vadivel MuruganX
2020-08-18  8:40 ` [PATCH v1 0/9] extcon: extcon-ptn5150: Add the USB external connector support Andy Shevchenko
2020-08-19  5:35   ` Ramuthevar, Vadivel MuruganX
2020-08-19  7:55     ` Andy Shevchenko
2020-08-19  8:45       ` Ramuthevar, Vadivel MuruganX
2020-08-25  8:19         ` Heikki Krogerus
2020-08-26  2:51           ` Ramuthevar, Vadivel MuruganX
2020-08-26  9:18             ` Andy Shevchenko
2020-08-26  9:43               ` Ramuthevar, Vadivel MuruganX
2020-08-26  9:50               ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200826065920.GB12271@pi3 \
    --to=krzk@kernel.org \
    --cc=andriy.shevchenko@intel.com \
    --cc=cheol.yong.kim@intel.com \
    --cc=cw00.choi@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=myungjoo.ham@samsung.com \
    --cc=qi-ming.wu@intel.com \
    --cc=thomas.langer@intel.com \
    --cc=vadivel.muruganx.ramuthevar@linux.intel.com \
    --cc=yin1.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).