* [PATCH v1 0/1] extcon: ptn5150: Add usb-typec support for Intel LGM SoC @ 2020-08-25 8:31 Ramuthevar,Vadivel MuruganX 2020-08-25 8:31 ` [PATCH v1 1/1] " Ramuthevar,Vadivel MuruganX 0 siblings, 1 reply; 6+ messages in thread From: Ramuthevar,Vadivel MuruganX @ 2020-08-25 8:31 UTC (permalink / raw) To: cw00.choi, linux-kernel Cc: vijaikumar.kanagarajan, krzk, myungjoo.ham, cheol.yong.kim, qi-ming.wu, yin1.li, Ramuthevar,Vadivel MuruganX Add usb-typec detection support for the Intel LGM SoC based boards. Original driver is not supporting usb detection on Intel LGM SoC based boards then we debugged and fixed the issue, but before sending our patches Mr.Krzyszto has sent the same kind of patches, so I have rebased over his latest patches which is present in maintainer tree. Built and tested it's working fine, overthat created the new patch V1. Reference to mail discussion: https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg2281723.html Ramuthevar Vadivel Murugan (1): extcon: ptn5150: Add usb-typec support for Intel LGM SoC drivers/extcon/extcon-ptn5150.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.11.0 ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v1 1/1] extcon: ptn5150: Add usb-typec support for Intel LGM SoC 2020-08-25 8:31 [PATCH v1 0/1] extcon: ptn5150: Add usb-typec support for Intel LGM SoC Ramuthevar,Vadivel MuruganX @ 2020-08-25 8:31 ` Ramuthevar,Vadivel MuruganX 2020-08-25 8:40 ` Krzysztof Kozlowski 2020-08-25 10:46 ` Chanwoo Choi 0 siblings, 2 replies; 6+ messages in thread From: Ramuthevar,Vadivel MuruganX @ 2020-08-25 8:31 UTC (permalink / raw) To: cw00.choi, linux-kernel Cc: vijaikumar.kanagarajan, krzk, myungjoo.ham, cheol.yong.kim, qi-ming.wu, yin1.li, Ramuthevar Vadivel Murugan From: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com> Add usb-typec detection support for Intel LGM SoC based boards. Signed-off-by: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com> --- drivers/extcon/extcon-ptn5150.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/extcon/extcon-ptn5150.c b/drivers/extcon/extcon-ptn5150.c index 8ba706fad887..60355a1b5cb2 100644 --- a/drivers/extcon/extcon-ptn5150.c +++ b/drivers/extcon/extcon-ptn5150.c @@ -300,6 +300,8 @@ static int ptn5150_i2c_probe(struct i2c_client *i2c) return ret; } + extcon_set_property_capability(info->edev, EXTCON_USB_HOST, + EXTCON_PROP_USB_TYPEC_POLARITY); /* Initialize PTN5150 device and print vendor id and version id */ ret = ptn5150_init_dev_type(info); if (ret) -- 2.11.0 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v1 1/1] extcon: ptn5150: Add usb-typec support for Intel LGM SoC 2020-08-25 8:31 ` [PATCH v1 1/1] " Ramuthevar,Vadivel MuruganX @ 2020-08-25 8:40 ` Krzysztof Kozlowski 2020-08-25 9:16 ` Ramuthevar, Vadivel MuruganX 2020-08-25 10:46 ` Chanwoo Choi 1 sibling, 1 reply; 6+ messages in thread From: Krzysztof Kozlowski @ 2020-08-25 8:40 UTC (permalink / raw) To: Ramuthevar,Vadivel MuruganX Cc: cw00.choi, linux-kernel, vijaikumar.kanagarajan, myungjoo.ham, cheol.yong.kim, qi-ming.wu, yin1.li On Tue, Aug 25, 2020 at 04:31:47PM +0800, Ramuthevar,Vadivel MuruganX wrote: > From: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com> > > Add usb-typec detection support for Intel LGM SoC based > boards. > > Signed-off-by: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com> > --- > drivers/extcon/extcon-ptn5150.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/extcon/extcon-ptn5150.c b/drivers/extcon/extcon-ptn5150.c > index 8ba706fad887..60355a1b5cb2 100644 > --- a/drivers/extcon/extcon-ptn5150.c > +++ b/drivers/extcon/extcon-ptn5150.c > @@ -300,6 +300,8 @@ static int ptn5150_i2c_probe(struct i2c_client *i2c) > return ret; > } > > + extcon_set_property_capability(info->edev, EXTCON_USB_HOST, > + EXTCON_PROP_USB_TYPEC_POLARITY); Hi, I think you need the same for EXTCON_USB. Although extcon_set_property_capability() error should not be fatal, but printing a warn message would be useful. Best regards, Krzysztof > /* Initialize PTN5150 device and print vendor id and version id */ > ret = ptn5150_init_dev_type(info); > if (ret) > -- > 2.11.0 > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1 1/1] extcon: ptn5150: Add usb-typec support for Intel LGM SoC 2020-08-25 8:40 ` Krzysztof Kozlowski @ 2020-08-25 9:16 ` Ramuthevar, Vadivel MuruganX 0 siblings, 0 replies; 6+ messages in thread From: Ramuthevar, Vadivel MuruganX @ 2020-08-25 9:16 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: cw00.choi, linux-kernel, vijaikumar.kanagarajan, myungjoo.ham, cheol.yong.kim, qi-ming.wu, yin1.li Hi, Thank you for the review comments... On 25/8/2020 4:40 pm, Krzysztof Kozlowski wrote: > On Tue, Aug 25, 2020 at 04:31:47PM +0800, Ramuthevar,Vadivel MuruganX wrote: >> From: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com> >> >> Add usb-typec detection support for Intel LGM SoC based >> boards. >> >> Signed-off-by: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com> >> --- >> drivers/extcon/extcon-ptn5150.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/extcon/extcon-ptn5150.c b/drivers/extcon/extcon-ptn5150.c >> index 8ba706fad887..60355a1b5cb2 100644 >> --- a/drivers/extcon/extcon-ptn5150.c >> +++ b/drivers/extcon/extcon-ptn5150.c >> @@ -300,6 +300,8 @@ static int ptn5150_i2c_probe(struct i2c_client *i2c) >> return ret; >> } >> >> + extcon_set_property_capability(info->edev, EXTCON_USB_HOST, >> + EXTCON_PROP_USB_TYPEC_POLARITY); > > Hi, > > I think you need the same for EXTCON_USB. > > Although extcon_set_property_capability() error should not be fatal, but > printing a warn message would be useful. Yes , earlier we had like below settings in our patches, + extcon_set_property_capability(info->edev, EXTCON_USB, + EXTCON_PROP_USB_VBUS); + extcon_set_property_capability(info->edev, EXTCON_USB_HOST, + EXTCON_PROP_USB_VBUS); + extcon_set_property_capability(info->edev, EXTCON_USB_HOST, + EXTCON_PROP_USB_TYPEC_POLARITY); sure, will add warn message as well. Thanks! Best Regards Vadivel > > Best regards, > Krzysztof > > >> /* Initialize PTN5150 device and print vendor id and version id */ >> ret = ptn5150_init_dev_type(info); >> if (ret) >> -- >> 2.11.0 >> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1 1/1] extcon: ptn5150: Add usb-typec support for Intel LGM SoC 2020-08-25 8:31 ` [PATCH v1 1/1] " Ramuthevar,Vadivel MuruganX 2020-08-25 8:40 ` Krzysztof Kozlowski @ 2020-08-25 10:46 ` Chanwoo Choi 2020-08-26 3:32 ` Ramuthevar, Vadivel MuruganX 1 sibling, 1 reply; 6+ messages in thread From: Chanwoo Choi @ 2020-08-25 10:46 UTC (permalink / raw) To: Ramuthevar,Vadivel MuruganX, linux-kernel Cc: vijaikumar.kanagarajan, krzk, myungjoo.ham, cheol.yong.kim, qi-ming.wu, yin1.li Hi, On 8/25/20 5:31 PM, Ramuthevar,Vadivel MuruganX wrote: > From: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com> > > Add usb-typec detection support for Intel LGM SoC based > boards. > > Signed-off-by: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com> > --- > drivers/extcon/extcon-ptn5150.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/extcon/extcon-ptn5150.c b/drivers/extcon/extcon-ptn5150.c > index 8ba706fad887..60355a1b5cb2 100644 > --- a/drivers/extcon/extcon-ptn5150.c > +++ b/drivers/extcon/extcon-ptn5150.c > @@ -300,6 +300,8 @@ static int ptn5150_i2c_probe(struct i2c_client *i2c) > return ret; > } > > + extcon_set_property_capability(info->edev, EXTCON_USB_HOST, > + EXTCON_PROP_USB_TYPEC_POLARITY); extcon_set_property_capability() just sets the capability of EXTCON_PROP_USB_TYPEC_POLARITY property. If you want to set the value (0 or 1) of EXTCON_PROP_USB_TYPEC_POLARITY, we have to call extcon_set_property() function. But, this patch doesn't set the any value of EXTCON_PROP_USB_TYPEC_POLARITY property. Why do you only use extcon_set_property_capability() without the proper extcon_set_property()? > /* Initialize PTN5150 device and print vendor id and version id */ > ret = ptn5150_init_dev_type(info); > if (ret) > -- Best Regards, Chanwoo Choi Samsung Electronics ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1 1/1] extcon: ptn5150: Add usb-typec support for Intel LGM SoC 2020-08-25 10:46 ` Chanwoo Choi @ 2020-08-26 3:32 ` Ramuthevar, Vadivel MuruganX 0 siblings, 0 replies; 6+ messages in thread From: Ramuthevar, Vadivel MuruganX @ 2020-08-26 3:32 UTC (permalink / raw) To: Chanwoo Choi, linux-kernel Cc: vijaikumar.kanagarajan, krzk, myungjoo.ham, cheol.yong.kim, qi-ming.wu, yin1.li, heikki.krogerus Hi, Thank you very much for the review comments... On 25/8/2020 6:46 pm, Chanwoo Choi wrote: > Hi, > > On 8/25/20 5:31 PM, Ramuthevar,Vadivel MuruganX wrote: >> From: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com> >> >> Add usb-typec detection support for Intel LGM SoC based >> boards. >> >> Signed-off-by: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com> >> --- >> drivers/extcon/extcon-ptn5150.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/extcon/extcon-ptn5150.c b/drivers/extcon/extcon-ptn5150.c >> index 8ba706fad887..60355a1b5cb2 100644 >> --- a/drivers/extcon/extcon-ptn5150.c >> +++ b/drivers/extcon/extcon-ptn5150.c >> @@ -300,6 +300,8 @@ static int ptn5150_i2c_probe(struct i2c_client *i2c) >> return ret; >> } >> >> + extcon_set_property_capability(info->edev, EXTCON_USB_HOST, >> + EXTCON_PROP_USB_TYPEC_POLARITY); > > extcon_set_property_capability() just sets the capability > of EXTCON_PROP_USB_TYPEC_POLARITY property. > > If you want to set the value (0 or 1) of EXTCON_PROP_USB_TYPEC_POLARITY, > we have to call extcon_set_property() function. But, this patch doesn't > set the any value of EXTCON_PROP_USB_TYPEC_POLARITY property. > > Why do you only use extcon_set_property_capability() > without the proper extcon_set_property()? In extcon-ptn5150.c driver, we are not setting the capability of the EXTCON_PROP_USB_TYPEC_POLARITY and EXTCON_PROP_USB_VBUS, so USB-PHY driver try to get the value of POLARITY capability by calling extcon_get_property(), it returns error'ed value because we didn't set it. In drivers/extcon/extcon.c, below code snippet returns errored value. /* Check whether the property is supported or not */ if (!is_extcon_property_supported(id, prop)) return -EINVAL; To avoid the above condition, refered and followed the same from drivers/extcon/extcon-usbc-cros-ec.c extcon_set_property_capability(info->edev, EXTCON_USB, EXTCON_PROP_USB_VBUS); extcon_set_property_capability(info->edev, EXTCON_USB_HOST, EXTCON_PROP_USB_VBUS); extcon_set_property_capability(info->edev, EXTCON_USB, EXTCON_PROP_USB_TYPEC_POLARITY); ..................... after that, we follow the same to set the property capability then no error'ed value, it's working properly. Yes, you're right we can use extcon_set_property() API as well. I can update the code like below... extcon_set_property(info->edev,EXTCON_USB_HOST,EXTCON_PROP_USB_TYPEC_POLARITY, flipped); Regards Vadivel > >> /* Initialize PTN5150 device and print vendor id and version id */ >> ret = ptn5150_init_dev_type(info); >> if (ret) >> > > ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-08-26 3:32 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-08-25 8:31 [PATCH v1 0/1] extcon: ptn5150: Add usb-typec support for Intel LGM SoC Ramuthevar,Vadivel MuruganX 2020-08-25 8:31 ` [PATCH v1 1/1] " Ramuthevar,Vadivel MuruganX 2020-08-25 8:40 ` Krzysztof Kozlowski 2020-08-25 9:16 ` Ramuthevar, Vadivel MuruganX 2020-08-25 10:46 ` Chanwoo Choi 2020-08-26 3:32 ` Ramuthevar, Vadivel MuruganX
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).