linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: sun8i: r40: bananapi-m2-ultra: Fix dcdc1 regulator
@ 2020-08-24 19:36 Jernej Skrabec
  2020-08-24 20:54 ` [linux-sunxi] " Pablo Sebastián Greco
  2020-08-25  8:38 ` Maxime Ripard
  0 siblings, 2 replies; 4+ messages in thread
From: Jernej Skrabec @ 2020-08-24 19:36 UTC (permalink / raw)
  To: mripard, wens
  Cc: robh+dt, icenowy, devicetree, linux-arm-kernel, linux-kernel,
	linux-sunxi

DCDC1 regulator powers many different subsystems. While some of them can
work at 3.0 V, some of them can not. For example, VCC-HDMI can only work
between 3.24 V and 3.36 V. According to OS images provided by the board
manufacturer this regulator should be set to 3.3 V.

Set DCDC1 and DCDC1SW to 3.3 V in order to fix this.

Fixes: da7ac948fa93 ("ARM: dts: sun8i: Add board dts file for Banana Pi M2
		      Ultra")
Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
---
 arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts b/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts
index 42d62d1ba1dc..ea15073f0c79 100644
--- a/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts
+++ b/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts
@@ -223,16 +223,16 @@ &reg_aldo3 {
 };
 
 &reg_dc1sw {
-	regulator-min-microvolt = <3000000>;
-	regulator-max-microvolt = <3000000>;
+	regulator-min-microvolt = <3300000>;
+	regulator-max-microvolt = <3300000>;
 	regulator-name = "vcc-gmac-phy";
 };
 
 &reg_dcdc1 {
 	regulator-always-on;
-	regulator-min-microvolt = <3000000>;
-	regulator-max-microvolt = <3000000>;
-	regulator-name = "vcc-3v0";
+	regulator-min-microvolt = <3300000>;
+	regulator-max-microvolt = <3300000>;
+	regulator-name = "vcc-3v3";
 };
 
 &reg_dcdc2 {
-- 
2.28.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [linux-sunxi] [PATCH] ARM: dts: sun8i: r40: bananapi-m2-ultra: Fix dcdc1 regulator
  2020-08-24 19:36 [PATCH] ARM: dts: sun8i: r40: bananapi-m2-ultra: Fix dcdc1 regulator Jernej Skrabec
@ 2020-08-24 20:54 ` Pablo Sebastián Greco
  2020-08-24 21:02   ` Jernej Škrabec
  2020-08-25  8:38 ` Maxime Ripard
  1 sibling, 1 reply; 4+ messages in thread
From: Pablo Sebastián Greco @ 2020-08-24 20:54 UTC (permalink / raw)
  To: jernej.skrabec, mripard, wens
  Cc: robh+dt, icenowy, devicetree, linux-arm-kernel, linux-kernel,
	linux-sunxi


On 24/8/20 16:36, Jernej Skrabec wrote:
> DCDC1 regulator powers many different subsystems. While some of them can
> work at 3.0 V, some of them can not. For example, VCC-HDMI can only work
> between 3.24 V and 3.36 V. According to OS images provided by the board
> manufacturer this regulator should be set to 3.3 V.
>
> Set DCDC1 and DCDC1SW to 3.3 V in order to fix this.
>
> Fixes: da7ac948fa93 ("ARM: dts: sun8i: Add board dts file for Banana Pi M2
> 		      Ultra")
> Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
> ---
>   arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts b/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts
> index 42d62d1ba1dc..ea15073f0c79 100644
> --- a/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts
> +++ b/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts
> @@ -223,16 +223,16 @@ &reg_aldo3 {
>   };
>   
>   &reg_dc1sw {
> -	regulator-min-microvolt = <3000000>;
> -	regulator-max-microvolt = <3000000>;
> +	regulator-min-microvolt = <3300000>;
> +	regulator-max-microvolt = <3300000>;
>   	regulator-name = "vcc-gmac-phy";
>   };
>   
>   &reg_dcdc1 {
>   	regulator-always-on;
> -	regulator-min-microvolt = <3000000>;
> -	regulator-max-microvolt = <3000000>;
> -	regulator-name = "vcc-3v0";
> +	regulator-min-microvolt = <3300000>;
> +	regulator-max-microvolt = <3300000>;
> +	regulator-name = "vcc-3v3";
>   };
>   
>   &reg_dcdc2 {


Should this be done also for the bananapi-m2-berry?, it is basically the 
same device
sun8i-v40-bananapi-m2-berry.dts


Pablo


^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [linux-sunxi] [PATCH] ARM: dts: sun8i: r40: bananapi-m2-ultra: Fix dcdc1 regulator
  2020-08-24 20:54 ` [linux-sunxi] " Pablo Sebastián Greco
@ 2020-08-24 21:02   ` Jernej Škrabec
  0 siblings, 0 replies; 4+ messages in thread
From: Jernej Škrabec @ 2020-08-24 21:02 UTC (permalink / raw)
  To: mripard, wens, Pablo Sebastián Greco
  Cc: robh+dt, icenowy, devicetree, linux-arm-kernel, linux-kernel,
	linux-sunxi

Dne ponedeljek, 24. avgust 2020 ob 22:54:01 CEST je Pablo Sebastián Greco 
napisal(a):
> On 24/8/20 16:36, Jernej Skrabec wrote:
> > DCDC1 regulator powers many different subsystems. While some of them can
> > work at 3.0 V, some of them can not. For example, VCC-HDMI can only work
> > between 3.24 V and 3.36 V. According to OS images provided by the board
> > manufacturer this regulator should be set to 3.3 V.
> > 
> > Set DCDC1 and DCDC1SW to 3.3 V in order to fix this.
> > 
> > Fixes: da7ac948fa93 ("ARM: dts: sun8i: Add board dts file for Banana Pi M2
> > 
> > 		      Ultra")
> > 
> > Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
> > ---
> > 
> >   arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts | 10 +++++-----
> >   1 file changed, 5 insertions(+), 5 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts
> > b/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts index
> > 42d62d1ba1dc..ea15073f0c79 100644
> > --- a/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts
> > +++ b/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts
> > @@ -223,16 +223,16 @@ &reg_aldo3 {
> > 
> >   };
> >   
> >   &reg_dc1sw {
> > 
> > -	regulator-min-microvolt = <3000000>;
> > -	regulator-max-microvolt = <3000000>;
> > +	regulator-min-microvolt = <3300000>;
> > +	regulator-max-microvolt = <3300000>;
> > 
> >   	regulator-name = "vcc-gmac-phy";
> >   
> >   };
> >   
> >   &reg_dcdc1 {
> >   
> >   	regulator-always-on;
> > 
> > -	regulator-min-microvolt = <3000000>;
> > -	regulator-max-microvolt = <3000000>;
> > -	regulator-name = "vcc-3v0";
> > +	regulator-min-microvolt = <3300000>;
> > +	regulator-max-microvolt = <3300000>;
> > +	regulator-name = "vcc-3v3";
> > 
> >   };
> >   
> >   &reg_dcdc2 {
> 
> Should this be done also for the bananapi-m2-berry?, it is basically the
> same device
> sun8i-v40-bananapi-m2-berry.dts

I think so but I would rather not do that without testing and I don't have 
that board.

Best regards,
Jernej




^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: sun8i: r40: bananapi-m2-ultra: Fix dcdc1 regulator
  2020-08-24 19:36 [PATCH] ARM: dts: sun8i: r40: bananapi-m2-ultra: Fix dcdc1 regulator Jernej Skrabec
  2020-08-24 20:54 ` [linux-sunxi] " Pablo Sebastián Greco
@ 2020-08-25  8:38 ` Maxime Ripard
  1 sibling, 0 replies; 4+ messages in thread
From: Maxime Ripard @ 2020-08-25  8:38 UTC (permalink / raw)
  To: Jernej Skrabec
  Cc: wens, robh+dt, icenowy, devicetree, linux-arm-kernel,
	linux-kernel, linux-sunxi

[-- Attachment #1: Type: text/plain, Size: 596 bytes --]

On Mon, Aug 24, 2020 at 09:36:49PM +0200, Jernej Skrabec wrote:
> DCDC1 regulator powers many different subsystems. While some of them can
> work at 3.0 V, some of them can not. For example, VCC-HDMI can only work
> between 3.24 V and 3.36 V. According to OS images provided by the board
> manufacturer this regulator should be set to 3.3 V.
> 
> Set DCDC1 and DCDC1SW to 3.3 V in order to fix this.
> 
> Fixes: da7ac948fa93 ("ARM: dts: sun8i: Add board dts file for Banana Pi M2
> 		      Ultra")
> Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>

Applied, thanks

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-08-25 13:36 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-24 19:36 [PATCH] ARM: dts: sun8i: r40: bananapi-m2-ultra: Fix dcdc1 regulator Jernej Skrabec
2020-08-24 20:54 ` [linux-sunxi] " Pablo Sebastián Greco
2020-08-24 21:02   ` Jernej Škrabec
2020-08-25  8:38 ` Maxime Ripard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).