linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [net-next v5 2/2] seg6: Add documentation for seg6_inherit_inner_ipv4_dscp sysctl
@ 2020-08-25 12:18 Ahmed Abdelsalam
  2020-08-25 15:51 ` Jakub Kicinski
  0 siblings, 1 reply; 5+ messages in thread
From: Ahmed Abdelsalam @ 2020-08-25 12:18 UTC (permalink / raw)
  To: David S. Miller, Jakub Kicinski, Jonathan Corbet, netdev,
	linux-doc, linux-kernel
  Cc: ahabdels, andrea.mayer

This patch adds a documentation for seg6_inherit_inner_ipv4_dscp
sysctl into Documentation/networking/ip-sysctl.rst

Signed-off-by: Ahmed Abdelsalam <ahabdels@gmail.com>
---
 Documentation/networking/ip-sysctl.rst | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Documentation/networking/ip-sysctl.rst b/Documentation/networking/ip-sysctl.rst
index 837d51f9e1fa..9dacdebeafc5 100644
--- a/Documentation/networking/ip-sysctl.rst
+++ b/Documentation/networking/ip-sysctl.rst
@@ -1799,6 +1799,11 @@ seg6_flowlabel - INTEGER
 
 	Default is 0.
 
+seg6_inherit_inner_ipv4_dscp - BOOLEAN                                                                                                                                                                                                                                                                                                        
+	Enable the SRv6 encapsulation to inherit the DSCP value of the inner IPv4 packet.                                                                                                         
+
+	Default: FALSE (Do not inherit DSCP)
+
 ``conf/default/*``:
 	Change the interface-specific default settings.
 
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [net-next v5 2/2] seg6: Add documentation for seg6_inherit_inner_ipv4_dscp sysctl
  2020-08-25 12:18 [net-next v5 2/2] seg6: Add documentation for seg6_inherit_inner_ipv4_dscp sysctl Ahmed Abdelsalam
@ 2020-08-25 15:51 ` Jakub Kicinski
  2020-08-25 16:01   ` Ahmed Abdelsalam
  0 siblings, 1 reply; 5+ messages in thread
From: Jakub Kicinski @ 2020-08-25 15:51 UTC (permalink / raw)
  To: Ahmed Abdelsalam
  Cc: David S. Miller, Jonathan Corbet, netdev, linux-doc,
	linux-kernel, andrea.mayer

On Tue, 25 Aug 2020 12:18:44 +0000 Ahmed Abdelsalam wrote:
> +	Enable the SRv6 encapsulation to inherit the DSCP value of the inner IPv4 packet.                                                                                                         
> +
> +	Default: FALSE (Do not inherit DSCP)
> +
>  ``conf/default/*``:
>  	Change the interface-specific default settings.
>  

Checkpatch complains about whitespace:

ERROR: trailing whitespace
#24: FILE: Documentation/networking/ip-sysctl.rst:1802:
+seg6_inherit_inner_ipv4_dscp - BOOLEAN                                                                                                                                                                                                                                                                                                        $

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [net-next v5 2/2] seg6: Add documentation for seg6_inherit_inner_ipv4_dscp sysctl
  2020-08-25 15:51 ` Jakub Kicinski
@ 2020-08-25 16:01   ` Ahmed Abdelsalam
  2020-08-25 16:23     ` David Miller
  0 siblings, 1 reply; 5+ messages in thread
From: Ahmed Abdelsalam @ 2020-08-25 16:01 UTC (permalink / raw)
  To: Jakub Kicinski
  Cc: David S. Miller, Jonathan Corbet, netdev, linux-doc,
	linux-kernel, andrea.mayer



On 25/08/2020 17:51, Jakub Kicinski wrote:
> On Tue, 25 Aug 2020 12:18:44 +0000 Ahmed Abdelsalam wrote:
>> +	Enable the SRv6 encapsulation to inherit the DSCP value of the inner IPv4 packet.
>> +
>> +	Default: FALSE (Do not inherit DSCP)
>> +
>>   ``conf/default/*``:
>>   	Change the interface-specific default settings.
>>   
> 
> Checkpatch complains about whitespace:
> 
> ERROR: trailing whitespace
> #24: FILE: Documentation/networking/ip-sysctl.rst:1802:
> +seg6_inherit_inner_ipv4_dscp - BOOLEAN                                                                                                                                                                                                                                                                                                        $
> 
sorry forgot to run checkpatch on this one before sending.

patch fixed and resent.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [net-next v5 2/2] seg6: Add documentation for seg6_inherit_inner_ipv4_dscp sysctl
  2020-08-25 16:01   ` Ahmed Abdelsalam
@ 2020-08-25 16:23     ` David Miller
  0 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2020-08-25 16:23 UTC (permalink / raw)
  To: ahabdels; +Cc: kuba, corbet, netdev, linux-doc, linux-kernel, andrea.mayer

From: Ahmed Abdelsalam <ahabdels@gmail.com>
Date: Tue, 25 Aug 2020 18:01:01 +0200

> patch fixed and resent.

You must resubmit the entire patch series when you update any
patch in the series.

You should also provide a proper header "[PATCH 0/N]" posting
for your series which explains what the series does, how does
it do it, and why does it do it that way.

Thank you.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [net-next v5 2/2] seg6: Add documentation for seg6_inherit_inner_ipv4_dscp sysctl
@ 2020-08-25 15:58 Ahmed Abdelsalam
  0 siblings, 0 replies; 5+ messages in thread
From: Ahmed Abdelsalam @ 2020-08-25 15:58 UTC (permalink / raw)
  To: David S. Miller, Jakub Kicinski, Jonathan Corbet, netdev,
	linux-doc, linux-kernel
  Cc: ahabdels, andrea.mayer

This patch adds a documentation for seg6_inherit_inner_ipv4_dscp
sysctl into Documentation/networking/ip-sysctl.rst

Signed-off-by: Ahmed Abdelsalam <ahabdels@gmail.com>
---
 Documentation/networking/ip-sysctl.rst | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Documentation/networking/ip-sysctl.rst b/Documentation/networking/ip-sysctl.rst
index 837d51f9e1fa..9dacdebeafc5 100644
--- a/Documentation/networking/ip-sysctl.rst
+++ b/Documentation/networking/ip-sysctl.rst
@@ -1799,6 +1799,11 @@ seg6_flowlabel - INTEGER
 
 	Default is 0.
 
+seg6_inherit_inner_ipv4_dscp - BOOLEAN
+	Enable the SRv6 encapsulation to inherit the DSCP value of the inner IPv4 packet.
+
+	Default: FALSE (Do not inherit DSCP)
+
 ``conf/default/*``:
 	Change the interface-specific default settings.
 
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-08-25 16:23 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-25 12:18 [net-next v5 2/2] seg6: Add documentation for seg6_inherit_inner_ipv4_dscp sysctl Ahmed Abdelsalam
2020-08-25 15:51 ` Jakub Kicinski
2020-08-25 16:01   ` Ahmed Abdelsalam
2020-08-25 16:23     ` David Miller
2020-08-25 15:58 Ahmed Abdelsalam

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).