* [PATCH] clk: imx: fix composite peripheral flags
@ 2020-08-26 7:14 peng.fan
2020-09-05 1:35 ` Shawn Guo
0 siblings, 1 reply; 2+ messages in thread
From: peng.fan @ 2020-08-26 7:14 UTC (permalink / raw)
To: sboyd, shawnguo, s.hauer
Cc: kernel, festevam, linux-imx, abel.vesa, Anson.Huang, linux-clk,
linux-arm-kernel, linux-kernel, Peng Fan
From: Peng Fan <peng.fan@nxp.com>
According to RM, for peripheral clock slice,
"IP clock slices must be stopped to change the clock source.".
So we must have CLK_SET_PARENT_GATE flag to avoid glitch.
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
drivers/clk/imx/clk-composite-8m.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/imx/clk-composite-8m.c b/drivers/clk/imx/clk-composite-8m.c
index 78fb7e52a42a..2c309e3dc8e3 100644
--- a/drivers/clk/imx/clk-composite-8m.c
+++ b/drivers/clk/imx/clk-composite-8m.c
@@ -216,6 +216,7 @@ struct clk_hw *imx8m_clk_hw_composite_flags(const char *name,
div->width = PCG_PREDIV_WIDTH;
divider_ops = &imx8m_clk_composite_divider_ops;
mux_ops = &clk_mux_ops;
+ flags |= CLK_SET_PARENT_GATE;
}
div->lock = &imx_ccm_lock;
--
2.28.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] clk: imx: fix composite peripheral flags
2020-08-26 7:14 [PATCH] clk: imx: fix composite peripheral flags peng.fan
@ 2020-09-05 1:35 ` Shawn Guo
0 siblings, 0 replies; 2+ messages in thread
From: Shawn Guo @ 2020-09-05 1:35 UTC (permalink / raw)
To: peng.fan
Cc: sboyd, s.hauer, kernel, festevam, linux-imx, abel.vesa,
Anson.Huang, linux-clk, linux-arm-kernel, linux-kernel
On Wed, Aug 26, 2020 at 03:14:07PM +0800, peng.fan@nxp.com wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> According to RM, for peripheral clock slice,
> "IP clock slices must be stopped to change the clock source.".
>
> So we must have CLK_SET_PARENT_GATE flag to avoid glitch.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-05 1:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-26 7:14 [PATCH] clk: imx: fix composite peripheral flags peng.fan
2020-09-05 1:35 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).