* [PATCH] memory: fsl-corenet-cf: Fix handling of platform_get_irq() error
@ 2020-08-27 7:33 Krzysztof Kozlowski
2020-09-02 15:32 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Kozlowski @ 2020-08-27 7:33 UTC (permalink / raw)
To: Krzysztof Kozlowski, Scott Wood, Bharat Bhushan, linux-kernel
platform_get_irq() returns -ERRNO on error. In such case comparison
to 0 would pass the check.
Fixes: 54afbec0d57f ("memory: Freescale CoreNet Coherency Fabric error reporting driver")
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/memory/fsl-corenet-cf.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/memory/fsl-corenet-cf.c b/drivers/memory/fsl-corenet-cf.c
index 0b0ed72016da..0309bd5a1800 100644
--- a/drivers/memory/fsl-corenet-cf.c
+++ b/drivers/memory/fsl-corenet-cf.c
@@ -211,10 +211,8 @@ static int ccf_probe(struct platform_device *pdev)
dev_set_drvdata(&pdev->dev, ccf);
irq = platform_get_irq(pdev, 0);
- if (!irq) {
- dev_err(&pdev->dev, "%s: no irq\n", __func__);
- return -ENXIO;
- }
+ if (irq < 0)
+ return irq;
ret = devm_request_irq(&pdev->dev, irq, ccf_irq, 0, pdev->name, ccf);
if (ret) {
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] memory: fsl-corenet-cf: Fix handling of platform_get_irq() error
2020-08-27 7:33 [PATCH] memory: fsl-corenet-cf: Fix handling of platform_get_irq() error Krzysztof Kozlowski
@ 2020-09-02 15:32 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-02 15:32 UTC (permalink / raw)
To: Scott Wood, Bharat Bhushan, linux-kernel
On Thu, Aug 27, 2020 at 09:33:15AM +0200, Krzysztof Kozlowski wrote:
> platform_get_irq() returns -ERRNO on error. In such case comparison
> to 0 would pass the check.
>
> Fixes: 54afbec0d57f ("memory: Freescale CoreNet Coherency Fabric error reporting driver")
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> drivers/memory/fsl-corenet-cf.c | 6 ++----
Applied.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-02 15:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-27 7:33 [PATCH] memory: fsl-corenet-cf: Fix handling of platform_get_irq() error Krzysztof Kozlowski
2020-09-02 15:32 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).