* [PATCH] net: Add 'else' to split mutually exclusive case
@ 2020-08-27 11:15 Miaohe Lin
2020-08-27 16:10 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Miaohe Lin @ 2020-08-27 11:15 UTC (permalink / raw)
To: davem, kuznet, yoshfuji, kuba; +Cc: netdev, linux-kernel, linmiaohe
Add else to split mutually exclusive case and avoid unnecessary check.
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
net/ipv4/ping.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/ping.c b/net/ipv4/ping.c
index 19a947bf0faa..265676fd2bbd 100644
--- a/net/ipv4/ping.c
+++ b/net/ipv4/ping.c
@@ -422,7 +422,7 @@ int ping_bind(struct sock *sk, struct sockaddr *uaddr, int addr_len)
if (sk->sk_family == AF_INET && isk->inet_rcv_saddr)
sk->sk_userlocks |= SOCK_BINDADDR_LOCK;
#if IS_ENABLED(CONFIG_IPV6)
- if (sk->sk_family == AF_INET6 && !ipv6_addr_any(&sk->sk_v6_rcv_saddr))
+ else if (sk->sk_family == AF_INET6 && !ipv6_addr_any(&sk->sk_v6_rcv_saddr))
sk->sk_userlocks |= SOCK_BINDADDR_LOCK;
#endif
--
2.19.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: Add 'else' to split mutually exclusive case
2020-08-27 11:15 [PATCH] net: Add 'else' to split mutually exclusive case Miaohe Lin
@ 2020-08-27 16:10 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-08-27 16:10 UTC (permalink / raw)
To: linmiaohe; +Cc: kuznet, yoshfuji, kuba, netdev, linux-kernel
From: Miaohe Lin <linmiaohe@huawei.com>
Date: Thu, 27 Aug 2020 07:15:52 -0400
> Add else to split mutually exclusive case and avoid unnecessary check.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
I see no value to this, the compiler is doing the right thing already
and this does not add to code readability either.
I'm not applying this, sorry.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-27 16:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-27 11:15 [PATCH] net: Add 'else' to split mutually exclusive case Miaohe Lin
2020-08-27 16:10 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).