From: kernel test robot <lkp@intel.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
Herbert Xu <herbert@gondor.apana.org.au>
Subject: lib/crypto/chacha.c:65:1: warning: the frame size of 1604 bytes is larger than 1024 bytes
Date: Thu, 27 Aug 2020 11:52:50 +0800 [thread overview]
Message-ID: <202008271145.xE8qIAjp%lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 6629 bytes --]
Hi Ard,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 15bc20c6af4ceee97a1f90b43c0e386643c071b4
commit: 5fb8ef25803ef33e2eb60b626435828b937bed75 crypto: chacha - move existing library code into lib/crypto
date: 9 months ago
config: i386-randconfig-r015-20200827 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
git checkout 5fb8ef25803ef33e2eb60b626435828b937bed75
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
lib/crypto/chacha.c: In function 'chacha_permute':
>> lib/crypto/chacha.c:65:1: warning: the frame size of 1604 bytes is larger than 1024 bytes [-Wframe-larger-than=]
65 | }
| ^
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=5fb8ef25803ef33e2eb60b626435828b937bed75
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 5fb8ef25803ef33e2eb60b626435828b937bed75
vim +65 lib/crypto/chacha.c
e192be9d9a3055 lib/chacha20.c Theodore Ts'o 2016-06-12 16
1ca1b917940c24 lib/chacha.c Eric Biggers 2018-11-16 17 static void chacha_permute(u32 *x, int nrounds)
e192be9d9a3055 lib/chacha20.c Theodore Ts'o 2016-06-12 18 {
e192be9d9a3055 lib/chacha20.c Theodore Ts'o 2016-06-12 19 int i;
e192be9d9a3055 lib/chacha20.c Theodore Ts'o 2016-06-12 20
1ca1b917940c24 lib/chacha.c Eric Biggers 2018-11-16 21 /* whitelist the allowed round counts */
aa7624093cb7fb lib/chacha.c Eric Biggers 2018-11-16 22 WARN_ON_ONCE(nrounds != 20 && nrounds != 12);
1ca1b917940c24 lib/chacha.c Eric Biggers 2018-11-16 23
1ca1b917940c24 lib/chacha.c Eric Biggers 2018-11-16 24 for (i = 0; i < nrounds; i += 2) {
7660b1fb367eb3 lib/chacha20.c Eric Biggers 2017-12-31 25 x[0] += x[4]; x[12] = rol32(x[12] ^ x[0], 16);
7660b1fb367eb3 lib/chacha20.c Eric Biggers 2017-12-31 26 x[1] += x[5]; x[13] = rol32(x[13] ^ x[1], 16);
7660b1fb367eb3 lib/chacha20.c Eric Biggers 2017-12-31 27 x[2] += x[6]; x[14] = rol32(x[14] ^ x[2], 16);
7660b1fb367eb3 lib/chacha20.c Eric Biggers 2017-12-31 28 x[3] += x[7]; x[15] = rol32(x[15] ^ x[3], 16);
e192be9d9a3055 lib/chacha20.c Theodore Ts'o 2016-06-12 29
7660b1fb367eb3 lib/chacha20.c Eric Biggers 2017-12-31 30 x[8] += x[12]; x[4] = rol32(x[4] ^ x[8], 12);
7660b1fb367eb3 lib/chacha20.c Eric Biggers 2017-12-31 31 x[9] += x[13]; x[5] = rol32(x[5] ^ x[9], 12);
7660b1fb367eb3 lib/chacha20.c Eric Biggers 2017-12-31 32 x[10] += x[14]; x[6] = rol32(x[6] ^ x[10], 12);
7660b1fb367eb3 lib/chacha20.c Eric Biggers 2017-12-31 33 x[11] += x[15]; x[7] = rol32(x[7] ^ x[11], 12);
e192be9d9a3055 lib/chacha20.c Theodore Ts'o 2016-06-12 34
7660b1fb367eb3 lib/chacha20.c Eric Biggers 2017-12-31 35 x[0] += x[4]; x[12] = rol32(x[12] ^ x[0], 8);
7660b1fb367eb3 lib/chacha20.c Eric Biggers 2017-12-31 36 x[1] += x[5]; x[13] = rol32(x[13] ^ x[1], 8);
7660b1fb367eb3 lib/chacha20.c Eric Biggers 2017-12-31 37 x[2] += x[6]; x[14] = rol32(x[14] ^ x[2], 8);
7660b1fb367eb3 lib/chacha20.c Eric Biggers 2017-12-31 38 x[3] += x[7]; x[15] = rol32(x[15] ^ x[3], 8);
e192be9d9a3055 lib/chacha20.c Theodore Ts'o 2016-06-12 39
7660b1fb367eb3 lib/chacha20.c Eric Biggers 2017-12-31 40 x[8] += x[12]; x[4] = rol32(x[4] ^ x[8], 7);
7660b1fb367eb3 lib/chacha20.c Eric Biggers 2017-12-31 41 x[9] += x[13]; x[5] = rol32(x[5] ^ x[9], 7);
7660b1fb367eb3 lib/chacha20.c Eric Biggers 2017-12-31 42 x[10] += x[14]; x[6] = rol32(x[6] ^ x[10], 7);
7660b1fb367eb3 lib/chacha20.c Eric Biggers 2017-12-31 43 x[11] += x[15]; x[7] = rol32(x[7] ^ x[11], 7);
e192be9d9a3055 lib/chacha20.c Theodore Ts'o 2016-06-12 44
7660b1fb367eb3 lib/chacha20.c Eric Biggers 2017-12-31 45 x[0] += x[5]; x[15] = rol32(x[15] ^ x[0], 16);
7660b1fb367eb3 lib/chacha20.c Eric Biggers 2017-12-31 46 x[1] += x[6]; x[12] = rol32(x[12] ^ x[1], 16);
7660b1fb367eb3 lib/chacha20.c Eric Biggers 2017-12-31 47 x[2] += x[7]; x[13] = rol32(x[13] ^ x[2], 16);
7660b1fb367eb3 lib/chacha20.c Eric Biggers 2017-12-31 48 x[3] += x[4]; x[14] = rol32(x[14] ^ x[3], 16);
e192be9d9a3055 lib/chacha20.c Theodore Ts'o 2016-06-12 49
7660b1fb367eb3 lib/chacha20.c Eric Biggers 2017-12-31 50 x[10] += x[15]; x[5] = rol32(x[5] ^ x[10], 12);
7660b1fb367eb3 lib/chacha20.c Eric Biggers 2017-12-31 51 x[11] += x[12]; x[6] = rol32(x[6] ^ x[11], 12);
7660b1fb367eb3 lib/chacha20.c Eric Biggers 2017-12-31 52 x[8] += x[13]; x[7] = rol32(x[7] ^ x[8], 12);
7660b1fb367eb3 lib/chacha20.c Eric Biggers 2017-12-31 53 x[9] += x[14]; x[4] = rol32(x[4] ^ x[9], 12);
e192be9d9a3055 lib/chacha20.c Theodore Ts'o 2016-06-12 54
7660b1fb367eb3 lib/chacha20.c Eric Biggers 2017-12-31 55 x[0] += x[5]; x[15] = rol32(x[15] ^ x[0], 8);
7660b1fb367eb3 lib/chacha20.c Eric Biggers 2017-12-31 56 x[1] += x[6]; x[12] = rol32(x[12] ^ x[1], 8);
7660b1fb367eb3 lib/chacha20.c Eric Biggers 2017-12-31 57 x[2] += x[7]; x[13] = rol32(x[13] ^ x[2], 8);
7660b1fb367eb3 lib/chacha20.c Eric Biggers 2017-12-31 58 x[3] += x[4]; x[14] = rol32(x[14] ^ x[3], 8);
e192be9d9a3055 lib/chacha20.c Theodore Ts'o 2016-06-12 59
7660b1fb367eb3 lib/chacha20.c Eric Biggers 2017-12-31 60 x[10] += x[15]; x[5] = rol32(x[5] ^ x[10], 7);
7660b1fb367eb3 lib/chacha20.c Eric Biggers 2017-12-31 61 x[11] += x[12]; x[6] = rol32(x[6] ^ x[11], 7);
7660b1fb367eb3 lib/chacha20.c Eric Biggers 2017-12-31 62 x[8] += x[13]; x[7] = rol32(x[7] ^ x[8], 7);
7660b1fb367eb3 lib/chacha20.c Eric Biggers 2017-12-31 63 x[9] += x[14]; x[4] = rol32(x[4] ^ x[9], 7);
e192be9d9a3055 lib/chacha20.c Theodore Ts'o 2016-06-12 64 }
dd333449d0fb66 lib/chacha20.c Eric Biggers 2018-11-16 @65 }
dd333449d0fb66 lib/chacha20.c Eric Biggers 2018-11-16 66
:::::: The code at line 65 was first introduced by commit
:::::: dd333449d0fb667c5250c42488a7e90470e16c77 crypto: chacha20-generic - add HChaCha20 library function
:::::: TO: Eric Biggers <ebiggers@google.com>
:::::: CC: Herbert Xu <herbert@gondor.apana.org.au>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 34663 bytes --]
next reply other threads:[~2020-08-27 4:14 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 3:52 kernel test robot [this message]
2020-08-27 8:05 ` lib/crypto/chacha.c:65:1: warning: the frame size of 1604 bytes is larger than 1024 bytes Herbert Xu
2020-08-27 8:10 ` Ard Biesheuvel
2020-08-27 8:24 ` Herbert Xu
2020-08-27 17:34 ` Linus Torvalds
2020-08-27 17:55 ` Linus Torvalds
2020-08-27 18:42 ` Kees Cook
2020-08-27 19:02 ` Linus Torvalds
2020-08-27 19:32 ` Kees Cook
2020-08-27 19:11 ` Arnd Bergmann
2020-08-27 19:34 ` Kees Cook
2020-08-27 20:08 ` Linus Torvalds
2020-08-27 8:33 ` Arnd Bergmann
2020-08-27 8:42 ` Ard Biesheuvel
2020-08-27 9:19 ` Arnd Bergmann
2020-08-27 10:41 ` Ard Biesheuvel
2020-08-27 11:51 ` Herbert Xu
2020-08-27 16:25 ` Arnd Bergmann
2020-09-19 17:27 kernel test robot
2020-10-18 19:13 kernel test robot
2020-10-19 15:47 ` Joe Perches
2020-10-20 8:00 ` David Laight
2020-10-20 10:13 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202008271145.xE8qIAjp%lkp@intel.com \
--to=lkp@intel.com \
--cc=ardb@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).