* [PATCH] net: dsa: mt7530: fix advertising unsupported
@ 2020-08-27 9:15 Landen Chao
2020-08-28 1:23 ` Andrew Lunn
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Landen Chao @ 2020-08-27 9:15 UTC (permalink / raw)
To: Sean Wang, Andrew Lunn, Vivien Didelot, Florian Fainelli,
David S . Miller, Jakub Kicinski, Matthias Brugger, Russell King
Cc: opensource, netdev, linux-arm-kernel, linux-mediatek,
linux-kernel, frank-w, dqfext, Landen Chao
1000baseT_Half
Remove 1000baseT_Half to advertise correct hardware capability in
phylink_validate() callback function.
Fixes: 38f790a80560 ("net: dsa: mt7530: Add support for port 5")
Signed-off-by: Landen Chao <landen.chao@mediatek.com>
---
drivers/net/dsa/mt7530.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c
index 8dcb8a49ab67..238417db26f9 100644
--- a/drivers/net/dsa/mt7530.c
+++ b/drivers/net/dsa/mt7530.c
@@ -1501,7 +1501,7 @@ static void mt7530_phylink_validate(struct dsa_switch *ds, int port,
phylink_set(mask, 100baseT_Full);
if (state->interface != PHY_INTERFACE_MODE_MII) {
- phylink_set(mask, 1000baseT_Half);
+ /* This switch only supports 1G full-duplex. */
phylink_set(mask, 1000baseT_Full);
if (port == 5)
phylink_set(mask, 1000baseX_Full);
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] net: dsa: mt7530: fix advertising unsupported
2020-08-27 9:15 [PATCH] net: dsa: mt7530: fix advertising unsupported Landen Chao
@ 2020-08-28 1:23 ` Andrew Lunn
2020-08-28 3:17 ` Florian Fainelli
2020-08-28 13:55 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Andrew Lunn @ 2020-08-28 1:23 UTC (permalink / raw)
To: Landen Chao
Cc: Sean Wang, Vivien Didelot, Florian Fainelli, David S . Miller,
Jakub Kicinski, Matthias Brugger, Russell King, opensource,
netdev, linux-arm-kernel, linux-mediatek, linux-kernel, frank-w,
dqfext
On Thu, Aug 27, 2020 at 05:15:47PM +0800, Landen Chao wrote:
> 1000baseT_Half
>
> Remove 1000baseT_Half to advertise correct hardware capability in
> phylink_validate() callback function.
>
> Fixes: 38f790a80560 ("net: dsa: mt7530: Add support for port 5")
> Signed-off-by: Landen Chao <landen.chao@mediatek.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net: dsa: mt7530: fix advertising unsupported
2020-08-27 9:15 [PATCH] net: dsa: mt7530: fix advertising unsupported Landen Chao
2020-08-28 1:23 ` Andrew Lunn
@ 2020-08-28 3:17 ` Florian Fainelli
2020-08-28 13:55 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2020-08-28 3:17 UTC (permalink / raw)
To: Landen Chao, Sean Wang, Andrew Lunn, Vivien Didelot,
David S . Miller, Jakub Kicinski, Matthias Brugger, Russell King
Cc: opensource, netdev, linux-arm-kernel, linux-mediatek,
linux-kernel, frank-w, dqfext
On 8/27/2020 2:15 AM, Landen Chao wrote:
> 1000baseT_Half
Looks like this part of the commit subject spilled into the commit message.
>
> Remove 1000baseT_Half to advertise correct hardware capability in
> phylink_validate() callback function.
>
> Fixes: 38f790a80560 ("net: dsa: mt7530: Add support for port 5")
> Signed-off-by: Landen Chao <landen.chao@mediatek.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net: dsa: mt7530: fix advertising unsupported
2020-08-27 9:15 [PATCH] net: dsa: mt7530: fix advertising unsupported Landen Chao
2020-08-28 1:23 ` Andrew Lunn
2020-08-28 3:17 ` Florian Fainelli
@ 2020-08-28 13:55 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2020-08-28 13:55 UTC (permalink / raw)
To: landen.chao
Cc: sean.wang, andrew, vivien.didelot, f.fainelli, kuba,
matthias.bgg, linux, opensource, netdev, linux-arm-kernel,
linux-mediatek, linux-kernel, frank-w, dqfext
From: Landen Chao <landen.chao@mediatek.com>
Date: Thu, 27 Aug 2020 17:15:47 +0800
> 1000baseT_Half
>
> Remove 1000baseT_Half to advertise correct hardware capability in
> phylink_validate() callback function.
>
> Fixes: 38f790a80560 ("net: dsa: mt7530: Add support for port 5")
> Signed-off-by: Landen Chao <landen.chao@mediatek.com>
Applied and queued up for -stablel, with Subject line spillage
fixed, thank you.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-08-28 13:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-27 9:15 [PATCH] net: dsa: mt7530: fix advertising unsupported Landen Chao
2020-08-28 1:23 ` Andrew Lunn
2020-08-28 3:17 ` Florian Fainelli
2020-08-28 13:55 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).