From: Vinod Koul <vkoul@kernel.org>
To: "Reddy, MallikarjunaX" <mallikarjunax.reddy@linux.intel.com>
Cc: Rob Herring <robh@kernel.org>,
dmaengine@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, andriy.shevchenko@intel.com,
cheol.yong.kim@intel.com, qi-ming.wu@intel.com,
chuanhua.lei@linux.intel.com, malliamireddy009@gmail.com
Subject: Re: [PATCH v5 1/2] dt-bindings: dma: Add bindings for intel LGM SOC
Date: Fri, 28 Aug 2020 16:15:30 +0530 [thread overview]
Message-ID: <20200828104530.GT2639@vkoul-mobl> (raw)
In-Reply-To: <ffa5ba4d-f1b2-6a30-f2f1-f4578a77bce2@linux.intel.com>
On 27-08-20, 17:54, Reddy, MallikarjunaX wrote:
> Hi Vinod,
> Thanks for the review comments.
>
> On 8/25/2020 7:21 PM, Vinod Koul wrote:
> > On 18-08-20, 15:00, Reddy, MallikarjunaX wrote:
> >
> > > > > +
> > > > > + intel,chans:
> > > > > + $ref: /schemas/types.yaml#/definitions/uint32-array
> > > > > + description:
> > > > > + The channels included on this port. Format is channel start
> > > > > + number and how many channels on this port.
> > > > Why does this need to be in DT? This all seems like it can be in the dma
> > > > cells for each client.
> > > (*ABC)
> > > Yes. We need this.
> > > for dma0(lgm-cdma) old SOC supports 16 channels and the new SOC supports 22
> > > channels. and the logical channel mapping for the peripherals also differ
> > > b/w old and new SOCs.
> > >
> > > Because of this hardware limitation we are trying to configure the total
> > > channels and port-channel mapping dynamically from device tree.
> > >
> > > based on port name we are trying to configure the default values for
> > > different peripherals(ports).
> > > Example: burst length is not same for all ports, so using port name to do
> > > default configurations.
> > Sorry that does not make sense to me, why not specify the values to be
> > used here instead of defining your own name scheme!
> OK. Agreed. I will remove port name from DT and only use intel,chans
what is intel,chans, why not use dma-channels?
--
~Vinod
next prev parent reply other threads:[~2020-08-28 10:45 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-14 5:26 [PATCH v5 0/2] Add Intel LGM soc DMA support Amireddy Mallikarjuna reddy
2020-08-14 5:26 ` [PATCH v5 1/2] dt-bindings: dma: Add bindings for intel LGM SOC Amireddy Mallikarjuna reddy
2020-08-14 20:32 ` Rob Herring
2020-08-18 7:00 ` Reddy, MallikarjunaX
2020-08-25 11:21 ` Vinod Koul
2020-08-27 9:54 ` Reddy, MallikarjunaX
2020-08-28 10:45 ` Vinod Koul [this message]
2020-08-31 8:06 ` Reddy, MallikarjunaX
2020-08-31 11:00 ` Vinod Koul
2020-09-01 15:03 ` Reddy, MallikarjunaX
2020-09-04 6:31 ` Peter Ujfalusi
2020-09-07 7:25 ` Reddy, MallikarjunaX
2020-08-14 5:26 ` [PATCH v5 2/2] Add Intel LGM soc DMA support Amireddy Mallikarjuna reddy
2020-08-14 8:47 ` kernel test robot
2020-08-18 10:16 ` Peter Ujfalusi
2020-08-18 10:29 ` Peter Ujfalusi
2020-08-24 2:30 ` Reddy, MallikarjunaX
2020-08-24 11:24 ` Peter Ujfalusi
2020-08-27 14:41 ` Reddy, MallikarjunaX
2020-08-28 11:17 ` Peter Ujfalusi
2020-08-31 8:07 ` Reddy, MallikarjunaX
2020-09-04 6:31 ` Peter Ujfalusi
2020-09-07 7:32 ` Reddy, MallikarjunaX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200828104530.GT2639@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=cheol.yong.kim@intel.com \
--cc=chuanhua.lei@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=malliamireddy009@gmail.com \
--cc=mallikarjunax.reddy@linux.intel.com \
--cc=qi-ming.wu@intel.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).