* [PATCH] arm64: dts: imx8mq-librem5-devkit: Add missing clock-cells to PMIC
@ 2020-08-28 19:22 Krzysztof Kozlowski
2020-08-29 11:24 ` Martin Kepplinger
2020-08-31 5:57 ` Shawn Guo
0 siblings, 2 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2020-08-28 19:22 UTC (permalink / raw)
To: Rob Herring, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, NXP Linux Team, Martin Kepplinger,
Angus Ainslie (Purism),
Krzysztof Kozlowski, Anson Huang, devicetree, linux-arm-kernel,
linux-kernel
The PMIC node can be a clock provider (for its 32 kHz clock) and authors
of imx8mq-librem5-devkit.dts apparently wanted this because they added
input clock and clock-output-names.
Add necessary clock-cells to the PMIC node.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
index 377591a0e6e9..40b43625f20f 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
@@ -285,6 +285,7 @@
pinctrl-0 = <&pinctrl_pmic>;
clocks = <&pmic_osc>;
clock-names = "osc";
+ #clock-cells = <0>;
clock-output-names = "pmic_clk";
interrupt-parent = <&gpio1>;
interrupts = <3 GPIO_ACTIVE_LOW>;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: imx8mq-librem5-devkit: Add missing clock-cells to PMIC
2020-08-28 19:22 [PATCH] arm64: dts: imx8mq-librem5-devkit: Add missing clock-cells to PMIC Krzysztof Kozlowski
@ 2020-08-29 11:24 ` Martin Kepplinger
2020-08-31 5:57 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Martin Kepplinger @ 2020-08-29 11:24 UTC (permalink / raw)
To: Krzysztof Kozlowski, Rob Herring, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
Angus Ainslie (Purism),
Anson Huang, devicetree, linux-arm-kernel, linux-kernel
On 28.08.20 21:22, Krzysztof Kozlowski wrote:
> The PMIC node can be a clock provider (for its 32 kHz clock) and authors
> of imx8mq-librem5-devkit.dts apparently wanted this because they added
> input clock and clock-output-names.
>
> Add necessary clock-cells to the PMIC node.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> index 377591a0e6e9..40b43625f20f 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> @@ -285,6 +285,7 @@
> pinctrl-0 = <&pinctrl_pmic>;
> clocks = <&pmic_osc>;
> clock-names = "osc";
> + #clock-cells = <0>;
> clock-output-names = "pmic_clk";
> interrupt-parent = <&gpio1>;
> interrupts = <3 GPIO_ACTIVE_LOW>;
>
Hi Krzysztof,
Reviewed-and-tested-by: Martin Kepplinger <martink@posteo.de>
thanks for reviewing,
martin
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: imx8mq-librem5-devkit: Add missing clock-cells to PMIC
2020-08-28 19:22 [PATCH] arm64: dts: imx8mq-librem5-devkit: Add missing clock-cells to PMIC Krzysztof Kozlowski
2020-08-29 11:24 ` Martin Kepplinger
@ 2020-08-31 5:57 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2020-08-31 5:57 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, NXP Linux Team, Martin Kepplinger,
Angus Ainslie (Purism),
Anson Huang, devicetree, linux-arm-kernel, linux-kernel
On Fri, Aug 28, 2020 at 09:22:28PM +0200, Krzysztof Kozlowski wrote:
> The PMIC node can be a clock provider (for its 32 kHz clock) and authors
> of imx8mq-librem5-devkit.dts apparently wanted this because they added
> input clock and clock-output-names.
>
> Add necessary clock-cells to the PMIC node.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-31 5:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-28 19:22 [PATCH] arm64: dts: imx8mq-librem5-devkit: Add missing clock-cells to PMIC Krzysztof Kozlowski
2020-08-29 11:24 ` Martin Kepplinger
2020-08-31 5:57 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).