* [PATCH] pktgen: fix error message with wrong function name
@ 2020-09-01 13:04 Leesoo Ahn
2020-09-01 17:25 ` Gustavo A. R. Silva
2020-09-01 18:45 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Leesoo Ahn @ 2020-09-01 13:04 UTC (permalink / raw)
To: dev
Cc: David S. Miller, Jakub Kicinski, Andrew Morton,
Mauro Carvalho Chehab, Gustavo A. R. Silva, Pablo Neira Ayuso,
Lukas Wunner, Alexey Dobriyan, Niu Xilei, netdev, linux-kernel
Error on calling kthread_create_on_node prints wrong function name,
kernel_thread.
Signed-off-by: Leesoo Ahn <dev@ooseel.net>
---
net/core/pktgen.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/pktgen.c b/net/core/pktgen.c
index 95f4c6b8f51a..44fdbb9c6e53 100644
--- a/net/core/pktgen.c
+++ b/net/core/pktgen.c
@@ -3699,7 +3699,7 @@ static int __net_init pktgen_create_thread(int cpu, struct pktgen_net *pn)
cpu_to_node(cpu),
"kpktgend_%d", cpu);
if (IS_ERR(p)) {
- pr_err("kernel_thread() failed for cpu %d\n", t->cpu);
+ pr_err("kthread_create_on_node() failed for cpu %d\n", t->cpu);
list_del(&t->th_list);
kfree(t);
return PTR_ERR(p);
--
2.25.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] pktgen: fix error message with wrong function name
2020-09-01 13:04 [PATCH] pktgen: fix error message with wrong function name Leesoo Ahn
@ 2020-09-01 17:25 ` Gustavo A. R. Silva
2020-09-01 18:45 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2020-09-01 17:25 UTC (permalink / raw)
To: Leesoo Ahn
Cc: David S. Miller, Jakub Kicinski, Andrew Morton,
Mauro Carvalho Chehab, Pablo Neira Ayuso, Lukas Wunner,
Alexey Dobriyan, Niu Xilei, netdev, linux-kernel
On Tue, Sep 01, 2020 at 10:04:47PM +0900, Leesoo Ahn wrote:
> Error on calling kthread_create_on_node prints wrong function name,
> kernel_thread.
>
> Signed-off-by: Leesoo Ahn <dev@ooseel.net>
You might need to add the following tag:
Fixes: 94dcf29a11b3 ("kthread: use kthread_create_on_node()")
Acked-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Thanks
--
Gustavo
> ---
> net/core/pktgen.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/core/pktgen.c b/net/core/pktgen.c
> index 95f4c6b8f51a..44fdbb9c6e53 100644
> --- a/net/core/pktgen.c
> +++ b/net/core/pktgen.c
> @@ -3699,7 +3699,7 @@ static int __net_init pktgen_create_thread(int cpu, struct pktgen_net *pn)
> cpu_to_node(cpu),
> "kpktgend_%d", cpu);
> if (IS_ERR(p)) {
> - pr_err("kernel_thread() failed for cpu %d\n", t->cpu);
> + pr_err("kthread_create_on_node() failed for cpu %d\n", t->cpu);
> list_del(&t->th_list);
> kfree(t);
> return PTR_ERR(p);
> --
> 2.25.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pktgen: fix error message with wrong function name
2020-09-01 13:04 [PATCH] pktgen: fix error message with wrong function name Leesoo Ahn
2020-09-01 17:25 ` Gustavo A. R. Silva
@ 2020-09-01 18:45 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2020-09-01 18:45 UTC (permalink / raw)
To: dev
Cc: kuba, akpm, mchehab+huawei, gustavoars, pablo, lukas, adobriyan,
niu_xilei, netdev, linux-kernel
From: Leesoo Ahn <dev@ooseel.net>
Date: Tue, 1 Sep 2020 22:04:47 +0900
> Error on calling kthread_create_on_node prints wrong function name,
> kernel_thread.
>
> Signed-off-by: Leesoo Ahn <dev@ooseel.net>
Applied with Fixes: tag added.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-01 18:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-01 13:04 [PATCH] pktgen: fix error message with wrong function name Leesoo Ahn
2020-09-01 17:25 ` Gustavo A. R. Silva
2020-09-01 18:45 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).