linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v5 0/3] mfd: lp87565: convert DT to yaml and add LP87524-Q1
@ 2020-09-02 14:22 Luca Ceresoli
  2020-09-02 14:22 ` [PATCH v5 1/3] dt-bindings: mfd: lp87565: convert to yaml Luca Ceresoli
                   ` (2 more replies)
  0 siblings, 3 replies; 9+ messages in thread
From: Luca Ceresoli @ 2020-09-02 14:22 UTC (permalink / raw)
  To: Lee Jones
  Cc: Luca Ceresoli, Keerthy, Axel Lin, Rob Herring, devicetree, linux-kernel

Hi,

the following patches are a fairly straightforward addition of a new chip
variant along with DT bindings conversion to yaml.

v5 adds the description of the "regulators" DT node and has smaller
improvements to the bindings. No changes to the driver since v2.

RFC,v1: https://lkml.org/lkml/2020/6/3/908
v2: https://lkml.org/lkml/2020/6/17/492
v3: https://lkml.org/lkml/2020/6/22/1139
v4: https://lkml.org/lkml/2020/8/17/830

Luca

Luca Ceresoli (3):
  dt-bindings: mfd: lp87565: convert to yaml
  dt-bindings: mfd: add LP87524-Q1
  mfd: lp87565: add LP87524-Q1 variant

 .../devicetree/bindings/mfd/lp87565.txt       |  79 ------------
 .../bindings/mfd/ti,lp87524-q1.yaml           | 112 ++++++++++++++++++
 .../bindings/mfd/ti,lp87561-q1.yaml           |  83 +++++++++++++
 .../bindings/mfd/ti,lp87565-q1.yaml           | 101 ++++++++++++++++
 drivers/mfd/lp87565.c                         |   4 +
 include/linux/mfd/lp87565.h                   |   1 +
 6 files changed, 301 insertions(+), 79 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/mfd/lp87565.txt
 create mode 100644 Documentation/devicetree/bindings/mfd/ti,lp87524-q1.yaml
 create mode 100644 Documentation/devicetree/bindings/mfd/ti,lp87561-q1.yaml
 create mode 100644 Documentation/devicetree/bindings/mfd/ti,lp87565-q1.yaml

-- 
2.28.0


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH v5 1/3] dt-bindings: mfd: lp87565: convert to yaml
  2020-09-02 14:22 [PATCH v5 0/3] mfd: lp87565: convert DT to yaml and add LP87524-Q1 Luca Ceresoli
@ 2020-09-02 14:22 ` Luca Ceresoli
  2020-09-14 20:22   ` Rob Herring
  2020-09-28 12:11   ` Lee Jones
  2020-09-02 14:22 ` [PATCH v5 2/3] dt-bindings: mfd: add LP87524-Q1 Luca Ceresoli
  2020-09-02 14:22 ` [PATCH v5 3/3] mfd: lp87565: add LP87524-Q1 variant Luca Ceresoli
  2 siblings, 2 replies; 9+ messages in thread
From: Luca Ceresoli @ 2020-09-02 14:22 UTC (permalink / raw)
  To: Lee Jones
  Cc: Luca Ceresoli, Keerthy, Axel Lin, Rob Herring, devicetree, linux-kernel

Also apply a few smaller improvements:

 - document that the only possible I2C slave address is 0x60 as per the
   datasheet and fix the second example accordingly
 - The definition of "xxx-in-supply" was generic, thus define in detail the
   possible cases for each chip variant
 - remove "MFD driver" from the title as it is implementation specific
 - replace "PMIC" with "buck converter" in title as it is more informative

Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>

---

Changes in v5:
 - describe the "regulators" node too (Rob)
 - add 'additionalProperties: false' (Rob)
 - simplify supply description
 - update commit message

Changes in v4:
 - split in two different bindings (Rob)
 - remove "MFD driver" from title as it is implementation specific; also
   replace "PMIC" with "buck converter" which is more informative

Changes in v3:
 - fix yaml errors

Changes in v2:
 - this patch replaces patch "regulator: lp87565: dt: remove duplicated
   section" in RFC,v1 (Rob Herring)
 - use capital letters consistently (Lee Jones)
 - replace "regulator" -> "mfd" in subject line (Lee Jones)
 - replace "dt:" suffix with "dt-bindings:" prefix in subject line
---
 .../devicetree/bindings/mfd/lp87565.txt       |  79 --------------
 .../bindings/mfd/ti,lp87561-q1.yaml           |  83 ++++++++++++++
 .../bindings/mfd/ti,lp87565-q1.yaml           | 101 ++++++++++++++++++
 3 files changed, 184 insertions(+), 79 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/mfd/lp87565.txt
 create mode 100644 Documentation/devicetree/bindings/mfd/ti,lp87561-q1.yaml
 create mode 100644 Documentation/devicetree/bindings/mfd/ti,lp87565-q1.yaml

diff --git a/Documentation/devicetree/bindings/mfd/lp87565.txt b/Documentation/devicetree/bindings/mfd/lp87565.txt
deleted file mode 100644
index 41671e0dc26b..000000000000
--- a/Documentation/devicetree/bindings/mfd/lp87565.txt
+++ /dev/null
@@ -1,79 +0,0 @@
-TI LP87565 PMIC MFD driver
-
-Required properties:
-  - compatible:	"ti,lp87565", "ti,lp87565-q1"
-  - reg:		I2C slave address.
-  - gpio-controller:	Marks the device node as a GPIO Controller.
-  - #gpio-cells:	Should be two.  The first cell is the pin number and
-			the second cell is used to specify flags.
-			See ../gpio/gpio.txt for more information.
-  - xxx-in-supply:	Phandle to parent supply node of each regulator
-			populated under regulators node. xxx should match
-			the supply_name populated in driver.
-Example:
-
-lp87565_pmic: pmic@60 {
-	compatible = "ti,lp87565-q1";
-	reg = <0x60>;
-	gpio-controller;
-	#gpio-cells = <2>;
-
-	buck10-in-supply = <&vsys_3v3>;
-	buck23-in-supply = <&vsys_3v3>;
-
-	regulators: regulators {
-		buck10_reg: buck10 {
-			/* VDD_MPU */
-			regulator-name = "buck10";
-			regulator-min-microvolt = <850000>;
-			regulator-max-microvolt = <1250000>;
-			regulator-always-on;
-			regulator-boot-on;
-		};
-
-		buck23_reg: buck23 {
-			/* VDD_GPU */
-			regulator-name = "buck23";
-			regulator-min-microvolt = <850000>;
-			regulator-max-microvolt = <1250000>;
-			regulator-boot-on;
-			regulator-always-on;
-		};
-	};
-};
-
-TI LP87561 PMIC:
-
-This is a single output 4-phase regulator configuration
-
-Required properties:
-  - compatible:	"ti,lp87561-q1"
-  - reg:		I2C slave address.
-  - gpio-controller:	Marks the device node as a GPIO Controller.
-  - #gpio-cells:	Should be two.  The first cell is the pin number and
-			the second cell is used to specify flags.
-			See ../gpio/gpio.txt for more information.
-  - xxx-in-supply:	Phandle to parent supply node of each regulator
-			populated under regulators node. xxx should match
-			the supply_name populated in driver.
-Example:
-
-lp87561_pmic: pmic@62 {
-	compatible = "ti,lp87561-q1";
-	reg = <0x62>;
-	gpio-controller;
-	#gpio-cells = <2>;
-
-	buck3210-in-supply = <&vsys_3v3>;
-
-	regulators: regulators {
-		buck3210_reg: buck3210 {
-			/* VDD_CORE */
-			regulator-name = "buck3210";
-			regulator-min-microvolt = <800000>;
-			regulator-max-microvolt = <800000>;
-			regulator-always-on;
-			regulator-boot-on;
-		};
-	};
-};
diff --git a/Documentation/devicetree/bindings/mfd/ti,lp87561-q1.yaml b/Documentation/devicetree/bindings/mfd/ti,lp87561-q1.yaml
new file mode 100644
index 000000000000..a7e57c0913e1
--- /dev/null
+++ b/Documentation/devicetree/bindings/mfd/ti,lp87561-q1.yaml
@@ -0,0 +1,83 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mfd/ti,lp87561-q1.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: TI LP87561-Q1 single 4-phase output buck converter
+
+maintainers:
+  - Keerthy <j-keerthy@ti.com>
+
+properties:
+  compatible:
+    const: ti,lp87561-q1
+
+  reg:
+    description: I2C slave address
+    const: 0x60
+
+  gpio-controller: true
+
+  '#gpio-cells':
+    description:
+      The first cell is the pin number.
+      The second cell is is used to specify flags.
+      See ../gpio/gpio.txt for more information.
+    const: 2
+
+  buck3210-in-supply:
+    description:
+      Voltage regulator supply for all the four BUCK converters.
+
+  regulators:
+    type: object
+
+    properties:
+      buck3210:
+        type: object
+        $ref: /schemas/regulator/regulator.yaml#
+
+    required:
+      - buck3210
+
+    additionalProperties: false
+
+required:
+  - compatible
+  - reg
+  - gpio-controller
+  - '#gpio-cells'
+  - buck3210-in-supply
+
+additionalProperties: false
+
+examples:
+  - |
+    i2c@0 {
+        reg = <0x0 0x100>;
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        pmic@60 {
+            compatible = "ti,lp87561-q1";
+            reg = <0x60>;
+            gpio-controller;
+            #gpio-cells = <2>;
+
+            buck3210-in-supply = <&vsys_3v3>;
+
+            regulators {
+                buck3210_reg: buck3210 {
+                    /* VDD_CORE */
+                    regulator-name = "buck3210";
+                    regulator-min-microvolt = <800000>;
+                    regulator-max-microvolt = <800000>;
+                    regulator-always-on;
+                    regulator-boot-on;
+                };
+            };
+        };
+    };
+
+...
diff --git a/Documentation/devicetree/bindings/mfd/ti,lp87565-q1.yaml b/Documentation/devicetree/bindings/mfd/ti,lp87565-q1.yaml
new file mode 100644
index 000000000000..1da6d6a958c9
--- /dev/null
+++ b/Documentation/devicetree/bindings/mfd/ti,lp87565-q1.yaml
@@ -0,0 +1,101 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mfd/ti,lp87565-q1.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: TI LP87565-Q1 / LP87565 dual 2-phase output buck converter
+
+maintainers:
+  - Keerthy <j-keerthy@ti.com>
+
+properties:
+  compatible:
+    oneOf:
+      - const: ti,lp87565
+      - const: ti,lp87565-q1
+
+  reg:
+    description: I2C slave address
+    const: 0x60
+
+  gpio-controller: true
+
+  '#gpio-cells':
+    description:
+      The first cell is the pin number.
+      The second cell is is used to specify flags.
+      See ../gpio/gpio.txt for more information.
+    const: 2
+
+  buck10-in-supply:
+    description:
+      Voltage regulator supply for BUCK0 and BUCK1 converters.
+
+  buck23-in-supply:
+    description:
+      Voltage regulator supply for BUCK2 and BUCK3 converters.
+
+  regulators:
+    type: object
+
+    patternProperties:
+      "^buck(10|23)$":
+        type: object
+        $ref: /schemas/regulator/regulator.yaml#
+
+    required:
+      - buck10
+      - buck23
+
+    additionalProperties: false
+
+required:
+  - compatible
+  - reg
+  - gpio-controller
+  - '#gpio-cells'
+  - buck10-in-supply
+  - buck23-in-supply
+
+additionalProperties: false
+
+examples:
+  - |
+    i2c@0 {
+        reg = <0x0 0x100>;
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        pmic@60 {
+            compatible = "ti,lp87565-q1";
+            reg = <0x60>;
+            gpio-controller;
+            #gpio-cells = <2>;
+
+            buck10-in-supply = <&vsys_3v3>;
+            buck23-in-supply = <&vsys_3v3>;
+
+            regulators {
+                buck10_reg: buck10 {
+                    /* VDD_MPU */
+                    regulator-name = "buck10";
+                    regulator-min-microvolt = <850000>;
+                    regulator-max-microvolt = <1250000>;
+                    regulator-always-on;
+                    regulator-boot-on;
+                };
+
+                buck23_reg: buck23 {
+                    /* VDD_GPU */
+                    regulator-name = "buck23";
+                    regulator-min-microvolt = <850000>;
+                    regulator-max-microvolt = <1250000>;
+                    regulator-boot-on;
+                    regulator-always-on;
+                };
+            };
+        };
+    };
+
+...
-- 
2.28.0


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH v5 2/3] dt-bindings: mfd: add LP87524-Q1
  2020-09-02 14:22 [PATCH v5 0/3] mfd: lp87565: convert DT to yaml and add LP87524-Q1 Luca Ceresoli
  2020-09-02 14:22 ` [PATCH v5 1/3] dt-bindings: mfd: lp87565: convert to yaml Luca Ceresoli
@ 2020-09-02 14:22 ` Luca Ceresoli
  2020-09-14 20:22   ` Rob Herring
  2020-09-28 12:11   ` Lee Jones
  2020-09-02 14:22 ` [PATCH v5 3/3] mfd: lp87565: add LP87524-Q1 variant Luca Ceresoli
  2 siblings, 2 replies; 9+ messages in thread
From: Luca Ceresoli @ 2020-09-02 14:22 UTC (permalink / raw)
  To: Lee Jones
  Cc: Luca Ceresoli, Keerthy, Axel Lin, Rob Herring, devicetree, linux-kernel

Add the LP87524-Q1 to the bindings along with an example. This is a variant
of the LP87565-Q1 and LP87561-Q1 chips which already have bindings.

Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>

---

Changes in v5:
 - describe the "regulators" node too (Rob)
 - add 'additionalProperties: false' (Rob)
 - user patternProperties for supplies
 - simplify supply description

Changes in v4:
 - reformat as a standalone file

Changes in v3:
 - fix yaml errors

Changes in v2:
 - RFC,v1 was based on the txt file, rewrite for yaml
 - use uppercase consistently in model names (Lee Jones)
 - replace "regulator" -> "mfd" in subject line (Lee Jones)
 - replace "dt:" suffix with "dt-bindings:" prefix in subject line
---
 .../bindings/mfd/ti,lp87524-q1.yaml           | 112 ++++++++++++++++++
 1 file changed, 112 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mfd/ti,lp87524-q1.yaml

diff --git a/Documentation/devicetree/bindings/mfd/ti,lp87524-q1.yaml b/Documentation/devicetree/bindings/mfd/ti,lp87524-q1.yaml
new file mode 100644
index 000000000000..c4fc5345d38d
--- /dev/null
+++ b/Documentation/devicetree/bindings/mfd/ti,lp87524-q1.yaml
@@ -0,0 +1,112 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mfd/ti,lp87524-q1.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: TI LP87524-Q1 four 1-phase output buck converter
+
+maintainers:
+  - Keerthy <j-keerthy@ti.com>
+
+properties:
+  compatible:
+    const: ti,lp87524-q1
+
+  reg:
+    description: I2C slave address
+    const: 0x60
+
+  gpio-controller: true
+
+  '#gpio-cells':
+    description:
+      The first cell is the pin number.
+      The second cell is is used to specify flags.
+      See ../gpio/gpio.txt for more information.
+    const: 2
+
+  regulators:
+    type: object
+
+    patternProperties:
+      "^buck[0123]$":
+        type: object
+        $ref: /schemas/regulator/regulator.yaml#
+
+    required:
+      - buck0
+      - buck1
+      - buck2
+      - buck3
+
+    additionalProperties: false
+
+patternProperties:
+  "^buck[0123]-in-supply$":
+    description: Voltage regulator supply for each BUCK converter
+
+required:
+  - compatible
+  - reg
+  - gpio-controller
+  - '#gpio-cells'
+  - buck0-in-supply
+  - buck1-in-supply
+  - buck2-in-supply
+  - buck3-in-supply
+  - regulators
+
+additionalProperties: false
+
+examples:
+  - |
+    i2c@0 {
+        reg = <0x0 0x100>;
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        pmic@60 {
+            compatible = "ti,lp87524-q1";
+            reg = <0x60>;
+            gpio-controller;
+            #gpio-cells = <2>;
+
+            buck0-in-supply = <&vdd_5v0>;
+            buck1-in-supply = <&vdd_5v0>;
+            buck2-in-supply = <&vdd_5v0>;
+            buck3-in-supply = <&vdd_5v0>;
+
+            regulators {
+                buck0_reg: buck0 {
+                    regulator-name = "buck0";
+                    regulator-min-microvolt = <3300000>;
+                    regulator-max-microvolt = <3300000>;
+                    regulator-always-on;
+                };
+
+                buck1_reg: buck1 {
+                    regulator-name = "buck1";
+                    regulator-min-microvolt = <1350000>;
+                    regulator-max-microvolt = <1350000>;
+                    regulator-always-on;
+                };
+
+                buck2_reg: buck2 {
+                    regulator-name = "buck2";
+                    regulator-min-microvolt = <950000>;
+                    regulator-max-microvolt = <950000>;
+                    regulator-always-on;
+                };
+
+                buck3_reg: buck3 {
+                    regulator-name = "buck3";
+                    regulator-min-microvolt = <1800000>;
+                    regulator-max-microvolt = <1800000>;
+                    regulator-always-on;
+                };
+            };
+        };
+    };
+
+...
-- 
2.28.0


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH v5 3/3] mfd: lp87565: add LP87524-Q1 variant
  2020-09-02 14:22 [PATCH v5 0/3] mfd: lp87565: convert DT to yaml and add LP87524-Q1 Luca Ceresoli
  2020-09-02 14:22 ` [PATCH v5 1/3] dt-bindings: mfd: lp87565: convert to yaml Luca Ceresoli
  2020-09-02 14:22 ` [PATCH v5 2/3] dt-bindings: mfd: add LP87524-Q1 Luca Ceresoli
@ 2020-09-02 14:22 ` Luca Ceresoli
  2020-09-28 12:12   ` Lee Jones
  2 siblings, 1 reply; 9+ messages in thread
From: Luca Ceresoli @ 2020-09-02 14:22 UTC (permalink / raw)
  To: Lee Jones
  Cc: Luca Ceresoli, Keerthy, Axel Lin, Rob Herring, devicetree, linux-kernel

Add support for the LP87524B/J/P-Q1 Four 4-MHz Buck Converter. This is a
variant of the LP87565 having 4 single-phase outputs and up to 10 A of
total output current.

Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>

---

Changes in v5: none

Changes in v4: none

Changes in v3: none

Changes in v2:
 - replace "regulator" -> "mfd" in subject line (Lee Jones)
 - add Acked-for-MFD-by: from Lee Jones
---
 drivers/mfd/lp87565.c       | 4 ++++
 include/linux/mfd/lp87565.h | 1 +
 2 files changed, 5 insertions(+)

diff --git a/drivers/mfd/lp87565.c b/drivers/mfd/lp87565.c
index 2268be9113f1..9c21483d9653 100644
--- a/drivers/mfd/lp87565.c
+++ b/drivers/mfd/lp87565.c
@@ -26,6 +26,10 @@ static const struct mfd_cell lp87565_cells[] = {
 
 static const struct of_device_id of_lp87565_match_table[] = {
 	{ .compatible = "ti,lp87565", },
+	{
+		.compatible = "ti,lp87524-q1",
+		.data = (void *)LP87565_DEVICE_TYPE_LP87524_Q1,
+	},
 	{
 		.compatible = "ti,lp87565-q1",
 		.data = (void *)LP87565_DEVICE_TYPE_LP87565_Q1,
diff --git a/include/linux/mfd/lp87565.h b/include/linux/mfd/lp87565.h
index 43716aca46fa..d44ddfb6bb63 100644
--- a/include/linux/mfd/lp87565.h
+++ b/include/linux/mfd/lp87565.h
@@ -14,6 +14,7 @@
 
 enum lp87565_device_type {
 	LP87565_DEVICE_TYPE_UNKNOWN	= 0,
+	LP87565_DEVICE_TYPE_LP87524_Q1,
 	LP87565_DEVICE_TYPE_LP87561_Q1,
 	LP87565_DEVICE_TYPE_LP87565_Q1,
 };
-- 
2.28.0


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH v5 1/3] dt-bindings: mfd: lp87565: convert to yaml
  2020-09-02 14:22 ` [PATCH v5 1/3] dt-bindings: mfd: lp87565: convert to yaml Luca Ceresoli
@ 2020-09-14 20:22   ` Rob Herring
  2020-09-28 12:11   ` Lee Jones
  1 sibling, 0 replies; 9+ messages in thread
From: Rob Herring @ 2020-09-14 20:22 UTC (permalink / raw)
  To: Luca Ceresoli
  Cc: Axel Lin, Rob Herring, Lee Jones, Keerthy, linux-kernel, devicetree

On Wed, 02 Sep 2020 16:22:57 +0200, Luca Ceresoli wrote:
> Also apply a few smaller improvements:
> 
>  - document that the only possible I2C slave address is 0x60 as per the
>    datasheet and fix the second example accordingly
>  - The definition of "xxx-in-supply" was generic, thus define in detail the
>    possible cases for each chip variant
>  - remove "MFD driver" from the title as it is implementation specific
>  - replace "PMIC" with "buck converter" in title as it is more informative
> 
> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
> 
> ---
> 
> Changes in v5:
>  - describe the "regulators" node too (Rob)
>  - add 'additionalProperties: false' (Rob)
>  - simplify supply description
>  - update commit message
> 
> Changes in v4:
>  - split in two different bindings (Rob)
>  - remove "MFD driver" from title as it is implementation specific; also
>    replace "PMIC" with "buck converter" which is more informative
> 
> Changes in v3:
>  - fix yaml errors
> 
> Changes in v2:
>  - this patch replaces patch "regulator: lp87565: dt: remove duplicated
>    section" in RFC,v1 (Rob Herring)
>  - use capital letters consistently (Lee Jones)
>  - replace "regulator" -> "mfd" in subject line (Lee Jones)
>  - replace "dt:" suffix with "dt-bindings:" prefix in subject line
> ---
>  .../devicetree/bindings/mfd/lp87565.txt       |  79 --------------
>  .../bindings/mfd/ti,lp87561-q1.yaml           |  83 ++++++++++++++
>  .../bindings/mfd/ti,lp87565-q1.yaml           | 101 ++++++++++++++++++
>  3 files changed, 184 insertions(+), 79 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/mfd/lp87565.txt
>  create mode 100644 Documentation/devicetree/bindings/mfd/ti,lp87561-q1.yaml
>  create mode 100644 Documentation/devicetree/bindings/mfd/ti,lp87565-q1.yaml
> 

Reviewed-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v5 2/3] dt-bindings: mfd: add LP87524-Q1
  2020-09-02 14:22 ` [PATCH v5 2/3] dt-bindings: mfd: add LP87524-Q1 Luca Ceresoli
@ 2020-09-14 20:22   ` Rob Herring
  2020-09-28 12:11   ` Lee Jones
  1 sibling, 0 replies; 9+ messages in thread
From: Rob Herring @ 2020-09-14 20:22 UTC (permalink / raw)
  To: Luca Ceresoli
  Cc: Lee Jones, Axel Lin, Keerthy, Rob Herring, devicetree, linux-kernel

On Wed, 02 Sep 2020 16:22:58 +0200, Luca Ceresoli wrote:
> Add the LP87524-Q1 to the bindings along with an example. This is a variant
> of the LP87565-Q1 and LP87561-Q1 chips which already have bindings.
> 
> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
> 
> ---
> 
> Changes in v5:
>  - describe the "regulators" node too (Rob)
>  - add 'additionalProperties: false' (Rob)
>  - user patternProperties for supplies
>  - simplify supply description
> 
> Changes in v4:
>  - reformat as a standalone file
> 
> Changes in v3:
>  - fix yaml errors
> 
> Changes in v2:
>  - RFC,v1 was based on the txt file, rewrite for yaml
>  - use uppercase consistently in model names (Lee Jones)
>  - replace "regulator" -> "mfd" in subject line (Lee Jones)
>  - replace "dt:" suffix with "dt-bindings:" prefix in subject line
> ---
>  .../bindings/mfd/ti,lp87524-q1.yaml           | 112 ++++++++++++++++++
>  1 file changed, 112 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mfd/ti,lp87524-q1.yaml
> 

Reviewed-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v5 1/3] dt-bindings: mfd: lp87565: convert to yaml
  2020-09-02 14:22 ` [PATCH v5 1/3] dt-bindings: mfd: lp87565: convert to yaml Luca Ceresoli
  2020-09-14 20:22   ` Rob Herring
@ 2020-09-28 12:11   ` Lee Jones
  1 sibling, 0 replies; 9+ messages in thread
From: Lee Jones @ 2020-09-28 12:11 UTC (permalink / raw)
  To: Luca Ceresoli; +Cc: Keerthy, Axel Lin, Rob Herring, devicetree, linux-kernel

On Wed, 02 Sep 2020, Luca Ceresoli wrote:

> Also apply a few smaller improvements:
> 
>  - document that the only possible I2C slave address is 0x60 as per the
>    datasheet and fix the second example accordingly
>  - The definition of "xxx-in-supply" was generic, thus define in detail the
>    possible cases for each chip variant
>  - remove "MFD driver" from the title as it is implementation specific
>  - replace "PMIC" with "buck converter" in title as it is more informative
> 
> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
> 
> ---
> 
> Changes in v5:
>  - describe the "regulators" node too (Rob)
>  - add 'additionalProperties: false' (Rob)
>  - simplify supply description
>  - update commit message
> 
> Changes in v4:
>  - split in two different bindings (Rob)
>  - remove "MFD driver" from title as it is implementation specific; also
>    replace "PMIC" with "buck converter" which is more informative
> 
> Changes in v3:
>  - fix yaml errors
> 
> Changes in v2:
>  - this patch replaces patch "regulator: lp87565: dt: remove duplicated
>    section" in RFC,v1 (Rob Herring)
>  - use capital letters consistently (Lee Jones)
>  - replace "regulator" -> "mfd" in subject line (Lee Jones)
>  - replace "dt:" suffix with "dt-bindings:" prefix in subject line
> ---
>  .../devicetree/bindings/mfd/lp87565.txt       |  79 --------------
>  .../bindings/mfd/ti,lp87561-q1.yaml           |  83 ++++++++++++++
>  .../bindings/mfd/ti,lp87565-q1.yaml           | 101 ++++++++++++++++++
>  3 files changed, 184 insertions(+), 79 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/mfd/lp87565.txt
>  create mode 100644 Documentation/devicetree/bindings/mfd/ti,lp87561-q1.yaml
>  create mode 100644 Documentation/devicetree/bindings/mfd/ti,lp87565-q1.yaml

Applied, thanks.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v5 2/3] dt-bindings: mfd: add LP87524-Q1
  2020-09-02 14:22 ` [PATCH v5 2/3] dt-bindings: mfd: add LP87524-Q1 Luca Ceresoli
  2020-09-14 20:22   ` Rob Herring
@ 2020-09-28 12:11   ` Lee Jones
  1 sibling, 0 replies; 9+ messages in thread
From: Lee Jones @ 2020-09-28 12:11 UTC (permalink / raw)
  To: Luca Ceresoli; +Cc: Keerthy, Axel Lin, Rob Herring, devicetree, linux-kernel

On Wed, 02 Sep 2020, Luca Ceresoli wrote:

> Add the LP87524-Q1 to the bindings along with an example. This is a variant
> of the LP87565-Q1 and LP87561-Q1 chips which already have bindings.
> 
> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
> 
> ---
> 
> Changes in v5:
>  - describe the "regulators" node too (Rob)
>  - add 'additionalProperties: false' (Rob)
>  - user patternProperties for supplies
>  - simplify supply description
> 
> Changes in v4:
>  - reformat as a standalone file
> 
> Changes in v3:
>  - fix yaml errors
> 
> Changes in v2:
>  - RFC,v1 was based on the txt file, rewrite for yaml
>  - use uppercase consistently in model names (Lee Jones)
>  - replace "regulator" -> "mfd" in subject line (Lee Jones)
>  - replace "dt:" suffix with "dt-bindings:" prefix in subject line
> ---
>  .../bindings/mfd/ti,lp87524-q1.yaml           | 112 ++++++++++++++++++
>  1 file changed, 112 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mfd/ti,lp87524-q1.yaml

Applied, thanks.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v5 3/3] mfd: lp87565: add LP87524-Q1 variant
  2020-09-02 14:22 ` [PATCH v5 3/3] mfd: lp87565: add LP87524-Q1 variant Luca Ceresoli
@ 2020-09-28 12:12   ` Lee Jones
  0 siblings, 0 replies; 9+ messages in thread
From: Lee Jones @ 2020-09-28 12:12 UTC (permalink / raw)
  To: Luca Ceresoli; +Cc: Keerthy, Axel Lin, Rob Herring, devicetree, linux-kernel

On Wed, 02 Sep 2020, Luca Ceresoli wrote:

> Add support for the LP87524B/J/P-Q1 Four 4-MHz Buck Converter. This is a
> variant of the LP87565 having 4 single-phase outputs and up to 10 A of
> total output current.
> 
> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
> Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
> 
> ---
> 
> Changes in v5: none
> 
> Changes in v4: none
> 
> Changes in v3: none
> 
> Changes in v2:
>  - replace "regulator" -> "mfd" in subject line (Lee Jones)
>  - add Acked-for-MFD-by: from Lee Jones
> ---
>  drivers/mfd/lp87565.c       | 4 ++++
>  include/linux/mfd/lp87565.h | 1 +
>  2 files changed, 5 insertions(+)

Applied, thanks.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2020-09-28 12:12 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-02 14:22 [PATCH v5 0/3] mfd: lp87565: convert DT to yaml and add LP87524-Q1 Luca Ceresoli
2020-09-02 14:22 ` [PATCH v5 1/3] dt-bindings: mfd: lp87565: convert to yaml Luca Ceresoli
2020-09-14 20:22   ` Rob Herring
2020-09-28 12:11   ` Lee Jones
2020-09-02 14:22 ` [PATCH v5 2/3] dt-bindings: mfd: add LP87524-Q1 Luca Ceresoli
2020-09-14 20:22   ` Rob Herring
2020-09-28 12:11   ` Lee Jones
2020-09-02 14:22 ` [PATCH v5 3/3] mfd: lp87565: add LP87524-Q1 variant Luca Ceresoli
2020-09-28 12:12   ` Lee Jones

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).