* [PATCH 2/6] mmc: Set PROBE_PREFER_ASYNCHRONOUS for drivers that existed in v4.9
[not found] <20200903232441.2694866-1-dianders@chromium.org>
@ 2020-09-03 23:24 ` Douglas Anderson
2020-09-03 23:24 ` [PATCH 3/6] mmc: Set PROBE_PREFER_ASYNCHRONOUS for drivers that existed in v4.14 Douglas Anderson
` (3 subsequent siblings)
4 siblings, 0 replies; 9+ messages in thread
From: Douglas Anderson @ 2020-09-03 23:24 UTC (permalink / raw)
To: Ulf Hansson
Cc: swboyd, Douglas Anderson, Adrian Hunter, Al Cooper,
Florian Fainelli, bcm-kernel-feedback-list, linux-arm-kernel,
linux-kernel, linux-mmc
This is like commit 3d3451124f3d ("mmc: sdhci-msm: Prefer asynchronous
probe") but applied to a whole pile of drivers. This batch converts
the drivers that appeared to be around in the v4.9 timeframe.
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
drivers/mmc/host/sdhci-brcmstb.c | 1 +
drivers/mmc/host/sdhci-pic32.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/mmc/host/sdhci-brcmstb.c b/drivers/mmc/host/sdhci-brcmstb.c
index 876668827580..bbf3496f4495 100644
--- a/drivers/mmc/host/sdhci-brcmstb.c
+++ b/drivers/mmc/host/sdhci-brcmstb.c
@@ -326,6 +326,7 @@ MODULE_DEVICE_TABLE(of, sdhci_brcm_of_match);
static struct platform_driver sdhci_brcmstb_driver = {
.driver = {
.name = "sdhci-brcmstb",
+ .probe_type = PROBE_PREFER_ASYNCHRONOUS,
.pm = &sdhci_pltfm_pmops,
.of_match_table = of_match_ptr(sdhci_brcm_of_match),
},
diff --git a/drivers/mmc/host/sdhci-pic32.c b/drivers/mmc/host/sdhci-pic32.c
index a11e6397d4ff..6ce1519ae177 100644
--- a/drivers/mmc/host/sdhci-pic32.c
+++ b/drivers/mmc/host/sdhci-pic32.c
@@ -241,6 +241,7 @@ MODULE_DEVICE_TABLE(of, pic32_sdhci_id_table);
static struct platform_driver pic32_sdhci_driver = {
.driver = {
.name = "pic32-sdhci",
+ .probe_type = PROBE_PREFER_ASYNCHRONOUS,
.of_match_table = of_match_ptr(pic32_sdhci_id_table),
},
.probe = pic32_sdhci_probe,
--
2.28.0.526.ge36021eeef-goog
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 3/6] mmc: Set PROBE_PREFER_ASYNCHRONOUS for drivers that existed in v4.14
[not found] <20200903232441.2694866-1-dianders@chromium.org>
2020-09-03 23:24 ` [PATCH 2/6] mmc: Set PROBE_PREFER_ASYNCHRONOUS for drivers that existed in v4.9 Douglas Anderson
@ 2020-09-03 23:24 ` Douglas Anderson
2020-09-04 6:35 ` Wolfram Sang
2020-09-03 23:24 ` [PATCH 4/6] mmc: Set PROBE_PREFER_ASYNCHRONOUS for drivers that existed in v4.19 Douglas Anderson
` (2 subsequent siblings)
4 siblings, 1 reply; 9+ messages in thread
From: Douglas Anderson @ 2020-09-03 23:24 UTC (permalink / raw)
To: Ulf Hansson
Cc: swboyd, Douglas Anderson, Adrian Hunter, Florian Fainelli,
Hu Ziji, Jaehoon Chung, Jerome Brunet, Jun Nie, Kevin Hilman,
Krzysztof Kozlowski, Martin Blumenstingl, Neil Armstrong,
Nicolas Saenz Julienne, Peter Ujfalusi, Ray Jui, Robert Richter,
Saiyam Doshi, Scott Branden, Shawn Guo, Stefan Wahren,
Wolfram Sang, bcm-kernel-feedback-list, linux-amlogic,
linux-arm-kernel, linux-kernel, linux-mmc, linux-rpi-kernel
This is like commit 3d3451124f3d ("mmc: sdhci-msm: Prefer asynchronous
probe") but applied to a whole pile of drivers. This batch converts
the drivers that appeared to be around in the v4.14 timeframe.
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
drivers/mmc/host/bcm2835.c | 1 +
drivers/mmc/host/cavium-octeon.c | 1 +
drivers/mmc/host/dw_mmc-zx.c | 1 +
drivers/mmc/host/meson-gx-mmc.c | 1 +
drivers/mmc/host/renesas_sdhi_internal_dmac.c | 1 +
drivers/mmc/host/renesas_sdhi_sys_dmac.c | 1 +
drivers/mmc/host/sdhci-cadence.c | 1 +
drivers/mmc/host/sdhci-xenon.c | 1 +
8 files changed, 8 insertions(+)
diff --git a/drivers/mmc/host/bcm2835.c b/drivers/mmc/host/bcm2835.c
index 35320bc9dc02..8c2361e66277 100644
--- a/drivers/mmc/host/bcm2835.c
+++ b/drivers/mmc/host/bcm2835.c
@@ -1474,6 +1474,7 @@ static struct platform_driver bcm2835_driver = {
.remove = bcm2835_remove,
.driver = {
.name = "sdhost-bcm2835",
+ .probe_type = PROBE_PREFER_ASYNCHRONOUS,
.of_match_table = bcm2835_match,
},
};
diff --git a/drivers/mmc/host/cavium-octeon.c b/drivers/mmc/host/cavium-octeon.c
index e299cdd1e619..2c4b2df52adb 100644
--- a/drivers/mmc/host/cavium-octeon.c
+++ b/drivers/mmc/host/cavium-octeon.c
@@ -327,6 +327,7 @@ static struct platform_driver octeon_mmc_driver = {
.remove = octeon_mmc_remove,
.driver = {
.name = KBUILD_MODNAME,
+ .probe_type = PROBE_PREFER_ASYNCHRONOUS,
.of_match_table = octeon_mmc_match,
},
};
diff --git a/drivers/mmc/host/dw_mmc-zx.c b/drivers/mmc/host/dw_mmc-zx.c
index d9e483432a61..51bcc6332f3a 100644
--- a/drivers/mmc/host/dw_mmc-zx.c
+++ b/drivers/mmc/host/dw_mmc-zx.c
@@ -222,6 +222,7 @@ static struct platform_driver dw_mci_zx_pltfm_driver = {
.remove = dw_mci_pltfm_remove,
.driver = {
.name = "dwmmc_zx",
+ .probe_type = PROBE_PREFER_ASYNCHRONOUS,
.of_match_table = dw_mci_zx_match,
.pm = &dw_mci_zx_dev_pm_ops,
},
diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
index a68b43082f61..4ec41579940a 100644
--- a/drivers/mmc/host/meson-gx-mmc.c
+++ b/drivers/mmc/host/meson-gx-mmc.c
@@ -1264,6 +1264,7 @@ static struct platform_driver meson_mmc_driver = {
.remove = meson_mmc_remove,
.driver = {
.name = DRIVER_NAME,
+ .probe_type = PROBE_PREFER_ASYNCHRONOUS,
.of_match_table = of_match_ptr(meson_mmc_of_match),
},
};
diff --git a/drivers/mmc/host/renesas_sdhi_internal_dmac.c b/drivers/mmc/host/renesas_sdhi_internal_dmac.c
index 32ab991544ef..90b395a187fa 100644
--- a/drivers/mmc/host/renesas_sdhi_internal_dmac.c
+++ b/drivers/mmc/host/renesas_sdhi_internal_dmac.c
@@ -357,6 +357,7 @@ static const struct dev_pm_ops renesas_sdhi_internal_dmac_dev_pm_ops = {
static struct platform_driver renesas_internal_dmac_sdhi_driver = {
.driver = {
.name = "renesas_sdhi_internal_dmac",
+ .probe_type = PROBE_PREFER_ASYNCHRONOUS,
.pm = &renesas_sdhi_internal_dmac_dev_pm_ops,
.of_match_table = renesas_sdhi_internal_dmac_of_match,
},
diff --git a/drivers/mmc/host/renesas_sdhi_sys_dmac.c b/drivers/mmc/host/renesas_sdhi_sys_dmac.c
index 13ff023fbee9..c5f789675302 100644
--- a/drivers/mmc/host/renesas_sdhi_sys_dmac.c
+++ b/drivers/mmc/host/renesas_sdhi_sys_dmac.c
@@ -463,6 +463,7 @@ static const struct dev_pm_ops renesas_sdhi_sys_dmac_dev_pm_ops = {
static struct platform_driver renesas_sys_dmac_sdhi_driver = {
.driver = {
.name = "sh_mobile_sdhi",
+ .probe_type = PROBE_PREFER_ASYNCHRONOUS,
.pm = &renesas_sdhi_sys_dmac_dev_pm_ops,
.of_match_table = renesas_sdhi_sys_dmac_of_match,
},
diff --git a/drivers/mmc/host/sdhci-cadence.c b/drivers/mmc/host/sdhci-cadence.c
index 4d9f7681817c..6f2de54a5987 100644
--- a/drivers/mmc/host/sdhci-cadence.c
+++ b/drivers/mmc/host/sdhci-cadence.c
@@ -463,6 +463,7 @@ MODULE_DEVICE_TABLE(of, sdhci_cdns_match);
static struct platform_driver sdhci_cdns_driver = {
.driver = {
.name = "sdhci-cdns",
+ .probe_type = PROBE_PREFER_ASYNCHRONOUS,
.pm = &sdhci_cdns_pm_ops,
.of_match_table = sdhci_cdns_match,
},
diff --git a/drivers/mmc/host/sdhci-xenon.c b/drivers/mmc/host/sdhci-xenon.c
index 4703cd540c7f..24c978de2a3f 100644
--- a/drivers/mmc/host/sdhci-xenon.c
+++ b/drivers/mmc/host/sdhci-xenon.c
@@ -677,6 +677,7 @@ MODULE_DEVICE_TABLE(of, sdhci_xenon_dt_ids);
static struct platform_driver sdhci_xenon_driver = {
.driver = {
.name = "xenon-sdhci",
+ .probe_type = PROBE_PREFER_ASYNCHRONOUS,
.of_match_table = sdhci_xenon_dt_ids,
.pm = &sdhci_xenon_dev_pm_ops,
},
--
2.28.0.526.ge36021eeef-goog
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 3/6] mmc: Set PROBE_PREFER_ASYNCHRONOUS for drivers that existed in v4.14
2020-09-03 23:24 ` [PATCH 3/6] mmc: Set PROBE_PREFER_ASYNCHRONOUS for drivers that existed in v4.14 Douglas Anderson
@ 2020-09-04 6:35 ` Wolfram Sang
0 siblings, 0 replies; 9+ messages in thread
From: Wolfram Sang @ 2020-09-04 6:35 UTC (permalink / raw)
To: Douglas Anderson
Cc: Ulf Hansson, swboyd, Adrian Hunter, Florian Fainelli, Hu Ziji,
Jaehoon Chung, Jerome Brunet, Jun Nie, Kevin Hilman,
Krzysztof Kozlowski, Martin Blumenstingl, Neil Armstrong,
Nicolas Saenz Julienne, Peter Ujfalusi, Ray Jui, Robert Richter,
Saiyam Doshi, Scott Branden, Shawn Guo, Stefan Wahren,
bcm-kernel-feedback-list, linux-amlogic, linux-arm-kernel,
linux-kernel, linux-mmc, linux-rpi-kernel
[-- Attachment #1: Type: text/plain, Size: 892 bytes --]
On Thu, Sep 03, 2020 at 04:24:38PM -0700, Douglas Anderson wrote:
> This is like commit 3d3451124f3d ("mmc: sdhci-msm: Prefer asynchronous
> probe") but applied to a whole pile of drivers. This batch converts
> the drivers that appeared to be around in the v4.14 timeframe.
The LTS granularity of patches is a nice idea! I will keep it in mind.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
In general, I like more coverage of async probing. It makes sense for
SD/MMC, I think.
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> drivers/mmc/host/renesas_sdhi_internal_dmac.c | 1 +
> drivers/mmc/host/renesas_sdhi_sys_dmac.c | 1 +
For these two also:
Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com> # SDHI drivers
The speedups somewhat match the expected values and no regressions when
checksumming a large file.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 4/6] mmc: Set PROBE_PREFER_ASYNCHRONOUS for drivers that existed in v4.19
[not found] <20200903232441.2694866-1-dianders@chromium.org>
2020-09-03 23:24 ` [PATCH 2/6] mmc: Set PROBE_PREFER_ASYNCHRONOUS for drivers that existed in v4.9 Douglas Anderson
2020-09-03 23:24 ` [PATCH 3/6] mmc: Set PROBE_PREFER_ASYNCHRONOUS for drivers that existed in v4.14 Douglas Anderson
@ 2020-09-03 23:24 ` Douglas Anderson
2020-09-03 23:24 ` [PATCH 5/6] mmc: Set PROBE_PREFER_ASYNCHRONOUS for drivers that existed in v5.4 Douglas Anderson
2020-09-03 23:24 ` [PATCH 6/6] mmc: Set PROBE_PREFER_ASYNCHRONOUS for drivers that are newer than 5.4 Douglas Anderson
4 siblings, 0 replies; 9+ messages in thread
From: Douglas Anderson @ 2020-09-03 23:24 UTC (permalink / raw)
To: Ulf Hansson
Cc: swboyd, Douglas Anderson, Adrian Hunter, Jaehoon Chung,
Jerome Brunet, Kevin Hilman, Kishon Vijay Abraham I,
Martin Blumenstingl, Neil Armstrong, linux-amlogic,
linux-arm-kernel, linux-kernel, linux-mmc
This is like commit 3d3451124f3d ("mmc: sdhci-msm: Prefer asynchronous
probe") but applied to a whole pile of drivers. This batch converts
the drivers that appeared to be around in the v4.19 timeframe.
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
drivers/mmc/host/dw_mmc-bluefield.c | 1 +
drivers/mmc/host/dw_mmc-hi3798cv200.c | 1 +
drivers/mmc/host/meson-mx-sdio.c | 1 +
drivers/mmc/host/sdhci-of-dwcmshc.c | 1 +
drivers/mmc/host/sdhci-omap.c | 1 +
5 files changed, 5 insertions(+)
diff --git a/drivers/mmc/host/dw_mmc-bluefield.c b/drivers/mmc/host/dw_mmc-bluefield.c
index aa38b1a8017e..10baf122bc15 100644
--- a/drivers/mmc/host/dw_mmc-bluefield.c
+++ b/drivers/mmc/host/dw_mmc-bluefield.c
@@ -55,6 +55,7 @@ static struct platform_driver dw_mci_bluefield_pltfm_driver = {
.remove = dw_mci_pltfm_remove,
.driver = {
.name = "dwmmc_bluefield",
+ .probe_type = PROBE_PREFER_ASYNCHRONOUS,
.of_match_table = dw_mci_bluefield_match,
.pm = &dw_mci_pltfm_pmops,
},
diff --git a/drivers/mmc/host/dw_mmc-hi3798cv200.c b/drivers/mmc/host/dw_mmc-hi3798cv200.c
index 83e1bad0a008..39794f93826f 100644
--- a/drivers/mmc/host/dw_mmc-hi3798cv200.c
+++ b/drivers/mmc/host/dw_mmc-hi3798cv200.c
@@ -200,6 +200,7 @@ static struct platform_driver dw_mci_hi3798cv200_driver = {
.remove = dw_mci_hi3798cv200_remove,
.driver = {
.name = "dwmmc_hi3798cv200",
+ .probe_type = PROBE_PREFER_ASYNCHRONOUS,
.of_match_table = dw_mci_hi3798cv200_match,
},
};
diff --git a/drivers/mmc/host/meson-mx-sdio.c b/drivers/mmc/host/meson-mx-sdio.c
index 9b2cf7afc246..a6ff8b4ad1a5 100644
--- a/drivers/mmc/host/meson-mx-sdio.c
+++ b/drivers/mmc/host/meson-mx-sdio.c
@@ -755,6 +755,7 @@ static struct platform_driver meson_mx_mmc_driver = {
.remove = meson_mx_mmc_remove,
.driver = {
.name = "meson-mx-sdio",
+ .probe_type = PROBE_PREFER_ASYNCHRONOUS,
.of_match_table = of_match_ptr(meson_mx_mmc_of_match),
},
};
diff --git a/drivers/mmc/host/sdhci-of-dwcmshc.c b/drivers/mmc/host/sdhci-of-dwcmshc.c
index 64ac0dbee95c..4b673792b5a4 100644
--- a/drivers/mmc/host/sdhci-of-dwcmshc.c
+++ b/drivers/mmc/host/sdhci-of-dwcmshc.c
@@ -214,6 +214,7 @@ MODULE_DEVICE_TABLE(of, sdhci_dwcmshc_dt_ids);
static struct platform_driver sdhci_dwcmshc_driver = {
.driver = {
.name = "sdhci-dwcmshc",
+ .probe_type = PROBE_PREFER_ASYNCHRONOUS,
.of_match_table = sdhci_dwcmshc_dt_ids,
.pm = &dwcmshc_pmops,
},
diff --git a/drivers/mmc/host/sdhci-omap.c b/drivers/mmc/host/sdhci-omap.c
index 1ec74c2d5c17..7893fd3599b6 100644
--- a/drivers/mmc/host/sdhci-omap.c
+++ b/drivers/mmc/host/sdhci-omap.c
@@ -1297,6 +1297,7 @@ static struct platform_driver sdhci_omap_driver = {
.remove = sdhci_omap_remove,
.driver = {
.name = "sdhci-omap",
+ .probe_type = PROBE_PREFER_ASYNCHRONOUS,
.pm = &sdhci_omap_dev_pm_ops,
.of_match_table = omap_sdhci_match,
},
--
2.28.0.526.ge36021eeef-goog
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 5/6] mmc: Set PROBE_PREFER_ASYNCHRONOUS for drivers that existed in v5.4
[not found] <20200903232441.2694866-1-dianders@chromium.org>
` (2 preceding siblings ...)
2020-09-03 23:24 ` [PATCH 4/6] mmc: Set PROBE_PREFER_ASYNCHRONOUS for drivers that existed in v4.19 Douglas Anderson
@ 2020-09-03 23:24 ` Douglas Anderson
2020-09-03 23:24 ` [PATCH 6/6] mmc: Set PROBE_PREFER_ASYNCHRONOUS for drivers that are newer than 5.4 Douglas Anderson
4 siblings, 0 replies; 9+ messages in thread
From: Douglas Anderson @ 2020-09-03 23:24 UTC (permalink / raw)
To: Ulf Hansson
Cc: swboyd, Douglas Anderson, Adrian Hunter, Andrew Jeffery,
Baolin Wang, Christophe JAILLET, Chunyan Zhang, Joel Stanley,
Masahiro Yamada, Orson Zhai, linux-arm-kernel, linux-aspeed,
linux-kernel, linux-mmc
This is like commit 3d3451124f3d ("mmc: sdhci-msm: Prefer asynchronous
probe") but applied to a whole pile of drivers. This batch converts
the drivers that appeared to be around in the v5.4 timeframe.
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
drivers/mmc/host/alcor.c | 1 +
drivers/mmc/host/sdhci-of-aspeed.c | 2 ++
drivers/mmc/host/sdhci-sprd.c | 1 +
drivers/mmc/host/sdhci_am654.c | 1 +
drivers/mmc/host/uniphier-sd.c | 1 +
5 files changed, 6 insertions(+)
diff --git a/drivers/mmc/host/alcor.c b/drivers/mmc/host/alcor.c
index 026ca9194ce5..bfb8efeb7eb8 100644
--- a/drivers/mmc/host/alcor.c
+++ b/drivers/mmc/host/alcor.c
@@ -1178,6 +1178,7 @@ static struct platform_driver alcor_pci_sdmmc_driver = {
.id_table = alcor_pci_sdmmc_ids,
.driver = {
.name = DRV_NAME_ALCOR_PCI_SDMMC,
+ .probe_type = PROBE_PREFER_ASYNCHRONOUS,
.pm = &alcor_mmc_pm_ops
},
};
diff --git a/drivers/mmc/host/sdhci-of-aspeed.c b/drivers/mmc/host/sdhci-of-aspeed.c
index a1bcc0f4ba9e..4f008ba3280e 100644
--- a/drivers/mmc/host/sdhci-of-aspeed.c
+++ b/drivers/mmc/host/sdhci-of-aspeed.c
@@ -240,6 +240,7 @@ static const struct of_device_id aspeed_sdhci_of_match[] = {
static struct platform_driver aspeed_sdhci_driver = {
.driver = {
.name = "sdhci-aspeed",
+ .probe_type = PROBE_PREFER_ASYNCHRONOUS,
.of_match_table = aspeed_sdhci_of_match,
},
.probe = aspeed_sdhci_probe,
@@ -318,6 +319,7 @@ MODULE_DEVICE_TABLE(of, aspeed_sdc_of_match);
static struct platform_driver aspeed_sdc_driver = {
.driver = {
.name = "sd-controller-aspeed",
+ .probe_type = PROBE_PREFER_ASYNCHRONOUS,
.pm = &sdhci_pltfm_pmops,
.of_match_table = aspeed_sdc_of_match,
},
diff --git a/drivers/mmc/host/sdhci-sprd.c b/drivers/mmc/host/sdhci-sprd.c
index a910cb461ed7..f88d38e34a23 100644
--- a/drivers/mmc/host/sdhci-sprd.c
+++ b/drivers/mmc/host/sdhci-sprd.c
@@ -787,6 +787,7 @@ static struct platform_driver sdhci_sprd_driver = {
.remove = sdhci_sprd_remove,
.driver = {
.name = "sdhci_sprd_r11",
+ .probe_type = PROBE_PREFER_ASYNCHRONOUS,
.of_match_table = of_match_ptr(sdhci_sprd_of_match),
.pm = &sdhci_sprd_pm_ops,
},
diff --git a/drivers/mmc/host/sdhci_am654.c b/drivers/mmc/host/sdhci_am654.c
index c5f47197d177..a4c6d9d80e88 100644
--- a/drivers/mmc/host/sdhci_am654.c
+++ b/drivers/mmc/host/sdhci_am654.c
@@ -745,6 +745,7 @@ static int sdhci_am654_remove(struct platform_device *pdev)
static struct platform_driver sdhci_am654_driver = {
.driver = {
.name = "sdhci-am654",
+ .probe_type = PROBE_PREFER_ASYNCHRONOUS,
.of_match_table = sdhci_am654_of_match,
},
.probe = sdhci_am654_probe,
diff --git a/drivers/mmc/host/uniphier-sd.c b/drivers/mmc/host/uniphier-sd.c
index 55efd5c53249..3092466a99ab 100644
--- a/drivers/mmc/host/uniphier-sd.c
+++ b/drivers/mmc/host/uniphier-sd.c
@@ -685,6 +685,7 @@ static struct platform_driver uniphier_sd_driver = {
.remove = uniphier_sd_remove,
.driver = {
.name = "uniphier-sd",
+ .probe_type = PROBE_PREFER_ASYNCHRONOUS,
.of_match_table = uniphier_sd_match,
},
};
--
2.28.0.526.ge36021eeef-goog
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 6/6] mmc: Set PROBE_PREFER_ASYNCHRONOUS for drivers that are newer than 5.4
[not found] <20200903232441.2694866-1-dianders@chromium.org>
` (3 preceding siblings ...)
2020-09-03 23:24 ` [PATCH 5/6] mmc: Set PROBE_PREFER_ASYNCHRONOUS for drivers that existed in v5.4 Douglas Anderson
@ 2020-09-03 23:24 ` Douglas Anderson
2020-09-04 8:14 ` Lars Povlsen
` (2 more replies)
4 siblings, 3 replies; 9+ messages in thread
From: Douglas Anderson @ 2020-09-03 23:24 UTC (permalink / raw)
To: Ulf Hansson
Cc: swboyd, Douglas Anderson, Adrian Hunter, Andreas Färber,
Angelo Dureghello, Jerome Brunet, Kevin Hilman, Lars Povlsen,
Manivannan Sadhasivam, Martin Blumenstingl,
Microchip Linux Driver Support, Neil Armstrong, Steen Hegelund,
linux-amlogic, linux-arm-kernel, linux-kernel, linux-mmc
This is like commit 3d3451124f3d ("mmc: sdhci-msm: Prefer asynchronous
probe") but applied to a whole pile of drivers. This batch converts
the drivers that appeared to have been added after kernel 5.4.
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
drivers/mmc/host/meson-mx-sdhc-mmc.c | 1 +
drivers/mmc/host/owl-mmc.c | 1 +
drivers/mmc/host/sdhci-esdhc-mcf.c | 1 +
drivers/mmc/host/sdhci-milbeaut.c | 1 +
drivers/mmc/host/sdhci-of-sparx5.c | 1 +
5 files changed, 5 insertions(+)
diff --git a/drivers/mmc/host/meson-mx-sdhc-mmc.c b/drivers/mmc/host/meson-mx-sdhc-mmc.c
index 53e3f6a4245a..7cd9c0ec2fcf 100644
--- a/drivers/mmc/host/meson-mx-sdhc-mmc.c
+++ b/drivers/mmc/host/meson-mx-sdhc-mmc.c
@@ -903,6 +903,7 @@ static struct platform_driver meson_mx_sdhc_driver = {
.remove = meson_mx_sdhc_remove,
.driver = {
.name = "meson-mx-sdhc",
+ .probe_type = PROBE_PREFER_ASYNCHRONOUS,
.of_match_table = of_match_ptr(meson_mx_sdhc_of_match),
},
};
diff --git a/drivers/mmc/host/owl-mmc.c b/drivers/mmc/host/owl-mmc.c
index df43f42855e2..ccf214a89eda 100644
--- a/drivers/mmc/host/owl-mmc.c
+++ b/drivers/mmc/host/owl-mmc.c
@@ -689,6 +689,7 @@ MODULE_DEVICE_TABLE(of, owl_mmc_of_match);
static struct platform_driver owl_mmc_driver = {
.driver = {
.name = "owl_mmc",
+ .probe_type = PROBE_PREFER_ASYNCHRONOUS,
.of_match_table = owl_mmc_of_match,
},
.probe = owl_mmc_probe,
diff --git a/drivers/mmc/host/sdhci-esdhc-mcf.c b/drivers/mmc/host/sdhci-esdhc-mcf.c
index 71bf086a9812..ca7a1690b2a8 100644
--- a/drivers/mmc/host/sdhci-esdhc-mcf.c
+++ b/drivers/mmc/host/sdhci-esdhc-mcf.c
@@ -509,6 +509,7 @@ static int sdhci_esdhc_mcf_remove(struct platform_device *pdev)
static struct platform_driver sdhci_esdhc_mcf_driver = {
.driver = {
.name = "sdhci-esdhc-mcf",
+ .probe_type = PROBE_PREFER_ASYNCHRONOUS,
},
.probe = sdhci_esdhc_mcf_probe,
.remove = sdhci_esdhc_mcf_remove,
diff --git a/drivers/mmc/host/sdhci-milbeaut.c b/drivers/mmc/host/sdhci-milbeaut.c
index 4e7cc0680f94..148b37ac6564 100644
--- a/drivers/mmc/host/sdhci-milbeaut.c
+++ b/drivers/mmc/host/sdhci-milbeaut.c
@@ -333,6 +333,7 @@ static int sdhci_milbeaut_remove(struct platform_device *pdev)
static struct platform_driver sdhci_milbeaut_driver = {
.driver = {
.name = "sdhci-milbeaut",
+ .probe_type = PROBE_PREFER_ASYNCHRONOUS,
.of_match_table = of_match_ptr(mlb_dt_ids),
},
.probe = sdhci_milbeaut_probe,
diff --git a/drivers/mmc/host/sdhci-of-sparx5.c b/drivers/mmc/host/sdhci-of-sparx5.c
index 747f108a0ace..28e4ee69e100 100644
--- a/drivers/mmc/host/sdhci-of-sparx5.c
+++ b/drivers/mmc/host/sdhci-of-sparx5.c
@@ -255,6 +255,7 @@ MODULE_DEVICE_TABLE(of, sdhci_sparx5_of_match);
static struct platform_driver sdhci_sparx5_driver = {
.driver = {
.name = "sdhci-sparx5",
+ .probe_type = PROBE_PREFER_ASYNCHRONOUS,
.of_match_table = sdhci_sparx5_of_match,
.pm = &sdhci_pltfm_pmops,
},
--
2.28.0.526.ge36021eeef-goog
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 6/6] mmc: Set PROBE_PREFER_ASYNCHRONOUS for drivers that are newer than 5.4
2020-09-03 23:24 ` [PATCH 6/6] mmc: Set PROBE_PREFER_ASYNCHRONOUS for drivers that are newer than 5.4 Douglas Anderson
@ 2020-09-04 8:14 ` Lars Povlsen
2020-09-04 9:33 ` Angelo Dureghello
2020-09-04 10:42 ` Manivannan Sadhasivam
2 siblings, 0 replies; 9+ messages in thread
From: Lars Povlsen @ 2020-09-04 8:14 UTC (permalink / raw)
To: Douglas Anderson
Cc: Ulf Hansson, swboyd, Adrian Hunter, Andreas Färber,
Angelo Dureghello, Jerome Brunet, Kevin Hilman, Lars Povlsen,
Manivannan Sadhasivam, Martin Blumenstingl,
Microchip Linux Driver Support, Neil Armstrong, Steen Hegelund,
linux-amlogic, linux-arm-kernel, linux-kernel, linux-mmc
Douglas Anderson writes:
> This is like commit 3d3451124f3d ("mmc: sdhci-msm: Prefer asynchronous
> probe") but applied to a whole pile of drivers. This batch converts
> the drivers that appeared to have been added after kernel 5.4.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
>
> drivers/mmc/host/meson-mx-sdhc-mmc.c | 1 +
> drivers/mmc/host/owl-mmc.c | 1 +
> drivers/mmc/host/sdhci-esdhc-mcf.c | 1 +
> drivers/mmc/host/sdhci-milbeaut.c | 1 +
> drivers/mmc/host/sdhci-of-sparx5.c | 1 +
> 5 files changed, 5 insertions(+)
>
[snip]
> diff --git a/drivers/mmc/host/sdhci-of-sparx5.c b/drivers/mmc/host/sdhci-of-sparx5.c
> index 747f108a0ace..28e4ee69e100 100644
> --- a/drivers/mmc/host/sdhci-of-sparx5.c
> +++ b/drivers/mmc/host/sdhci-of-sparx5.c
> @@ -255,6 +255,7 @@ MODULE_DEVICE_TABLE(of, sdhci_sparx5_of_match);
> static struct platform_driver sdhci_sparx5_driver = {
> .driver = {
> .name = "sdhci-sparx5",
> + .probe_type = PROBE_PREFER_ASYNCHRONOUS,
> .of_match_table = sdhci_sparx5_of_match,
> .pm = &sdhci_pltfm_pmops,
> },
Acked-by: Lars Povlsen <lars.povlsen@microchip.com>
--
Lars Povlsen,
Microchip
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 6/6] mmc: Set PROBE_PREFER_ASYNCHRONOUS for drivers that are newer than 5.4
2020-09-03 23:24 ` [PATCH 6/6] mmc: Set PROBE_PREFER_ASYNCHRONOUS for drivers that are newer than 5.4 Douglas Anderson
2020-09-04 8:14 ` Lars Povlsen
@ 2020-09-04 9:33 ` Angelo Dureghello
2020-09-04 10:42 ` Manivannan Sadhasivam
2 siblings, 0 replies; 9+ messages in thread
From: Angelo Dureghello @ 2020-09-04 9:33 UTC (permalink / raw)
To: Douglas Anderson
Cc: Ulf Hansson, swboyd, Adrian Hunter, Andreas Färber,
Jerome Brunet, Kevin Hilman, Lars Povlsen, Manivannan Sadhasivam,
Martin Blumenstingl, Microchip Linux Driver Support,
Neil Armstrong, Steen Hegelund, linux-amlogic, linux-arm-kernel,
linux-kernel, linux-mmc
On Fri, Sep 4, 2020 at 1:25 AM Douglas Anderson <dianders@chromium.org> wrote:
> This is like commit 3d3451124f3d ("mmc: sdhci-msm: Prefer asynchronous
> probe") but applied to a whole pile of drivers. This batch converts
> the drivers that appeared to have been added after kernel 5.4.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
>
> drivers/mmc/host/meson-mx-sdhc-mmc.c | 1 +
> drivers/mmc/host/owl-mmc.c | 1 +
> drivers/mmc/host/sdhci-esdhc-mcf.c | 1 +
> drivers/mmc/host/sdhci-milbeaut.c | 1 +
> drivers/mmc/host/sdhci-of-sparx5.c | 1 +
> 5 files changed, 5 insertions(+)
[snip]
>
>
> diff --git a/drivers/mmc/host/sdhci-esdhc-mcf.c b/drivers/mmc/host/sdhci-esdhc-mcf.c
> index 71bf086a9812..ca7a1690b2a8 100644
> --- a/drivers/mmc/host/sdhci-esdhc-mcf.c
> +++ b/drivers/mmc/host/sdhci-esdhc-mcf.c
> @@ -509,6 +509,7 @@ static int sdhci_esdhc_mcf_remove(struct platform_device *pdev)
> static struct platform_driver sdhci_esdhc_mcf_driver = {
> .driver = {
> .name = "sdhci-esdhc-mcf",
> + .probe_type = PROBE_PREFER_ASYNCHRONOUS,
> },
> .probe = sdhci_esdhc_mcf_probe,
> .remove = sdhci_esdhc_mcf_remove,
>
Acked-by: Angelo Dureghello <angelo.dureghello@timesys.com>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 6/6] mmc: Set PROBE_PREFER_ASYNCHRONOUS for drivers that are newer than 5.4
2020-09-03 23:24 ` [PATCH 6/6] mmc: Set PROBE_PREFER_ASYNCHRONOUS for drivers that are newer than 5.4 Douglas Anderson
2020-09-04 8:14 ` Lars Povlsen
2020-09-04 9:33 ` Angelo Dureghello
@ 2020-09-04 10:42 ` Manivannan Sadhasivam
2 siblings, 0 replies; 9+ messages in thread
From: Manivannan Sadhasivam @ 2020-09-04 10:42 UTC (permalink / raw)
To: Douglas Anderson
Cc: Ulf Hansson, swboyd, Adrian Hunter, Andreas Färber,
Angelo Dureghello, Jerome Brunet, Kevin Hilman, Lars Povlsen,
Martin Blumenstingl, Microchip Linux Driver Support,
Neil Armstrong, Steen Hegelund, linux-amlogic, linux-arm-kernel,
linux-kernel, linux-mmc
On 0903, Douglas Anderson wrote:
> This is like commit 3d3451124f3d ("mmc: sdhci-msm: Prefer asynchronous
> probe") but applied to a whole pile of drivers. This batch converts
> the drivers that appeared to have been added after kernel 5.4.
>
Backporting made easy ;)
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
For owl-mmc,
Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Thanks,
Mani
> ---
>
> drivers/mmc/host/meson-mx-sdhc-mmc.c | 1 +
> drivers/mmc/host/owl-mmc.c | 1 +
> drivers/mmc/host/sdhci-esdhc-mcf.c | 1 +
> drivers/mmc/host/sdhci-milbeaut.c | 1 +
> drivers/mmc/host/sdhci-of-sparx5.c | 1 +
> 5 files changed, 5 insertions(+)
>
> diff --git a/drivers/mmc/host/meson-mx-sdhc-mmc.c b/drivers/mmc/host/meson-mx-sdhc-mmc.c
> index 53e3f6a4245a..7cd9c0ec2fcf 100644
> --- a/drivers/mmc/host/meson-mx-sdhc-mmc.c
> +++ b/drivers/mmc/host/meson-mx-sdhc-mmc.c
> @@ -903,6 +903,7 @@ static struct platform_driver meson_mx_sdhc_driver = {
> .remove = meson_mx_sdhc_remove,
> .driver = {
> .name = "meson-mx-sdhc",
> + .probe_type = PROBE_PREFER_ASYNCHRONOUS,
> .of_match_table = of_match_ptr(meson_mx_sdhc_of_match),
> },
> };
> diff --git a/drivers/mmc/host/owl-mmc.c b/drivers/mmc/host/owl-mmc.c
> index df43f42855e2..ccf214a89eda 100644
> --- a/drivers/mmc/host/owl-mmc.c
> +++ b/drivers/mmc/host/owl-mmc.c
> @@ -689,6 +689,7 @@ MODULE_DEVICE_TABLE(of, owl_mmc_of_match);
> static struct platform_driver owl_mmc_driver = {
> .driver = {
> .name = "owl_mmc",
> + .probe_type = PROBE_PREFER_ASYNCHRONOUS,
> .of_match_table = owl_mmc_of_match,
> },
> .probe = owl_mmc_probe,
> diff --git a/drivers/mmc/host/sdhci-esdhc-mcf.c b/drivers/mmc/host/sdhci-esdhc-mcf.c
> index 71bf086a9812..ca7a1690b2a8 100644
> --- a/drivers/mmc/host/sdhci-esdhc-mcf.c
> +++ b/drivers/mmc/host/sdhci-esdhc-mcf.c
> @@ -509,6 +509,7 @@ static int sdhci_esdhc_mcf_remove(struct platform_device *pdev)
> static struct platform_driver sdhci_esdhc_mcf_driver = {
> .driver = {
> .name = "sdhci-esdhc-mcf",
> + .probe_type = PROBE_PREFER_ASYNCHRONOUS,
> },
> .probe = sdhci_esdhc_mcf_probe,
> .remove = sdhci_esdhc_mcf_remove,
> diff --git a/drivers/mmc/host/sdhci-milbeaut.c b/drivers/mmc/host/sdhci-milbeaut.c
> index 4e7cc0680f94..148b37ac6564 100644
> --- a/drivers/mmc/host/sdhci-milbeaut.c
> +++ b/drivers/mmc/host/sdhci-milbeaut.c
> @@ -333,6 +333,7 @@ static int sdhci_milbeaut_remove(struct platform_device *pdev)
> static struct platform_driver sdhci_milbeaut_driver = {
> .driver = {
> .name = "sdhci-milbeaut",
> + .probe_type = PROBE_PREFER_ASYNCHRONOUS,
> .of_match_table = of_match_ptr(mlb_dt_ids),
> },
> .probe = sdhci_milbeaut_probe,
> diff --git a/drivers/mmc/host/sdhci-of-sparx5.c b/drivers/mmc/host/sdhci-of-sparx5.c
> index 747f108a0ace..28e4ee69e100 100644
> --- a/drivers/mmc/host/sdhci-of-sparx5.c
> +++ b/drivers/mmc/host/sdhci-of-sparx5.c
> @@ -255,6 +255,7 @@ MODULE_DEVICE_TABLE(of, sdhci_sparx5_of_match);
> static struct platform_driver sdhci_sparx5_driver = {
> .driver = {
> .name = "sdhci-sparx5",
> + .probe_type = PROBE_PREFER_ASYNCHRONOUS,
> .of_match_table = sdhci_sparx5_of_match,
> .pm = &sdhci_pltfm_pmops,
> },
> --
> 2.28.0.526.ge36021eeef-goog
>
^ permalink raw reply [flat|nested] 9+ messages in thread