* [PATCH 1/2] dt-bindings: mfd: google,cros-ec: Use unevaluatedProperties
@ 2020-08-31 16:11 Krzysztof Kozlowski
2020-08-31 16:11 ` [PATCH 2/2] dt-bindings: mmc: mmc-pwreq-simple: Accept more than one reset GPIO Krzysztof Kozlowski
2020-09-03 16:48 ` [PATCH 1/2] dt-bindings: mfd: google,cros-ec: Use unevaluatedProperties Rob Herring
0 siblings, 2 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2020-08-31 16:11 UTC (permalink / raw)
To: Lee Jones, Rob Herring, Benson Leung, Enric Balletbo i Serra,
Guenter Roeck, Ulf Hansson, devicetree, linux-kernel, linux-mmc
Cc: Marek Szyprowski, Bartlomiej Zolnierkiewicz, Sylwester Nawrocki,
Krzysztof Kozlowski
Additional properties or nodes actually might appear (e.g. wakeup) so
use unevaluatedProperties to fix dtbs_check warnings like:
arch/arm/boot/dts/exynos5250-snow.dt.yaml: embedded-controller@1e:
'keyboard-controller', 'wakeup-source' do not match any of the regexes: 'pinctrl-[0-9]+'
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
Documentation/devicetree/bindings/mfd/google,cros-ec.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
index 6a7279a85ec1..0586c5791cf6 100644
--- a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
+++ b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
@@ -79,7 +79,7 @@ then:
google,cros-ec-spi-msg-delay: false
spi-max-frequency: false
-additionalProperties: false
+unevaluatedProperties: false
examples:
# Example for I2C
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] dt-bindings: mmc: mmc-pwreq-simple: Accept more than one reset GPIO
2020-08-31 16:11 [PATCH 1/2] dt-bindings: mfd: google,cros-ec: Use unevaluatedProperties Krzysztof Kozlowski
@ 2020-08-31 16:11 ` Krzysztof Kozlowski
2020-09-02 9:03 ` Ulf Hansson
2020-09-03 16:48 ` [PATCH 1/2] dt-bindings: mfd: google,cros-ec: Use unevaluatedProperties Rob Herring
1 sibling, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2020-08-31 16:11 UTC (permalink / raw)
To: Lee Jones, Rob Herring, Benson Leung, Enric Balletbo i Serra,
Guenter Roeck, Ulf Hansson, devicetree, linux-kernel, linux-mmc
Cc: Marek Szyprowski, Bartlomiej Zolnierkiewicz, Sylwester Nawrocki,
Krzysztof Kozlowski
There might be multiple reset GPIOs but dtschema has trouble parsing it
if there are no maxItems:
arch/arm/boot/dts/exynos5250-snow.dt.yaml: mmc3_pwrseq: reset-gpios: [[20, 2, 1], [20, 1, 1]] is too long
From schema: Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml b/Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml
index 449215444723..8d625f903856 100644
--- a/Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml
+++ b/Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml
@@ -20,6 +20,8 @@ properties:
reset-gpios:
minItems: 1
+ # Put some limit to avoid false warnings
+ maxItems: 32
description:
contains a list of GPIO specifiers. The reset GPIOs are asserted
at initialization and prior we start the power up procedure of the card.
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] dt-bindings: mmc: mmc-pwreq-simple: Accept more than one reset GPIO
2020-08-31 16:11 ` [PATCH 2/2] dt-bindings: mmc: mmc-pwreq-simple: Accept more than one reset GPIO Krzysztof Kozlowski
@ 2020-09-02 9:03 ` Ulf Hansson
0 siblings, 0 replies; 4+ messages in thread
From: Ulf Hansson @ 2020-09-02 9:03 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Lee Jones, Rob Herring, Benson Leung, Enric Balletbo i Serra,
Guenter Roeck, DTML, Linux Kernel Mailing List, linux-mmc,
Marek Szyprowski, Bartlomiej Zolnierkiewicz, Sylwester Nawrocki
On Mon, 31 Aug 2020 at 18:11, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> There might be multiple reset GPIOs but dtschema has trouble parsing it
> if there are no maxItems:
>
> arch/arm/boot/dts/exynos5250-snow.dt.yaml: mmc3_pwrseq: reset-gpios: [[20, 2, 1], [20, 1, 1]] is too long
> From schema: Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml b/Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml
> index 449215444723..8d625f903856 100644
> --- a/Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml
> +++ b/Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml
> @@ -20,6 +20,8 @@ properties:
>
> reset-gpios:
> minItems: 1
> + # Put some limit to avoid false warnings
> + maxItems: 32
Not sure what number to pick. I guess two should be enough, but on the
other hand it doesn't really matter.
> description:
> contains a list of GPIO specifiers. The reset GPIOs are asserted
> at initialization and prior we start the power up procedure of the card.
> --
> 2.17.1
>
Applied for next, thanks!
Kind regards
Uffe
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] dt-bindings: mfd: google,cros-ec: Use unevaluatedProperties
2020-08-31 16:11 [PATCH 1/2] dt-bindings: mfd: google,cros-ec: Use unevaluatedProperties Krzysztof Kozlowski
2020-08-31 16:11 ` [PATCH 2/2] dt-bindings: mmc: mmc-pwreq-simple: Accept more than one reset GPIO Krzysztof Kozlowski
@ 2020-09-03 16:48 ` Rob Herring
1 sibling, 0 replies; 4+ messages in thread
From: Rob Herring @ 2020-09-03 16:48 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Lee Jones, Benson Leung, Enric Balletbo i Serra, Guenter Roeck,
Ulf Hansson, devicetree, linux-kernel, linux-mmc,
Marek Szyprowski, Bartlomiej Zolnierkiewicz, Sylwester Nawrocki
On Mon, Aug 31, 2020 at 06:11:46PM +0200, Krzysztof Kozlowski wrote:
> Additional properties or nodes actually might appear (e.g. wakeup) so
> use unevaluatedProperties to fix dtbs_check warnings like:
>
> arch/arm/boot/dts/exynos5250-snow.dt.yaml: embedded-controller@1e:
> 'keyboard-controller', 'wakeup-source' do not match any of the regexes: 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> Documentation/devicetree/bindings/mfd/google,cros-ec.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
NAK. See https://lore.kernel.org/r/CAL_JsqKPXJxsHPS34_TCf9bwgKxZNSV4mvQR-WKRnknQVtGGxQ@mail.gmail.com/
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-09-03 16:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-31 16:11 [PATCH 1/2] dt-bindings: mfd: google,cros-ec: Use unevaluatedProperties Krzysztof Kozlowski
2020-08-31 16:11 ` [PATCH 2/2] dt-bindings: mmc: mmc-pwreq-simple: Accept more than one reset GPIO Krzysztof Kozlowski
2020-09-02 9:03 ` Ulf Hansson
2020-09-03 16:48 ` [PATCH 1/2] dt-bindings: mfd: google,cros-ec: Use unevaluatedProperties Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).