* [PATCH 0/2] use generic_file_buffered_read()
@ 2020-09-04 9:13 Bean Huo
2020-09-04 9:13 ` [PATCH 1/2] block: " Bean Huo
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Bean Huo @ 2020-09-04 9:13 UTC (permalink / raw)
To: axboe, linux-block, linux-kernel; +Cc: beanhuo
From: Bean Huo <beanhuo@micron.com>
Bean Huo (2):
block: use generic_file_buffered_read()
fs: isofs: use generic_file_buffered_read()
drivers/block/sunvdc.c | 6 +++---
fs/isofs/compress.c | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
--
2.17.1
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH 1/2] block: use generic_file_buffered_read()
2020-09-04 9:13 [PATCH 0/2] use generic_file_buffered_read() Bean Huo
@ 2020-09-04 9:13 ` Bean Huo
2020-09-04 9:13 ` [PATCH 2/2] fs: isofs: " Bean Huo
2020-09-04 16:53 ` [PATCH 0/2] " Jens Axboe
2 siblings, 0 replies; 5+ messages in thread
From: Bean Huo @ 2020-09-04 9:13 UTC (permalink / raw)
To: axboe, linux-block, linux-kernel; +Cc: beanhuo
From: Bean Huo <beanhuo@micron.com>
do_generic_file_read() has been renamed to generic_file_buffered_read() since
commit 47c27bc46946 ("fs: pass iocb to do_generic_file_read").
Signed-off-by: Bean Huo <beanhuo@micron.com>
---
drivers/block/sunvdc.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/block/sunvdc.c b/drivers/block/sunvdc.c
index 39aeebc6837d..06262e990c9b 100644
--- a/drivers/block/sunvdc.c
+++ b/drivers/block/sunvdc.c
@@ -1017,9 +1017,9 @@ static int vdc_port_probe(struct vio_dev *vdev, const struct vio_device_id *id)
VDCBLK_NAME "%c", 'a' + ((int)vdev->dev_no % 26));
port->vdisk_size = -1;
- /* Actual wall time may be double due to do_generic_file_read() doing
- * a readahead I/O first, and once that fails it will try to read a
- * single page.
+ /* Actual wall time may be double due to generic_file_buffered_read()
+ * doing a readahead I/O first, and once that fails it will try to read
+ * a single page.
*/
ldc_timeout = mdesc_get_property(hp, vdev->mp, "vdc-timeout", NULL);
port->ldc_timeout = ldc_timeout ? *ldc_timeout : 0;
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 2/2] fs: isofs: use generic_file_buffered_read()
2020-09-04 9:13 [PATCH 0/2] use generic_file_buffered_read() Bean Huo
2020-09-04 9:13 ` [PATCH 1/2] block: " Bean Huo
@ 2020-09-04 9:13 ` Bean Huo
2020-09-04 16:53 ` [PATCH 0/2] " Jens Axboe
2 siblings, 0 replies; 5+ messages in thread
From: Bean Huo @ 2020-09-04 9:13 UTC (permalink / raw)
To: axboe, linux-block, linux-kernel; +Cc: beanhuo
From: Bean Huo <beanhuo@micron.com>
do_generic_file_read() has been renamed to generic_file_buffered_read()
since commit 47c27bc46946 ("fs: pass iocb to do_generic_file_read").
Signed-off-by: Bean Huo <beanhuo@micron.com>
---
fs/isofs/compress.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/isofs/compress.c b/fs/isofs/compress.c
index bc12ac7e2312..7541581c1064 100644
--- a/fs/isofs/compress.c
+++ b/fs/isofs/compress.c
@@ -312,7 +312,7 @@ static int zisofs_readpage(struct file *file, struct page *page)
end_index = (inode->i_size + PAGE_SIZE - 1) >> PAGE_SHIFT;
/*
* If this page is wholly outside i_size we just return zero;
- * do_generic_file_read() will handle this for us
+ * generic_file_buffered_read() will handle this for us
*/
if (index >= end_index) {
SetPageUptodate(page);
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 0/2] use generic_file_buffered_read()
2020-09-04 9:13 [PATCH 0/2] use generic_file_buffered_read() Bean Huo
2020-09-04 9:13 ` [PATCH 1/2] block: " Bean Huo
2020-09-04 9:13 ` [PATCH 2/2] fs: isofs: " Bean Huo
@ 2020-09-04 16:53 ` Jens Axboe
2020-09-07 11:37 ` Bean Huo
2 siblings, 1 reply; 5+ messages in thread
From: Jens Axboe @ 2020-09-04 16:53 UTC (permalink / raw)
To: Bean Huo, linux-block, linux-kernel; +Cc: beanhuo
On 9/4/20 3:13 AM, Bean Huo wrote:
> From: Bean Huo <beanhuo@micron.com>
>
>
> Bean Huo (2):
> block: use generic_file_buffered_read()
> fs: isofs: use generic_file_buffered_read()
The change is fine, but the title/commit message should reflect that
this is just a comment change. The way it currently reads, it sounds
like a functional change where something is switched over to using
generic_file_buffered_read().
--
Jens Axboe
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 0/2] use generic_file_buffered_read()
2020-09-04 16:53 ` [PATCH 0/2] " Jens Axboe
@ 2020-09-07 11:37 ` Bean Huo
0 siblings, 0 replies; 5+ messages in thread
From: Bean Huo @ 2020-09-07 11:37 UTC (permalink / raw)
To: Jens Axboe, linux-block, linux-kernel; +Cc: beanhuo
On Fri, 2020-09-04 at 10:53 -0600, Jens Axboe wrote:
> > Bean Huo (2):
> > block: use generic_file_buffered_read()
> > fs: isofs: use generic_file_buffered_read()
>
> The change is fine, but the title/commit message should reflect that
> this is just a comment change. The way it currently reads, it sounds
> like a functional change where something is switched over to using
> generic_file_buffered_read().
>
Hi Jens
Indeed, it's easy to mistake this for a functional change, but it's
actually a comment change. I have corrected them in the new patch, you
can check now.
thanks,
Bean
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-09-07 11:39 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-04 9:13 [PATCH 0/2] use generic_file_buffered_read() Bean Huo
2020-09-04 9:13 ` [PATCH 1/2] block: " Bean Huo
2020-09-04 9:13 ` [PATCH 2/2] fs: isofs: " Bean Huo
2020-09-04 16:53 ` [PATCH 0/2] " Jens Axboe
2020-09-07 11:37 ` Bean Huo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).