From: Greg KH <gregkh@linuxfoundation.org>
To: PengHao <penghao@uniontech.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
johan@kernel.org, dlaz@chromium.org, stern@rowland.harvard.edu,
kerneldev@karsmulder.nl, jonathan@jdcox.net,
tomasz@meresinski.eu
Subject: Re: [PATCH v3] HID: quirks: Add USB_QUIRK_IGNORE_REMOTE_WAKEUP quirk for BYD zhaoxin notebook
Date: Fri, 4 Sep 2020 12:44:47 +0200 [thread overview]
Message-ID: <20200904104447.GA2727177@kroah.com> (raw)
In-Reply-To: <bd5674f2-67dc-b386-f639-97ddce13b8af@uniontech.com>
On Fri, Sep 04, 2020 at 06:38:21PM +0800, PengHao wrote:
> Hi, Hans
>
> Thanks for the review. And sorry for I'm not really familiar with
> mailing list, so didn't reply early.
>
> Actually the reason why I submit this patch, is the vendor ask we do
> this, they do not want enable touchpad wakeup.
That says _what_ they want to do, but we need to know _why_ this is the
case.
What is wrong with the existing touchpad wakeup functionality that is
broken on this device? Why does this quirk have to be added, what goes
wrong if it is not added?
Please put that information in the changelog text.
thanks,
greg k-h
next prev parent reply other threads:[~2020-09-04 10:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-04 9:13 [PATCH v3] HID: quirks: Add USB_QUIRK_IGNORE_REMOTE_WAKEUP quirk for BYD zhaoxin notebook Penghao
2020-09-04 10:05 ` Hans de Goede
2020-09-04 10:38 ` PengHao
2020-09-04 10:44 ` Greg KH [this message]
2020-09-04 11:16 ` Hans de Goede
2020-09-04 13:50 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200904104447.GA2727177@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dlaz@chromium.org \
--cc=hdegoede@redhat.com \
--cc=johan@kernel.org \
--cc=jonathan@jdcox.net \
--cc=kerneldev@karsmulder.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=penghao@uniontech.com \
--cc=stern@rowland.harvard.edu \
--cc=tomasz@meresinski.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).