From: Hans de Goede <hdegoede@redhat.com>
To: Penghao <penghao@uniontech.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
gregkh@linuxfoundation.org
Cc: johan@kernel.org, dlaz@chromium.org, stern@rowland.harvard.edu,
kerneldev@karsmulder.nl, jonathan@jdcox.net,
tomasz@meresinski.eu
Subject: Re: [PATCH v3] HID: quirks: Add USB_QUIRK_IGNORE_REMOTE_WAKEUP quirk for BYD zhaoxin notebook
Date: Fri, 4 Sep 2020 12:05:23 +0200 [thread overview]
Message-ID: <f519d8a0-9082-13c5-0222-40dd9a1fac36@redhat.com> (raw)
In-Reply-To: <20200904091322.30426-1-penghao@uniontech.com>
Hi,
On 9/4/20 11:13 AM, Penghao wrote:
> Add a USB_QUIRK_IGNORE_REMOTE_WAKEUP quirk for the BYD zhaoxin notebook.
> This notebook come with usb touchpad. And we would like to disable touchpad
> wakeup on this notebook by default.
You are still not explaining why this is necessary ?
And you did not answer my question if this touchpad is using hid-multitouch
either ?
So NACK (rejection) from me until both questions are answered. The commi
message for a quirk should always explain why a quirk is necessary and
"we would like to disable touchpad wakeup on this notebook by default"
does not explain why you want to do that.
Regards,
Hans
>
> Signed-off-by: Penghao <penghao@uniontech.com>
> ---
>
> Changes since v2:
> - Add changes
>
> Changes since v1:
> - Add the entries sorted by vendor ID and product ID.
>
> drivers/usb/core/quirks.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> index 7c1198f80c23..fffe1f7f1098 100644
> --- a/drivers/usb/core/quirks.c
> +++ b/drivers/usb/core/quirks.c
> @@ -393,6 +393,10 @@ static const struct usb_device_id usb_quirk_list[] = {
> /* Generic RTL8153 based ethernet adapters */
> { USB_DEVICE(0x0bda, 0x8153), .driver_info = USB_QUIRK_NO_LPM },
>
> + /* SONiX USB DEVICE Touchpad */
> + { USB_DEVICE(0x0c45, 0x7056), .driver_info =
> + USB_QUIRK_IGNORE_REMOTE_WAKEUP },
> +
> /* Action Semiconductor flash disk */
> { USB_DEVICE(0x10d6, 0x2200), .driver_info =
> USB_QUIRK_STRING_FETCH_255 },
>
next prev parent reply other threads:[~2020-09-04 10:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-04 9:13 [PATCH v3] HID: quirks: Add USB_QUIRK_IGNORE_REMOTE_WAKEUP quirk for BYD zhaoxin notebook Penghao
2020-09-04 10:05 ` Hans de Goede [this message]
2020-09-04 10:38 ` PengHao
2020-09-04 10:44 ` Greg KH
2020-09-04 11:16 ` Hans de Goede
2020-09-04 13:50 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f519d8a0-9082-13c5-0222-40dd9a1fac36@redhat.com \
--to=hdegoede@redhat.com \
--cc=dlaz@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=jonathan@jdcox.net \
--cc=kerneldev@karsmulder.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=penghao@uniontech.com \
--cc=stern@rowland.harvard.edu \
--cc=tomasz@meresinski.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).