linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next] RDMA/bnxt_re: Remove set but not used variable 'qplib_ctx'
@ 2020-09-05 12:16 YueHaibing
  2020-09-06  7:37 ` Leon Romanovsky
  2020-09-09 16:21 ` Jason Gunthorpe
  0 siblings, 2 replies; 3+ messages in thread
From: YueHaibing @ 2020-09-05 12:16 UTC (permalink / raw)
  To: selvin.xavier, devesh.sharma, somnath.kotur,
	sriharsha.basavapatna, nareshkumar.pbs, dledford, jgg
  Cc: linux-rdma, linux-kernel, YueHaibing

drivers/infiniband/hw/bnxt_re/main.c:1012:25:
 warning: variable ‘qplib_ctx’ set but not used [-Wunused-but-set-variable]

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/infiniband/hw/bnxt_re/main.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/infiniband/hw/bnxt_re/main.c b/drivers/infiniband/hw/bnxt_re/main.c
index 13bbeb42794f..53aee5a42ab8 100644
--- a/drivers/infiniband/hw/bnxt_re/main.c
+++ b/drivers/infiniband/hw/bnxt_re/main.c
@@ -1009,7 +1009,6 @@ static void bnxt_re_free_res(struct bnxt_re_dev *rdev)
 static int bnxt_re_alloc_res(struct bnxt_re_dev *rdev)
 {
 	struct bnxt_re_ring_attr rattr = {};
-	struct bnxt_qplib_ctx *qplib_ctx;
 	int num_vec_created = 0;
 	int rc = 0, i;
 	u8 type;
@@ -1032,7 +1031,6 @@ static int bnxt_re_alloc_res(struct bnxt_re_dev *rdev)
 	if (rc)
 		goto dealloc_res;
 
-	qplib_ctx = &rdev->qplib_ctx;
 	for (i = 0; i < rdev->num_msix - 1; i++) {
 		struct bnxt_qplib_nq *nq;
 
-- 
2.17.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] RDMA/bnxt_re: Remove set but not used variable 'qplib_ctx'
  2020-09-05 12:16 [PATCH -next] RDMA/bnxt_re: Remove set but not used variable 'qplib_ctx' YueHaibing
@ 2020-09-06  7:37 ` Leon Romanovsky
  2020-09-09 16:21 ` Jason Gunthorpe
  1 sibling, 0 replies; 3+ messages in thread
From: Leon Romanovsky @ 2020-09-06  7:37 UTC (permalink / raw)
  To: YueHaibing
  Cc: selvin.xavier, devesh.sharma, somnath.kotur,
	sriharsha.basavapatna, nareshkumar.pbs, dledford, jgg,
	linux-rdma, linux-kernel

On Sat, Sep 05, 2020 at 08:16:24PM +0800, YueHaibing wrote:
> drivers/infiniband/hw/bnxt_re/main.c:1012:25:
>  warning: variable ‘qplib_ctx’ set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  drivers/infiniband/hw/bnxt_re/main.c | 2 --
>  1 file changed, 2 deletions(-)

The patch is for rdma-rc and not for rdma-next.
Fixes: f86b31c6a28f ("RDMA/bnxt_re: Static NQ depth allocation")

Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] RDMA/bnxt_re: Remove set but not used variable 'qplib_ctx'
  2020-09-05 12:16 [PATCH -next] RDMA/bnxt_re: Remove set but not used variable 'qplib_ctx' YueHaibing
  2020-09-06  7:37 ` Leon Romanovsky
@ 2020-09-09 16:21 ` Jason Gunthorpe
  1 sibling, 0 replies; 3+ messages in thread
From: Jason Gunthorpe @ 2020-09-09 16:21 UTC (permalink / raw)
  To: YueHaibing
  Cc: selvin.xavier, devesh.sharma, somnath.kotur,
	sriharsha.basavapatna, nareshkumar.pbs, dledford, linux-rdma,
	linux-kernel

On Sat, Sep 05, 2020 at 08:16:24PM +0800, YueHaibing wrote:
> drivers/infiniband/hw/bnxt_re/main.c:1012:25:
>  warning: variable ‘qplib_ctx’ set but not used [-Wunused-but-set-variable]
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
> ---
>  drivers/infiniband/hw/bnxt_re/main.c | 2 --
>  1 file changed, 2 deletions(-)

Applied to for-rc, thanks

Jason

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-09-09 16:23 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-05 12:16 [PATCH -next] RDMA/bnxt_re: Remove set but not used variable 'qplib_ctx' YueHaibing
2020-09-06  7:37 ` Leon Romanovsky
2020-09-09 16:21 ` Jason Gunthorpe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).