* [PATCH 0/2] drm/sun4i: sun8i-csc: Secondary CSC register correction
@ 2020-09-06 16:21 Martin Cerveny
2020-09-06 16:21 ` [PATCH 1/2] " Martin Cerveny
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Martin Cerveny @ 2020-09-06 16:21 UTC (permalink / raw)
To: Maxime Ripard
Cc: Martin Cerveny, Chen-Yu Tsai, Daniel Vetter, David Airlie,
dri-devel, Jernej Skrabec, linux-arm-kernel, linux-kernel
The secondary video layer (VI) on "Allwinner V3s" displays
decoded video (YUV) in wrong colors. The secondary
CSC should be programmed.
Let's correct CSC register offset and extend regmap size.
Regards.
Martin Cerveny (2):
drm/sun4i: sun8i-csc: Secondary CSC register correction
drm/sun4i: mixer: Extend regmap max_register
drivers/gpu/drm/sun4i/sun8i_csc.h | 2 +-
drivers/gpu/drm/sun4i/sun8i_mixer.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
--
2.17.1
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 1/2] drm/sun4i: sun8i-csc: Secondary CSC register correction
2020-09-06 16:21 [PATCH 0/2] drm/sun4i: sun8i-csc: Secondary CSC register correction Martin Cerveny
@ 2020-09-06 16:21 ` Martin Cerveny
2020-09-08 16:13 ` Jernej Škrabec
2020-09-06 16:21 ` [PATCH 2/2] drm/sun4i: mixer: Extend regmap max_register Martin Cerveny
2020-09-10 11:09 ` [PATCH 0/2] drm/sun4i: sun8i-csc: Secondary CSC register correction Maxime Ripard
2 siblings, 1 reply; 6+ messages in thread
From: Martin Cerveny @ 2020-09-06 16:21 UTC (permalink / raw)
To: Maxime Ripard
Cc: Martin Cerveny, Chen-Yu Tsai, Daniel Vetter, David Airlie,
dri-devel, Jernej Skrabec, linux-arm-kernel, linux-kernel
"Allwinner V3s" has secondary video layer (VI).
Decoded video is displayed in wrong colors until
secondary CSC registers are programmed correctly.
Signed-off-by: Martin Cerveny <m.cerveny@computer.org>
---
drivers/gpu/drm/sun4i/sun8i_csc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/sun4i/sun8i_csc.h b/drivers/gpu/drm/sun4i/sun8i_csc.h
index f42441b1b14d..a55a38ad849c 100644
--- a/drivers/gpu/drm/sun4i/sun8i_csc.h
+++ b/drivers/gpu/drm/sun4i/sun8i_csc.h
@@ -12,7 +12,7 @@ struct sun8i_mixer;
/* VI channel CSC units offsets */
#define CCSC00_OFFSET 0xAA050
-#define CCSC01_OFFSET 0xFA000
+#define CCSC01_OFFSET 0xFA050
#define CCSC10_OFFSET 0xA0000
#define CCSC11_OFFSET 0xF0000
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] drm/sun4i: sun8i-csc: Secondary CSC register correction
2020-09-06 16:21 ` [PATCH 1/2] " Martin Cerveny
@ 2020-09-08 16:13 ` Jernej Škrabec
0 siblings, 0 replies; 6+ messages in thread
From: Jernej Škrabec @ 2020-09-08 16:13 UTC (permalink / raw)
To: Maxime Ripard, Martin Cerveny
Cc: Martin Cerveny, Chen-Yu Tsai, Daniel Vetter, David Airlie,
dri-devel, linux-arm-kernel, linux-kernel
>"Allwinner V3s" has secondary video layer (VI).
>Decoded video is displayed in wrong colors until
>secondary CSC registers are programmed correctly.
>
>Signed-off-by: Martin Cerveny <m.cerveny@computer.org>
Following tag should be added:
Fixes: 883029390550 ("drm/sun4i: Add DE2 CSC library")
Reviewed-by: Jernej Skrabec <jernej.skrabec@siol.net>
Best regards,
Jernej
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/2] drm/sun4i: mixer: Extend regmap max_register
2020-09-06 16:21 [PATCH 0/2] drm/sun4i: sun8i-csc: Secondary CSC register correction Martin Cerveny
2020-09-06 16:21 ` [PATCH 1/2] " Martin Cerveny
@ 2020-09-06 16:21 ` Martin Cerveny
2020-09-08 16:15 ` Jernej Škrabec
2020-09-10 11:09 ` [PATCH 0/2] drm/sun4i: sun8i-csc: Secondary CSC register correction Maxime Ripard
2 siblings, 1 reply; 6+ messages in thread
From: Martin Cerveny @ 2020-09-06 16:21 UTC (permalink / raw)
To: Maxime Ripard
Cc: Martin Cerveny, Chen-Yu Tsai, Daniel Vetter, David Airlie,
dri-devel, Jernej Skrabec, linux-arm-kernel, linux-kernel
Better guess. Secondary CSC registers are from 0xF0000.
Signed-off-by: Martin Cerveny <m.cerveny@computer.org>
---
drivers/gpu/drm/sun4i/sun8i_mixer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/sun4i/sun8i_mixer.c b/drivers/gpu/drm/sun4i/sun8i_mixer.c
index cc4fb916318f..c3304028e3dc 100644
--- a/drivers/gpu/drm/sun4i/sun8i_mixer.c
+++ b/drivers/gpu/drm/sun4i/sun8i_mixer.c
@@ -307,7 +307,7 @@ static struct regmap_config sun8i_mixer_regmap_config = {
.reg_bits = 32,
.val_bits = 32,
.reg_stride = 4,
- .max_register = 0xbfffc, /* guessed */
+ .max_register = 0xffffc, /* guessed */
};
static int sun8i_mixer_of_get_id(struct device_node *node)
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 0/2] drm/sun4i: sun8i-csc: Secondary CSC register correction
2020-09-06 16:21 [PATCH 0/2] drm/sun4i: sun8i-csc: Secondary CSC register correction Martin Cerveny
2020-09-06 16:21 ` [PATCH 1/2] " Martin Cerveny
2020-09-06 16:21 ` [PATCH 2/2] drm/sun4i: mixer: Extend regmap max_register Martin Cerveny
@ 2020-09-10 11:09 ` Maxime Ripard
2 siblings, 0 replies; 6+ messages in thread
From: Maxime Ripard @ 2020-09-10 11:09 UTC (permalink / raw)
To: Martin Cerveny
Cc: Chen-Yu Tsai, Daniel Vetter, David Airlie, dri-devel,
Jernej Skrabec, linux-arm-kernel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 306 bytes --]
On Sun, Sep 06, 2020 at 06:21:38PM +0200, Martin Cerveny wrote:
> The secondary video layer (VI) on "Allwinner V3s" displays
> decoded video (YUV) in wrong colors. The secondary
> CSC should be programmed.
> Let's correct CSC register offset and extend regmap size.
Applied both, thanks
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-09-10 11:14 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-06 16:21 [PATCH 0/2] drm/sun4i: sun8i-csc: Secondary CSC register correction Martin Cerveny
2020-09-06 16:21 ` [PATCH 1/2] " Martin Cerveny
2020-09-08 16:13 ` Jernej Škrabec
2020-09-06 16:21 ` [PATCH 2/2] drm/sun4i: mixer: Extend regmap max_register Martin Cerveny
2020-09-08 16:15 ` Jernej Škrabec
2020-09-10 11:09 ` [PATCH 0/2] drm/sun4i: sun8i-csc: Secondary CSC register correction Maxime Ripard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).