* [PATCH] ASoC: rt5682: Have global name clock option for parent clk
@ 2020-09-07 4:00 Akshu Agrawal
2020-09-07 11:06 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Akshu Agrawal @ 2020-09-07 4:00 UTC (permalink / raw)
Cc: akshu.agrawal, derek.fang, Oder Chiou, Liam Girdwood, Mark Brown,
Jaroslav Kysela, Takashi Iwai,
moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM...,
open list
When adding parent clk(mclk) to wclk, this adds fallback option
for the case where global clk name is used.
Signed-off-by: Akshu Agrawal <akshu.agrawal@amd.com>
---
sound/soc/codecs/rt5682.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/codecs/rt5682.c b/sound/soc/codecs/rt5682.c
index 93ebf0279b62..26928bc49bcb 100644
--- a/sound/soc/codecs/rt5682.c
+++ b/sound/soc/codecs/rt5682.c
@@ -2780,6 +2780,7 @@ static int rt5682_register_dai_clks(struct snd_soc_component *component)
if (rt5682->mclk) {
init.parent_data = &(struct clk_parent_data){
.fw_name = "mclk",
+ .name = __clk_get_name(rt5682->mclk),
};
init.num_parents = 1;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: rt5682: Have global name clock option for parent clk
2020-09-07 4:00 [PATCH] ASoC: rt5682: Have global name clock option for parent clk Akshu Agrawal
@ 2020-09-07 11:06 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2020-09-07 11:06 UTC (permalink / raw)
To: Akshu Agrawal
Cc: derek.fang, Oder Chiou, Liam Girdwood, Jaroslav Kysela,
Takashi Iwai,
moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM...,
open list
[-- Attachment #1: Type: text/plain, Size: 620 bytes --]
On Mon, Sep 07, 2020 at 09:30:37AM +0530, Akshu Agrawal wrote:
> When adding parent clk(mclk) to wclk, this adds fallback option
> for the case where global clk name is used.
> @@ -2780,6 +2780,7 @@ static int rt5682_register_dai_clks(struct snd_soc_component *component)
> if (rt5682->mclk) {
> init.parent_data = &(struct clk_parent_data){
> .fw_name = "mclk",
> + .name = __clk_get_name(rt5682->mclk),
> };
> init.num_parents = 1;
> }
I don't understand this change - we clearly already have the clock so
why can't we just use whatever we used when we originally looked it up
here?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-07 11:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-07 4:00 [PATCH] ASoC: rt5682: Have global name clock option for parent clk Akshu Agrawal
2020-09-07 11:06 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).