From: Borislav Petkov <bp@alien8.de>
To: Andy Lutomirski <luto@kernel.org>
Cc: x86-ml <x86@kernel.org>, Tony Luck <tony.luck@intel.com>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH] x86/mce: Make mce_rdmsrl() do a plain RDMSR only
Date: Mon, 7 Sep 2020 22:27:37 +0200 [thread overview]
Message-ID: <20200907202737.GF16029@zn.tnic> (raw)
In-Reply-To: <CALCETrV4YN6t3Wqh+u4K=dQkj5RFQ0UbPj3nXXn2iHO+eZm4vA@mail.gmail.com>
On Mon, Sep 07, 2020 at 01:16:43PM -0700, Andy Lutomirski wrote:
> > + asm volatile("rdmsr" : EAX_EDX_RET(val, low, high) : "c" (msr));
>
> I don't like this. Plain rdmsrl() will at least print a nice error if it fails.
I think you read my commit message too quickly :)
The point is to not print anything and not have *any* exception handling
or whatever - just plain RDMSR.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2020-09-07 20:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-06 21:21 [RFC PATCH] x86/mce: Make mce_rdmsrl() do a plain RDMSR only Borislav Petkov
2020-09-07 20:06 ` Luck, Tony
2020-09-08 9:46 ` Borislav Petkov
2020-09-08 10:08 ` Borislav Petkov
2020-09-08 15:07 ` Luck, Tony
2020-09-08 15:25 ` Borislav Petkov
2020-09-09 11:30 ` Borislav Petkov
2020-09-09 18:20 ` Luck, Tony
2020-09-09 20:03 ` Borislav Petkov
2020-09-10 18:29 ` Borislav Petkov
2020-09-10 18:38 ` [PATCH -v2] x86/mce: Make mce_rdmsrl() panic on an inaccessible MSR Borislav Petkov
2020-09-10 18:42 ` [RFC PATCH] x86/mce: Make mce_rdmsrl() do a plain RDMSR only Luck, Tony
2020-09-10 18:54 ` Borislav Petkov
2020-09-10 19:43 ` Luck, Tony
2020-09-07 20:16 ` Andy Lutomirski
2020-09-07 20:27 ` Borislav Petkov [this message]
2020-09-11 9:47 ` [tip: ras/core] x86/mce: Make mce_rdmsrl() panic on an inaccessible MSR tip-bot2 for Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200907202737.GF16029@zn.tnic \
--to=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).