From: "Luck, Tony" <tony.luck@intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: x86-ml <x86@kernel.org>, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH] x86/mce: Make mce_rdmsrl() do a plain RDMSR only
Date: Wed, 9 Sep 2020 11:20:51 -0700 [thread overview]
Message-ID: <20200909182051.GA31883@agluck-desk2.amr.corp.intel.com> (raw)
In-Reply-To: <20200909113022.GA12237@zn.tnic>
On Wed, Sep 09, 2020 at 01:30:22PM +0200, Borislav Petkov wrote:
> I guess something as straightforward as this:
Do we think there will be other places where we want this
MSR-or-die behaviour? If there are, then most of this
belongs elsewhere from arch/x86/kernel/cpu/mce/core.c
> ---
> diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c
> index 0ba24dfffdb2..9893caaf2696 100644
> --- a/arch/x86/kernel/cpu/mce/core.c
> +++ b/arch/x86/kernel/cpu/mce/core.c
> @@ -373,10 +373,27 @@ static int msr_to_offset(u32 msr)
> return -1;
> }
>
> +__visible bool ex_handler_rdmsr_fault(const struct exception_table_entry *fixup,
> + struct pt_regs *regs, int trapnr,
> + unsigned long error_code,
> + unsigned long fault_addr)
> +{
> + if (pr_warn_once("MSR access error: RDMSR from 0x%x at rIP: 0x%lx (%pS)\n",
The "_once" version seems a little pointless when the next statement in the function
is "panic()".
"warn" seems understated for an error that is going to crash the system.
Just go for "pr_emerg()".
There seems no consistency on using "rIP" or "RIP" ... but I think "RIP"
is slightly ahead.
> + (unsigned int)regs->cx, regs->ip, (void *)regs->ip))
> + show_stack_regs(regs);
> +
> + panic("MCA Architectural violation!\n");
nitpick: I don't thing Architectural needs to be capitalized.
> +
> + while (true)
> + cpu_relax();
Ugh. Is this why you have warn_once() ... because panic might return?
Above comments also apply to the wrmsr path.
-Tony
next prev parent reply other threads:[~2020-09-09 18:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-06 21:21 [RFC PATCH] x86/mce: Make mce_rdmsrl() do a plain RDMSR only Borislav Petkov
2020-09-07 20:06 ` Luck, Tony
2020-09-08 9:46 ` Borislav Petkov
2020-09-08 10:08 ` Borislav Petkov
2020-09-08 15:07 ` Luck, Tony
2020-09-08 15:25 ` Borislav Petkov
2020-09-09 11:30 ` Borislav Petkov
2020-09-09 18:20 ` Luck, Tony [this message]
2020-09-09 20:03 ` Borislav Petkov
2020-09-10 18:29 ` Borislav Petkov
2020-09-10 18:38 ` [PATCH -v2] x86/mce: Make mce_rdmsrl() panic on an inaccessible MSR Borislav Petkov
2020-09-10 18:42 ` [RFC PATCH] x86/mce: Make mce_rdmsrl() do a plain RDMSR only Luck, Tony
2020-09-10 18:54 ` Borislav Petkov
2020-09-10 19:43 ` Luck, Tony
2020-09-07 20:16 ` Andy Lutomirski
2020-09-07 20:27 ` Borislav Petkov
2020-09-11 9:47 ` [tip: ras/core] x86/mce: Make mce_rdmsrl() panic on an inaccessible MSR tip-bot2 for Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200909182051.GA31883@agluck-desk2.amr.corp.intel.com \
--to=tony.luck@intel.com \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).