From: Dan Murphy <dmurphy@ti.com>
To: Camel Guo <camel.guo@axis.com>, <lgirdwood@gmail.com>,
<broonie@kernel.org>, <tiwai@suse.com>
Cc: <alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>,
<kernel@axis.com>, Camel Guo <camelg@axis.com>
Subject: Re: [PATCH 1/2] ASoC: tlv320adcx140: Avoid accessing invalid gpio_reset
Date: Tue, 8 Sep 2020 06:55:44 -0500 [thread overview]
Message-ID: <c1036c8f-9ddc-1e02-4668-1dd0d081b6cf@ti.com> (raw)
Message-ID: <20200908115544.qh0mveYhX6wx1AYqFKlji4KWR5nfcnYZQKHjAcZSNEA@z> (raw)
In-Reply-To: <20200908083521.14105-1-camel.guo@axis.com>
Camel
On 9/8/20 3:35 AM, Camel Guo wrote:
> From: Camel Guo <camelg@axis.com>
>
> When gpio_reset is not well defined in devicetree, the
> adcx140->gpio_reset is an error code instead of NULL. In this case,
> adcx140->gpio_reset should not be used by adcx140_reset. This commit
> sets it NULL to avoid accessing an invalid variable.
>
> Signed-off-by: Camel Guo <camelg@axis.com>
> ---
> sound/soc/codecs/tlv320adcx140.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/sound/soc/codecs/tlv320adcx140.c b/sound/soc/codecs/tlv320adcx140.c
> index 7ae6ec374be3..597dd1062943 100644
> --- a/sound/soc/codecs/tlv320adcx140.c
> +++ b/sound/soc/codecs/tlv320adcx140.c
> @@ -984,8 +984,10 @@ static int adcx140_i2c_probe(struct i2c_client *i2c,
>
> adcx140->gpio_reset = devm_gpiod_get_optional(adcx140->dev,
> "reset", GPIOD_OUT_LOW);
> - if (IS_ERR(adcx140->gpio_reset))
> + if (IS_ERR(adcx140->gpio_reset) || adcx140->gpio_reset == NULL) {
This looks a bit off and seems like the NULL check was added just to
print the message.
I would suggest removing the "or" check and just set the gpio_reset to
NULL in an error case.
This avoids noise in the log especially if the gpio_reset is
intentionally not populated in the DT
Dan
next prev parent reply other threads:[~2020-09-08 18:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-08 8:35 [PATCH 1/2] ASoC: tlv320adcx140: Avoid accessing invalid gpio_reset Camel Guo
2020-09-08 8:35 ` [PATCH 2/2] ASoC: tlv320adcx140: Wake up codec before accessing register Camel Guo
2020-09-08 11:49 ` Dan Murphy
2020-09-08 14:58 ` Dan Murphy
2020-09-08 11:55 ` Dan Murphy [this message]
2020-09-08 11:55 ` [PATCH 1/2] ASoC: tlv320adcx140: Avoid accessing invalid gpio_reset Dan Murphy
2020-09-08 11:59 ` Peter Ujfalusi
2020-09-08 12:03 ` Peter Ujfalusi
2020-09-08 12:03 ` Peter Ujfalusi
2020-09-09 10:08 ` Camel Guo
2020-09-08 17:20 ` Mark Brown
2020-09-09 10:06 ` Camel Guo
2020-09-09 11:22 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1036c8f-9ddc-1e02-4668-1dd0d081b6cf@ti.com \
--to=dmurphy@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=camel.guo@axis.com \
--cc=camelg@axis.com \
--cc=kernel@axis.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).