* [PATCH] gpio: mockup: fix resource leak in error path
@ 2020-09-08 13:07 Bartosz Golaszewski
2020-09-08 13:45 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Bartosz Golaszewski @ 2020-09-08 13:07 UTC (permalink / raw)
To: Linus Walleij, Andy Shevchenko, Kent Gibson
Cc: linux-gpio, linux-kernel, Bartosz Golaszewski, stable
From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
If the module init function fails after creating the debugs directory,
it's never removed. Add proper cleanup calls to avoid this resource
leak.
Fixes: 9202ba2397d1 ("gpio: mockup: implement event injecting over debugfs")
Cc: <stable@vger.kernel.org>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
drivers/gpio/gpio-mockup.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpio/gpio-mockup.c b/drivers/gpio/gpio-mockup.c
index bc345185db26..1652897fdf90 100644
--- a/drivers/gpio/gpio-mockup.c
+++ b/drivers/gpio/gpio-mockup.c
@@ -552,6 +552,7 @@ static int __init gpio_mockup_init(void)
err = platform_driver_register(&gpio_mockup_driver);
if (err) {
gpio_mockup_err("error registering platform driver\n");
+ debugfs_remove_recursive(gpio_mockup_dbg_dir);
return err;
}
@@ -582,6 +583,7 @@ static int __init gpio_mockup_init(void)
gpio_mockup_err("error registering device");
platform_driver_unregister(&gpio_mockup_driver);
gpio_mockup_unregister_pdevs();
+ debugfs_remove_recursive(gpio_mockup_dbg_dir);
return PTR_ERR(pdev);
}
--
2.26.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: mockup: fix resource leak in error path
2020-09-08 13:07 [PATCH] gpio: mockup: fix resource leak in error path Bartosz Golaszewski
@ 2020-09-08 13:45 ` Andy Shevchenko
2020-09-09 11:08 ` Bartosz Golaszewski
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2020-09-08 13:45 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: Linus Walleij, Kent Gibson, linux-gpio, linux-kernel,
Bartosz Golaszewski, stable
On Tue, Sep 08, 2020 at 03:07:49PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> If the module init function fails after creating the debugs directory,
> it's never removed. Add proper cleanup calls to avoid this resource
> leak.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Fixes: 9202ba2397d1 ("gpio: mockup: implement event injecting over debugfs")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> ---
> drivers/gpio/gpio-mockup.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpio/gpio-mockup.c b/drivers/gpio/gpio-mockup.c
> index bc345185db26..1652897fdf90 100644
> --- a/drivers/gpio/gpio-mockup.c
> +++ b/drivers/gpio/gpio-mockup.c
> @@ -552,6 +552,7 @@ static int __init gpio_mockup_init(void)
> err = platform_driver_register(&gpio_mockup_driver);
> if (err) {
> gpio_mockup_err("error registering platform driver\n");
> + debugfs_remove_recursive(gpio_mockup_dbg_dir);
> return err;
> }
>
> @@ -582,6 +583,7 @@ static int __init gpio_mockup_init(void)
> gpio_mockup_err("error registering device");
> platform_driver_unregister(&gpio_mockup_driver);
> gpio_mockup_unregister_pdevs();
> + debugfs_remove_recursive(gpio_mockup_dbg_dir);
> return PTR_ERR(pdev);
> }
>
> --
> 2.26.1
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: mockup: fix resource leak in error path
2020-09-08 13:45 ` Andy Shevchenko
@ 2020-09-09 11:08 ` Bartosz Golaszewski
0 siblings, 0 replies; 3+ messages in thread
From: Bartosz Golaszewski @ 2020-09-09 11:08 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Linus Walleij, Kent Gibson, open list:GPIO SUBSYSTEM,
Linux Kernel Mailing List, Bartosz Golaszewski, stable
On Tue, Sep 8, 2020 at 3:45 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> On Tue, Sep 08, 2020 at 03:07:49PM +0200, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> >
> > If the module init function fails after creating the debugs directory,
> > it's never removed. Add proper cleanup calls to avoid this resource
> > leak.
>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Thanks. This is uncontroversial so I queued right away for fixes.
Bartosz
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-09 11:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-08 13:07 [PATCH] gpio: mockup: fix resource leak in error path Bartosz Golaszewski
2020-09-08 13:45 ` Andy Shevchenko
2020-09-09 11:08 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).