From: Pavel Machek <pavel@ucw.cz>
To: Dan Murphy <dmurphy@ti.com>
Cc: Gene Chen <gene.chen.richtek@gmail.com>,
jacek.anaszewski@gmail.com, matthias.bgg@gmail.com,
linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
gene_chen@richtek.com, Wilma.Wu@mediatek.com,
shufan_lee@richtek.com, cy_huang@richtek.com,
benjamin.chao@mediatek.com
Subject: Re: [PATCH 1/2] leds: mt6360: Add LED driver for MT6360
Date: Wed, 9 Sep 2020 10:46:43 +0200 [thread overview]
Message-ID: <20200909084643.GB10891@amd> (raw)
In-Reply-To: <1b6e8bf7-fc11-542b-f570-cebb0b6c3442@ti.com>
[-- Attachment #1: Type: text/plain, Size: 840 bytes --]
Hi!
>
> >@@ -271,6 +271,17 @@ config LEDS_MT6323
> > This option enables support for on-chip LED drivers found on
> > Mediatek MT6323 PMIC.
...522 lines...
> >+static int mt6360_init_isnk_properties(struct mt6360_led *led, struct led_init_data *init_data)
> >+{
> >+ struct led_classdev *isnk = &led->isnk;
> >+
> >+ isnk->max_brightness = mt6360_get_isnk_max_level(led->led_no);
> This function is called once seems a bit much to have a service function for
> a simple switch case.
Please remove code you are not commenting on. That a) reduces
bandwidth requirements but more importantly b) makes it easier to find
your comments.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2020-09-09 8:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-26 11:37 [PATCH 0/2] leds: mt6360: Add LED driver for MT6360 Gene Chen
2020-08-26 11:37 ` [PATCH 1/2] " Gene Chen
2020-08-26 11:52 ` Dan Murphy
2020-09-09 8:46 ` Pavel Machek [this message]
2020-08-26 15:30 ` Randy Dunlap
2020-09-01 12:29 ` Gene Chen
2020-08-26 11:37 ` [PATCH 2/2] dt-bindings: leds: Add bindings for MT6360 LED Gene Chen
2020-08-26 11:54 ` Dan Murphy
2020-09-01 3:42 ` Gene Chen
2020-08-27 21:32 ` [PATCH 0/2] leds: mt6360: Add LED driver for MT6360 Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200909084643.GB10891@amd \
--to=pavel@ucw.cz \
--cc=Wilma.Wu@mediatek.com \
--cc=benjamin.chao@mediatek.com \
--cc=cy_huang@richtek.com \
--cc=dmurphy@ti.com \
--cc=gene.chen.richtek@gmail.com \
--cc=gene_chen@richtek.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=shufan_lee@richtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).