* [PATCH] drm/imx/dcss: fix 64-bit divisions
@ 2020-09-11 13:48 Laurentiu Palcu
2020-09-11 13:56 ` Ville Syrjälä
0 siblings, 1 reply; 2+ messages in thread
From: Laurentiu Palcu @ 2020-09-11 13:48 UTC (permalink / raw)
To: Lucas Stach, Philipp Zabel, David Airlie, Daniel Vetter,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team
Cc: laurentiu.palcu, dri-devel, linux-arm-kernel, linux-kernel
Use div_s64() for the 64-bit divisions. This would allow the driver to compile
on 32-bit architectures, if needed.
Signed-off-by: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>
---
drivers/gpu/drm/imx/dcss/dcss-scaler.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/imx/dcss/dcss-scaler.c b/drivers/gpu/drm/imx/dcss/dcss-scaler.c
index cd21905de580..7c1e0e461244 100644
--- a/drivers/gpu/drm/imx/dcss/dcss-scaler.c
+++ b/drivers/gpu/drm/imx/dcss/dcss-scaler.c
@@ -134,7 +134,7 @@ static int div_q(int A, int B)
else
temp -= B / 2;
- result = (int)(temp / B);
+ result = (int)(div_s64(temp, B));
return result;
}
@@ -237,7 +237,7 @@ static void dcss_scaler_gaussian_filter(int fc_q, bool use_5_taps,
ll_temp = coef[phase][i];
ll_temp <<= PSC_COEFF_PRECISION;
ll_temp += sum >> 1;
- ll_temp /= sum;
+ ll_temp = div_s64(ll_temp, sum);
coef[phase][i] = (int)ll_temp;
}
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/imx/dcss: fix 64-bit divisions
2020-09-11 13:48 [PATCH] drm/imx/dcss: fix 64-bit divisions Laurentiu Palcu
@ 2020-09-11 13:56 ` Ville Syrjälä
0 siblings, 0 replies; 2+ messages in thread
From: Ville Syrjälä @ 2020-09-11 13:56 UTC (permalink / raw)
To: Laurentiu Palcu
Cc: Lucas Stach, Philipp Zabel, David Airlie, Daniel Vetter,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, linux-kernel, linux-arm-kernel, dri-devel
On Fri, Sep 11, 2020 at 04:48:27PM +0300, Laurentiu Palcu wrote:
> Use div_s64() for the 64-bit divisions. This would allow the driver to compile
> on 32-bit architectures, if needed.
>
> Signed-off-by: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>
> ---
> drivers/gpu/drm/imx/dcss/dcss-scaler.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/imx/dcss/dcss-scaler.c b/drivers/gpu/drm/imx/dcss/dcss-scaler.c
> index cd21905de580..7c1e0e461244 100644
> --- a/drivers/gpu/drm/imx/dcss/dcss-scaler.c
> +++ b/drivers/gpu/drm/imx/dcss/dcss-scaler.c
> @@ -134,7 +134,7 @@ static int div_q(int A, int B)
> else
> temp -= B / 2;
>
> - result = (int)(temp / B);
> + result = (int)(div_s64(temp, B));
> return result;
> }
>
> @@ -237,7 +237,7 @@ static void dcss_scaler_gaussian_filter(int fc_q, bool use_5_taps,
> ll_temp = coef[phase][i];
> ll_temp <<= PSC_COEFF_PRECISION;
> ll_temp += sum >> 1;
> - ll_temp /= sum;
That looks like hand rolled DIV_ROUND_CLOSEST_ULL()
> + ll_temp = div_s64(ll_temp, sum);
> coef[phase][i] = (int)ll_temp;
> }
> }
> --
> 2.17.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-11 16:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-11 13:48 [PATCH] drm/imx/dcss: fix 64-bit divisions Laurentiu Palcu
2020-09-11 13:56 ` Ville Syrjälä
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).