From: Wolfram Sang <wsa@kernel.org>
To: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
Cc: Evan Nimmo <Evan.Nimmo@alliedtelesis.co.nz>,
"andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>,
"jarkko.nikula@linux.intel.com" <jarkko.nikula@linux.intel.com>,
"jdelvare@suse.de" <jdelvare@suse.de>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 1/1] i2c: algo-pca: Reapply i2c bus settings after reset
Date: Fri, 11 Sep 2020 21:45:26 +0200 [thread overview]
Message-ID: <20200911194526.GB909@ninjato> (raw)
In-Reply-To: <5410e288-e369-0310-1b8e-061c95e46164@alliedtelesis.co.nz>
[-- Attachment #1: Type: text/plain, Size: 1227 bytes --]
On Wed, Sep 09, 2020 at 08:39:50PM +0000, Chris Packham wrote:
>
> On 9/09/20 8:23 pm, Wolfram Sang wrote:
> > On Wed, Sep 09, 2020 at 08:32:47AM +1200, Evan Nimmo wrote:
> >> If something goes wrong (such as the SCL being stuck low) then we need
> >> to reset the PCA chip. The issue with this is that on reset we lose all
> >> config settings and the chip ends up in a disabled state which results
> >> in a lock up/high CPU usage. We need to re-apply any configuration that
> >> had previously been set and re-enable the chip.
> >>
> >> Signed-off-by: Evan Nimmo <evan.nimmo@alliedtelesis.co.nz>
> >> Reviewed-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> >> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> >> Reviewed-by: Wolfram Sang <wsa@kernel.org>
> > Applied to for-current, thanks!
> >
> > For the record, were you able to test both, PCA9564 and PCA9665?
> >
> Our hardware platforms only have PCA9665 so that's all we can test.
Okay, good to know. BTW, just after I sent out my pull request
containing this patch, I noticed there is no Fixes: tag. So, if you want
this patch to be backported, please send it to stable@ once my
pull-request is in Linus' tree.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-09-11 19:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-08 20:32 [PATCH v4 1/1] i2c: algo-pca: Reapply i2c bus settings after reset Evan Nimmo
2020-09-09 8:23 ` Wolfram Sang
2020-09-09 20:39 ` Chris Packham
2020-09-11 19:45 ` Wolfram Sang [this message]
2020-09-13 21:23 ` Chris Packham
2020-09-14 6:49 ` Wolfram Sang
2020-09-14 20:50 ` Chris Packham
2020-09-14 8:50 ` Andy Shevchenko
2020-09-14 8:51 ` Andy Shevchenko
2020-09-14 10:42 ` Stephen Rothwell
2020-09-14 11:01 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200911194526.GB909@ninjato \
--to=wsa@kernel.org \
--cc=Chris.Packham@alliedtelesis.co.nz \
--cc=Evan.Nimmo@alliedtelesis.co.nz \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=jdelvare@suse.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).