From: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
To: Wolfram Sang <wsa@kernel.org>
Cc: Evan Nimmo <Evan.Nimmo@alliedtelesis.co.nz>,
"andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>,
"jarkko.nikula@linux.intel.com" <jarkko.nikula@linux.intel.com>,
"jdelvare@suse.de" <jdelvare@suse.de>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 1/1] i2c: algo-pca: Reapply i2c bus settings after reset
Date: Sun, 13 Sep 2020 21:23:07 +0000 [thread overview]
Message-ID: <61c139a0-26fc-8cd1-0b54-b7cb9d9c0648@alliedtelesis.co.nz> (raw)
In-Reply-To: <20200911194526.GB909@ninjato>
On 12/09/20 7:45 am, Wolfram Sang wrote:
> On Wed, Sep 09, 2020 at 08:39:50PM +0000, Chris Packham wrote:
>> On 9/09/20 8:23 pm, Wolfram Sang wrote:
>>> On Wed, Sep 09, 2020 at 08:32:47AM +1200, Evan Nimmo wrote:
>>>> If something goes wrong (such as the SCL being stuck low) then we need
>>>> to reset the PCA chip. The issue with this is that on reset we lose all
>>>> config settings and the chip ends up in a disabled state which results
>>>> in a lock up/high CPU usage. We need to re-apply any configuration that
>>>> had previously been set and re-enable the chip.
>>>>
>>>> Signed-off-by: Evan Nimmo <evan.nimmo@alliedtelesis.co.nz>
>>>> Reviewed-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
>>>> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>>>> Reviewed-by: Wolfram Sang <wsa@kernel.org>
>>> Applied to for-current, thanks!
>>>
>>> For the record, were you able to test both, PCA9564 and PCA9665?
>>>
>> Our hardware platforms only have PCA9665 so that's all we can test.
> Okay, good to know. BTW, just after I sent out my pull request
> containing this patch, I noticed there is no Fixes: tag. So, if you want
> this patch to be backported, please send it to stable@ once my
> pull-request is in Linus' tree.
For our purposes being in Linus's tree is good enough. We've already
back-ported it to our kernel fork (which doesn't really track any of the
stable branches properly).
I'm happy to route it to stable@ if you think it's worth it but I don't
think there's a specific Fixes: reference that can be used. The current
behavior appears to have been that way since before git (looks like we
noticed in 2014 but it's taken me 6 years to nag people into sending
their fixes upstream).
next prev parent reply other threads:[~2020-09-13 21:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-08 20:32 [PATCH v4 1/1] i2c: algo-pca: Reapply i2c bus settings after reset Evan Nimmo
2020-09-09 8:23 ` Wolfram Sang
2020-09-09 20:39 ` Chris Packham
2020-09-11 19:45 ` Wolfram Sang
2020-09-13 21:23 ` Chris Packham [this message]
2020-09-14 6:49 ` Wolfram Sang
2020-09-14 20:50 ` Chris Packham
2020-09-14 8:50 ` Andy Shevchenko
2020-09-14 8:51 ` Andy Shevchenko
2020-09-14 10:42 ` Stephen Rothwell
2020-09-14 11:01 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61c139a0-26fc-8cd1-0b54-b7cb9d9c0648@alliedtelesis.co.nz \
--to=chris.packham@alliedtelesis.co.nz \
--cc=Evan.Nimmo@alliedtelesis.co.nz \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=jdelvare@suse.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).