linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Qiang Zhao <qiang.zhao@nxp.com>
Cc: a.zummo@towertech.it, robh+dt@kernel.org,
	linux-rtc@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: rtc-2127: Add bindings for nxp,rtc-2127.txt
Date: Fri, 11 Sep 2020 23:34:10 +0200	[thread overview]
Message-ID: <20200911213410.GB7446@piout.net> (raw)
In-Reply-To: <20200827091441.12972-1-qiang.zhao@nxp.com>

Hi,

The correct subject prefix is dt-bindings: rtc: pcf2127

On 27/08/2020 17:14:39+0800, Qiang Zhao wrote:
> From: Zhao Qiang <qiang.zhao@nxp.com>
> 
> Add bindings for nxp,rtc-2127
> 
> Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
> ---
>  Documentation/devicetree/bindings/rtc/nxp,rtc-2127.txt | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/rtc/nxp,rtc-2127.txt
> 
> diff --git a/Documentation/devicetree/bindings/rtc/nxp,rtc-2127.txt b/Documentation/devicetree/bindings/rtc/nxp,rtc-2127.txt
> new file mode 100644
> index 0000000..c822e10
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/nxp,rtc-2127.txt

The proper filename is nxp,pcf2127.

> @@ -0,0 +1,18 @@
> +NXP PCF2127 SPI Real Time Clock
> +
> +Required properties:
> +- compatible: should be: "nxp,pcf2127"
> +                      or "nxp,pcf2129"
> +- reg: should be the SPI slave chipselect address
> +
> +Optional properties:
> +- no-watchdog: PCF2127 is not used as watchdog
> +

Please Cc the watchdog maintainers as this should probably end up being
a common watchdog binding.

> +Example:
> +
> +pcf2127: rtc@51 {
> +	compatible = "nxp,pcf2127";
> +	reg = <0x51>;
> +	interrupts = <0 150 0x4>;
> +	no-watchdog;
> +};
> -- 
> 2.7.4
> 

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

      parent reply	other threads:[~2020-09-11 21:34 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-27  9:14 [PATCH 1/3] dt-bindings: rtc-2127: Add bindings for nxp,rtc-2127.txt Qiang Zhao
2020-08-27  9:14 ` [PATCH 2/3] rtc: pcf2127: add "no-watchdog" property Qiang Zhao
2020-08-27  9:14 ` [PATCH 3/3] arm64: dts: lx2160a: Add "no-watchdog" property to pcf2127 Qiang Zhao
2020-09-09 20:24 ` [PATCH 1/3] dt-bindings: rtc-2127: Add bindings for nxp,rtc-2127.txt Rob Herring
2020-09-10  3:16   ` Qiang Zhao
2020-09-11 14:03     ` Rob Herring
2020-09-14  7:08       ` Qiang Zhao
2020-09-14 14:36         ` Rob Herring
2020-09-15  3:26           ` Qiang Zhao
2020-09-17 19:29         ` Bruno Thomsen
2020-09-18  1:45           ` Qiang Zhao
2020-09-11 21:34 ` Alexandre Belloni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200911213410.GB7446@piout.net \
    --to=alexandre.belloni@bootlin.com \
    --cc=a.zummo@towertech.it \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=qiang.zhao@nxp.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).