From: Qiang Zhao <qiang.zhao@nxp.com>
To: Bruno Thomsen <bruno.thomsen@gmail.com>
Cc: Rob Herring <robh@kernel.org>,
"a.zummo@towertech.it" <a.zummo@towertech.it>,
"alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>,
"linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 1/3] dt-bindings: rtc-2127: Add bindings for nxp,rtc-2127.txt
Date: Fri, 18 Sep 2020 01:45:17 +0000 [thread overview]
Message-ID: <VE1PR04MB6768BFBAED0B5B59D873DD70913F0@VE1PR04MB6768.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <CAH+2xPAVhivJJ4DGZ+79kyeiLN-f93xMBbMEXTVUN-rrm4hawQ@mail.gmail.com>
On Fri, Sep 18, 2020 at 03:29, Bruno Thomsen <bruno.thomsen@gmail.com> wrote:
> -----Original Message-----
> From: Bruno Thomsen <bruno.thomsen@gmail.com>
> Sent: 2020年9月18日 3:29
> To: Qiang Zhao <qiang.zhao@nxp.com>
> Cc: Rob Herring <robh@kernel.org>; a.zummo@towertech.it;
> alexandre.belloni@bootlin.com; linux-rtc@vger.kernel.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH 1/3] dt-bindings: rtc-2127: Add bindings for
> nxp,rtc-2127.txt
>
> Den man. 14. sep. 2020 kl. 09.08 skrev Qiang Zhao <qiang.zhao@nxp.com>:
> >
> > On Fri, Sep 11, 2020 at 22:03, Rob Herring <robh@kernel.org> wrote:
>
> > Please help to review as below, if it is ok, I will send the new version patch.
> Thank you!
> >
> > diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> > b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> > new file mode 100644
> > index 0000000..809dd59
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> > @@ -0,0 +1,38 @@
> > +# SPDX-License-Identifier: GPL-2.0
> > +%YAML 1.2
> > +---
> > +$id:
> > +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi
> >
> +cetree.org%2Fschemas%2Frtc%2Fnxp%2Cpcf2127.yaml%23&data=02%7
> C01%7
> >
> +Cqiang.zhao%40nxp.com%7C5a271aa3d1ed46ea578108d85b3ff9f6%7C686e
> a1d3bc
> >
> +2b4c6fa92cd99c5c301635%7C0%7C0%7C637359677624002617&sdata
> =UGZ9B6E
> > +xteIMvxc3zvPfr%2FjZVQuPD6DJ6b2kZ%2BOO%2BIA%3D&reserved=0
> > +$schema:
> > +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi
> >
> +cetree.org%2Fmeta-schemas%2Fcore.yaml%23&data=02%7C01%7Cqiang
> .zha
> >
> +o%40nxp.com%7C5a271aa3d1ed46ea578108d85b3ff9f6%7C686ea1d3bc2b4
> c6fa92c
> >
> +d99c5c301635%7C0%7C0%7C637359677624002617&sdata=7P2m9OvIs
> FS6Q2By9
> > +DNmK9Oq5Ff6B%2BNSEA4F7otTT8g%3D&reserved=0
> > +
> > +title: PCF RTCs
> > +
> > +maintainers:
> > + - Qiang Zhao <qiang.zhao@nxp.com>
> > +
> > +allOf:
> > + - $ref: "rtc.yaml#"
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - nxp,pcf2127
> > + - nxp,pcf2129
>
> The device driver have 3 compatible strings, "nxp,pca2129" is missing.
Thank you for your reminder, I will add in next version.
>
> /Bruno
>
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + interrupts:
> > + maxItems: 1
> > +
> > + no-watchdog:
> > + maxItems: 1
> > +
> > + start-year: true
> > +
> > +required:
> > + - compatible
> > + - reg
> > +
> > +additionalProperties: false
> > +
> > +...
> >
> > >
> > > Documentation/devicetree/writing-schema.rst and about 1000 examples
> > > in the kernel tree.
> > >
> > > Rob
Best Regards
Qiang Zhao
next prev parent reply other threads:[~2020-09-18 1:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 9:14 [PATCH 1/3] dt-bindings: rtc-2127: Add bindings for nxp,rtc-2127.txt Qiang Zhao
2020-08-27 9:14 ` [PATCH 2/3] rtc: pcf2127: add "no-watchdog" property Qiang Zhao
2020-08-27 9:14 ` [PATCH 3/3] arm64: dts: lx2160a: Add "no-watchdog" property to pcf2127 Qiang Zhao
2020-09-09 20:24 ` [PATCH 1/3] dt-bindings: rtc-2127: Add bindings for nxp,rtc-2127.txt Rob Herring
2020-09-10 3:16 ` Qiang Zhao
2020-09-11 14:03 ` Rob Herring
2020-09-14 7:08 ` Qiang Zhao
2020-09-14 14:36 ` Rob Herring
2020-09-15 3:26 ` Qiang Zhao
2020-09-17 19:29 ` Bruno Thomsen
2020-09-18 1:45 ` Qiang Zhao [this message]
2020-09-11 21:34 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VE1PR04MB6768BFBAED0B5B59D873DD70913F0@VE1PR04MB6768.eurprd04.prod.outlook.com \
--to=qiang.zhao@nxp.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=bruno.thomsen@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).