* [PATCH v2] pinctrl: single: check pinctrl_spec.args_count > 3
@ 2020-09-13 23:15 Drew Fustini
2020-09-23 6:55 ` Tony Lindgren
0 siblings, 1 reply; 2+ messages in thread
From: Drew Fustini @ 2020-09-13 23:15 UTC (permalink / raw)
To: linux-arm-kernel, Tony Lindgren, Rob Herring, linux-omap,
linux-kernel, linux-gpio, Linus Walleij, Haojian Zhuang,
devicetree, bcousson, Jason Kridner, Robert Nelson, Trent Piepho
Cc: Drew Fustini
pinctrl_spec.args_count can either be 2 when #pinctrl-cells = 1 or
3 when #pinctrl-cells = 2.
There is currently only a check to make sure that it is 2 or greater.
This patch adds a check to make sure it is not greater than 3.
Fixes: a13395418888 ("pinctrl: single: parse #pinctrl-cells = 2")
Reported-by: Trent Piepho <tpiepho@gmail.com>
Link: https://lore.kernel.org/linux-omap/3139716.CMS8C0sQ7x@zen.local/
Signed-off-by: Drew Fustini <drew@beagleboard.org>
---
v2 change:
- this is a fix to my prior email where I referred to #pinctrl-cells
exceeding 3 which is incorrect. It is pinctrl_spec.args_count which
must be greater than 2 (when #pinctrl-cells = 1) and less than 3 (when
#pinctrl-cells = 2)
https://lore.kernel.org/linux-omap/20200913210825.2022552-1-drew@beagleboard.org/
drivers/pinctrl/pinctrl-single.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c
index efe41abc5d47..5cbf0e55087c 100644
--- a/drivers/pinctrl/pinctrl-single.c
+++ b/drivers/pinctrl/pinctrl-single.c
@@ -1014,7 +1014,7 @@ static int pcs_parse_one_pinctrl_entry(struct pcs_device *pcs,
if (res)
return res;
- if (pinctrl_spec.args_count < 2) {
+ if (pinctrl_spec.args_count < 2 || pinctrl_spec.args_count > 3) {
dev_err(pcs->dev, "invalid args_count for spec: %i\n",
pinctrl_spec.args_count);
break;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] pinctrl: single: check pinctrl_spec.args_count > 3
2020-09-13 23:15 [PATCH v2] pinctrl: single: check pinctrl_spec.args_count > 3 Drew Fustini
@ 2020-09-23 6:55 ` Tony Lindgren
0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2020-09-23 6:55 UTC (permalink / raw)
To: Drew Fustini
Cc: linux-arm-kernel, Rob Herring, linux-omap, linux-kernel,
linux-gpio, Linus Walleij, Haojian Zhuang, devicetree, bcousson,
Jason Kridner, Robert Nelson, Trent Piepho
* Drew Fustini <drew@beagleboard.org> [200913 23:18]:
> pinctrl_spec.args_count can either be 2 when #pinctrl-cells = 1 or
> 3 when #pinctrl-cells = 2.
>
> There is currently only a check to make sure that it is 2 or greater.
> This patch adds a check to make sure it is not greater than 3.
>
> Fixes: a13395418888 ("pinctrl: single: parse #pinctrl-cells = 2")
> Reported-by: Trent Piepho <tpiepho@gmail.com>
> Link: https://lore.kernel.org/linux-omap/3139716.CMS8C0sQ7x@zen.local/
> Signed-off-by: Drew Fustini <drew@beagleboard.org>
> ---
> v2 change:
> - this is a fix to my prior email where I referred to #pinctrl-cells
> exceeding 3 which is incorrect. It is pinctrl_spec.args_count which
> must be greater than 2 (when #pinctrl-cells = 1) and less than 3 (when
> #pinctrl-cells = 2)
Acked-by: Tony Lindgren <tony@atomide.com>
> https://lore.kernel.org/linux-omap/20200913210825.2022552-1-drew@beagleboard.org/
>
>
> drivers/pinctrl/pinctrl-single.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c
> index efe41abc5d47..5cbf0e55087c 100644
> --- a/drivers/pinctrl/pinctrl-single.c
> +++ b/drivers/pinctrl/pinctrl-single.c
> @@ -1014,7 +1014,7 @@ static int pcs_parse_one_pinctrl_entry(struct pcs_device *pcs,
> if (res)
> return res;
>
> - if (pinctrl_spec.args_count < 2) {
> + if (pinctrl_spec.args_count < 2 || pinctrl_spec.args_count > 3) {
> dev_err(pcs->dev, "invalid args_count for spec: %i\n",
> pinctrl_spec.args_count);
> break;
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-23 6:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-13 23:15 [PATCH v2] pinctrl: single: check pinctrl_spec.args_count > 3 Drew Fustini
2020-09-23 6:55 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).