From: Tingwei Zhang <tingweiz@codeaurora.org>
To: Suzuki K Poulose <suzuki.poulose@arm.com>
Cc: tingwei@codeaurora.org, mathieu.poirier@linaro.org,
alexander.shishkin@linux.intel.com, mike.leach@linaro.org,
tsoni@codeaurora.org, saiprakash.ranjan@codeaurora.org,
kim.phillips@arm.com, jinlmao@codeaurora.org,
gregkh@linuxfoundation.org, coresight@lists.linaro.org,
rdunlap@infradead.org, ykaukab@suse.de, linux@armlinux.org.uk,
linux-kernel@vger.kernel.org, leo.yan@linaro.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v10 09/24] coresight: etm3x: allow etm3x to be built as a module
Date: Mon, 14 Sep 2020 10:19:28 +0800 [thread overview]
Message-ID: <20200914021927.GB22686@codeaurora.org> (raw)
In-Reply-To: <0c2abd02-4fe6-5eaa-e9d3-41811f062ac1@arm.com>
On Sun, Sep 13, 2020 at 09:17:05PM +0800, Suzuki K Poulose wrote:
> On 08/21/2020 04:44 AM, Tingwei Zhang wrote:
> >From: Kim Phillips <kim.phillips@arm.com>
> >
> >Allow to build coresight-etm3x as a module, for ease of development.
> >
> >- Kconfig becomes a tristate, to allow =m
> >- append -core to source file name to allow module to
> > be called coresight-etm3x by the Makefile
> >- add an etm_remove function, for module unload
> >- add a MODULE_DEVICE_TABLE for autoloading on boot
> >
> >Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
> >Cc: Leo Yan <leo.yan@linaro.org>
> >Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
> >Cc: Randy Dunlap <rdunlap@infradead.org>
> >Cc: Suzuki K Poulose <Suzuki.Poulose@arm.com>
> >Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >Cc: Russell King <linux@armlinux.org.uk>
> >Signed-off-by: Kim Phillips <kim.phillips@arm.com>
> >Signed-off-by: Tingwei Zhang <tingwei@codeaurora.org>
> >Reviewed-by: Mike Leach <mike.leach@linaro.org>
>
>
> >diff --git a/drivers/hwtracing/coresight/coresight-etm3x.c
> b/drivers/hwtracing/coresight/coresight-etm3x-core.c
> >similarity index 97%
> >rename from drivers/hwtracing/coresight/coresight-etm3x.c
> >rename to drivers/hwtracing/coresight/coresight-etm3x-core.c
> >index bf22dcfd3327..ba9c86497acb 100644
> >--- a/drivers/hwtracing/coresight/coresight-etm3x.c
> >+++ b/drivers/hwtracing/coresight/coresight-etm3x-core.c
> >@@ -895,6 +895,23 @@ static int etm_probe(struct amba_device *adev,
> const struct amba_id *id)
> > return ret;
> > }
> >+static int __exit etm_remove(struct amba_device *adev)
> >+{
> >+ struct etm_drvdata *drvdata = dev_get_drvdata(&adev->dev);
> >+
> >+ etm_perf_symlink(drvdata->csdev, false);
> >+
> >+ if (--etm_count == 0) {
> >+
> cpuhp_remove_state_nocalls(CPUHP_AP_ARM_CORESIGHT_STARTING);
> >+ if (hp_online)
> >+ cpuhp_remove_state_nocalls(hp_online);
> >+ }
> >+
> >+ coresight_unregister(drvdata->csdev);
> >+
> >+ return 0;
> >+}
> >+
>
> Don't we need to fix the races like we did for ETMv4 ?
>
> Suzuki
>
Yes, we need that. Unfortunately, I don't have ETMv3 devie to verify the
change. Mathieu has been very kind to offer his help to take care of
ETMv3.
Thanks,
Tingwei
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-14 2:21 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-21 3:44 [PATCH v10 00/24] coresight: allow to build coresight as modules Tingwei Zhang
2020-08-21 3:44 ` [PATCH v10 01/24] coresight: cpu_debug: add module name in Kconfig Tingwei Zhang
2020-08-21 3:44 ` [PATCH v10 02/24] coresight: cpu_debug: define MODULE_DEVICE_TABLE Tingwei Zhang
2020-08-21 3:44 ` [PATCH v10 03/24] coresight: use IS_ENABLED for CONFIGs that may be modules Tingwei Zhang
2020-08-21 3:44 ` [PATCH v10 04/24] coresight: add coresight prefix to barrier_pkt Tingwei Zhang
2020-09-10 22:19 ` Mathieu Poirier
2020-09-11 2:39 ` Tingwei Zhang
2020-08-21 3:44 ` [PATCH v10 05/24] coresight: export global symbols Tingwei Zhang
2020-08-21 3:44 ` [PATCH v10 06/24] coresight: add try_get_module() in coresight_grab_device() Tingwei Zhang
2020-08-21 3:44 ` [PATCH v10 07/24] coresight: stm: allow to build coresight-stm as a module Tingwei Zhang
2020-08-21 3:44 ` [PATCH v10 08/24] coresight: etm: perf: Fix warning caused by etm_setup_aux failure Tingwei Zhang
2020-09-10 22:28 ` Mathieu Poirier
2020-09-11 2:49 ` Tingwei Zhang
2020-08-21 3:44 ` [PATCH v10 09/24] coresight: etm3x: allow etm3x to be built as a module Tingwei Zhang
2020-09-13 13:17 ` Suzuki K Poulose
2020-09-14 2:19 ` Tingwei Zhang [this message]
2020-09-14 15:45 ` Mathieu Poirier
2020-09-14 18:11 ` Mathieu Poirier
2020-08-21 3:44 ` [PATCH v10 10/24] coresight: etm4x: allow etm4x " Tingwei Zhang
2020-08-21 9:10 ` Sai Prakash Ranjan
2020-09-13 13:18 ` Suzuki K Poulose
2020-08-21 3:44 ` [PATCH v10 11/24] coresight: etb: allow etb " Tingwei Zhang
2020-08-21 3:44 ` [PATCH v10 12/24] coresight: tpiu: allow tpiu " Tingwei Zhang
2020-08-21 3:44 ` [PATCH v10 13/24] coresight: tmc: allow tmc " Tingwei Zhang
2020-08-21 9:09 ` Sai Prakash Ranjan
2020-08-21 3:44 ` [PATCH v10 14/24] coresight: allow funnel driver to be built as module Tingwei Zhang
2020-08-21 9:09 ` Sai Prakash Ranjan
2020-09-13 13:20 ` Suzuki K Poulose
2020-09-13 13:24 ` Suzuki K Poulose
2020-09-14 2:17 ` Tingwei Zhang
2020-08-21 3:44 ` [PATCH v10 15/24] coresight: allow replicator " Tingwei Zhang
2020-08-21 9:08 ` Sai Prakash Ranjan
2020-09-10 23:00 ` Mathieu Poirier
2020-08-21 3:44 ` [PATCH v10 16/24] coresight: cti: add function to register cti associate ops Tingwei Zhang
2020-08-21 3:44 ` [PATCH v10 17/24] coresight: cti: Fix remove sysfs link error Tingwei Zhang
2020-08-21 3:44 ` [PATCH v10 18/24] coresight: cti: Fix bug clearing sysfs links on callback Tingwei Zhang
2020-09-10 23:00 ` Mathieu Poirier
2020-08-21 3:44 ` [PATCH v10 19/24] coresight: cti: don't disable ect device if it's not enabled Tingwei Zhang
2020-09-14 18:07 ` Mathieu Poirier
2020-08-21 3:44 ` [PATCH v10 20/24] coresight: cti: increase reference count when enabling cti Tingwei Zhang
2020-09-14 18:08 ` Mathieu Poirier
2020-08-21 3:44 ` [PATCH v10 21/24] coresight: cti: allow cti to be built as a module Tingwei Zhang
2020-09-10 23:03 ` Mathieu Poirier
2020-09-11 2:51 ` Tingwei Zhang
[not found] ` <010101747b1340f9-b0542779-88d7-4193-b53b-5b5bfab5d6a3-000000@us-west-2.amazonses.com>
2020-09-11 17:42 ` Mathieu Poirier
2020-08-21 3:44 ` [PATCH v10 22/24] coresight: tmc-etr: add function to register catu ops Tingwei Zhang
2020-08-21 3:44 ` [PATCH v10 23/24] coresight: catu: allow catu drivers to be built as modules Tingwei Zhang
2020-08-21 3:44 ` [PATCH v10 24/24] coresight: allow the coresight core driver to be built as a module Tingwei Zhang
2020-08-21 9:07 ` Sai Prakash Ranjan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200914021927.GB22686@codeaurora.org \
--to=tingweiz@codeaurora.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=coresight@lists.linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=jinlmao@codeaurora.org \
--cc=kim.phillips@arm.com \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=rdunlap@infradead.org \
--cc=saiprakash.ranjan@codeaurora.org \
--cc=suzuki.poulose@arm.com \
--cc=tingwei@codeaurora.org \
--cc=tsoni@codeaurora.org \
--cc=ykaukab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).