From: Christoph Hellwig <hch@lst.de>
To: Harald Freudenberger <freude@linux.ibm.com>
Cc: Christoph Hellwig <hch@lst.de>,
linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
hca@linux.ibm.com, gor@linux.ibm.com, borntraeger@de.ibm.com
Subject: Re: [PATCH] s390/zcrypt: remove set_fs() invocation in zcrypt device driver
Date: Tue, 15 Sep 2020 08:39:23 +0200 [thread overview]
Message-ID: <20200915063923.GA19468@lst.de> (raw)
In-Reply-To: <e367fef4-1634-7b8e-0ef5-4cdc108edadd@linux.ibm.com>
On Mon, Sep 14, 2020 at 09:36:07AM +0200, Harald Freudenberger wrote:
> Christoph, maybe you have a greater idea on how to solve this. So don't hesitate and tell me.
> Otherwise how to we provide this fix then ? My recommendation would be to go the 'usual' way:
> Commit this s390 internal and then let this go out with the next kernel merge window when
> next time Linus is pulling patches from the s390 subsystem for the 5.10 kernel development cycle.
What I did for the networking code is to add a new structure that
contains a union of the kernel and userspace pointer and a flag for
which one to use. That is pretty much the same as what you did, just
a little more structured and type safe. The other alternative would
be to use the iov_iter infrastructure, but that has some overhead.
prev parent reply other threads:[~2020-09-15 6:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 10:28 [PATCH] s390/zcrypt: remove set_fs() invocation in zcrypt device driver Harald Freudenberger
2020-09-11 6:21 ` Christoph Hellwig
2020-09-14 7:36 ` Harald Freudenberger
2020-09-14 7:55 ` Heiko Carstens
2020-09-15 9:50 ` Harald Freudenberger
2020-09-15 6:39 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200915063923.GA19468@lst.de \
--to=hch@lst.de \
--cc=borntraeger@de.ibm.com \
--cc=freude@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).