linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Sibi Sankar <sibis@codeaurora.org>
Cc: mathieu.poirier@linaro.org, agross@kernel.org,
	linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
	linux-kernel@vger.kernel.org, ohad@wizery.com,
	rishabhb@codeaurora.org
Subject: Re: [PATCH] remoteproc: Fixup coredump debugfs disable request
Date: Tue, 15 Sep 2020 15:18:37 +0000	[thread overview]
Message-ID: <20200915151837.GC478@uller> (raw)
In-Reply-To: <20200915073416.20864-1-sibis@codeaurora.org>

On Tue 15 Sep 07:34 UTC 2020, Sibi Sankar wrote:

> Currently the coredump debugfs entry takes in "disable" to set the
> coredump state to "disabled". Let's just accept the expected state
> instead.
> 

I like this patch, but rather than arguing that it should match the name
of the internal state I think you should either argue that when read you
get "disabled" back or that "disabled" would make it consistent with the
recovery.

Regards,
Bjorn

> Fixes: 3afdc59e43904 ("remoteproc: Add coredump debugfs entry")
> Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
> ---
>  drivers/remoteproc/remoteproc_debugfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/remoteproc/remoteproc_debugfs.c b/drivers/remoteproc/remoteproc_debugfs.c
> index 2e3b3e22e1d01..7ca823f6aa638 100644
> --- a/drivers/remoteproc/remoteproc_debugfs.c
> +++ b/drivers/remoteproc/remoteproc_debugfs.c
> @@ -94,7 +94,7 @@ static ssize_t rproc_coredump_write(struct file *filp,
>  		goto out;
>  	}
>  
> -	if (!strncmp(buf, "disable", count)) {
> +	if (!strncmp(buf, "disabled", count)) {
>  		rproc->dump_conf = RPROC_COREDUMP_DISABLED;
>  	} else if (!strncmp(buf, "inline", count)) {
>  		rproc->dump_conf = RPROC_COREDUMP_INLINE;
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
> 

  reply	other threads:[~2020-09-15 16:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-15  7:34 [PATCH] remoteproc: Fixup coredump debugfs disable request Sibi Sankar
2020-09-15 15:18 ` Bjorn Andersson [this message]
2020-09-15 15:32   ` Sibi Sankar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200915151837.GC478@uller \
    --to=bjorn.andersson@linaro.org \
    --cc=agross@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=ohad@wizery.com \
    --cc=rishabhb@codeaurora.org \
    --cc=sibis@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).