* [PATCH -next] fpga: dfl: Make m10_n3000_info static
@ 2020-09-16 14:25 YueHaibing
2020-09-16 16:10 ` Moritz Fischer
0 siblings, 1 reply; 3+ messages in thread
From: YueHaibing @ 2020-09-16 14:25 UTC (permalink / raw)
To: hao.wu, trix, mdf, yilun.xu; +Cc: linux-fpga, linux-kernel, YueHaibing
Fix sparse warning:
drivers/fpga/dfl-n3000-nios.c:392:23: warning:
symbol 'm10_n3000_info' was not declared. Should it be static?
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/fpga/dfl-n3000-nios.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/fpga/dfl-n3000-nios.c b/drivers/fpga/dfl-n3000-nios.c
index 5088f8f0e0cd..686813b59d33 100644
--- a/drivers/fpga/dfl-n3000-nios.c
+++ b/drivers/fpga/dfl-n3000-nios.c
@@ -389,7 +389,7 @@ static int n3000_nios_init_done_check(struct n3000_nios *ns)
return ret;
}
-struct spi_board_info m10_n3000_info = {
+static struct spi_board_info m10_n3000_info = {
.modalias = "m10-n3000",
.max_speed_hz = 12500000,
.bus_num = 0,
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] fpga: dfl: Make m10_n3000_info static
2020-09-16 14:25 [PATCH -next] fpga: dfl: Make m10_n3000_info static YueHaibing
@ 2020-09-16 16:10 ` Moritz Fischer
2020-09-17 1:33 ` Yuehaibing
0 siblings, 1 reply; 3+ messages in thread
From: Moritz Fischer @ 2020-09-16 16:10 UTC (permalink / raw)
To: YueHaibing; +Cc: hao.wu, trix, mdf, yilun.xu, linux-fpga, linux-kernel
Hi Yue,
On Wed, Sep 16, 2020 at 10:25:36PM +0800, YueHaibing wrote:
> Fix sparse warning:
>
> drivers/fpga/dfl-n3000-nios.c:392:23: warning:
> symbol 'm10_n3000_info' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/fpga/dfl-n3000-nios.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fpga/dfl-n3000-nios.c b/drivers/fpga/dfl-n3000-nios.c
> index 5088f8f0e0cd..686813b59d33 100644
> --- a/drivers/fpga/dfl-n3000-nios.c
> +++ b/drivers/fpga/dfl-n3000-nios.c
> @@ -389,7 +389,7 @@ static int n3000_nios_init_done_check(struct n3000_nios *ns)
> return ret;
> }
>
> -struct spi_board_info m10_n3000_info = {
> +static struct spi_board_info m10_n3000_info = {
> .modalias = "m10-n3000",
> .max_speed_hz = 12500000,
> .bus_num = 0,
> --
> 2.17.1
>
Can you resend this with a [PATCH v2] or [PATCH v2 next], neither
lore nor patchwork picks it up in its current form.
This'll make sure it doesn't get lost.
While at it could you change the first line to:
"fpga: dfl: n3000-nios: Make m10_n3000_info static"
Thanks for the patch,
Moritz
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] fpga: dfl: Make m10_n3000_info static
2020-09-16 16:10 ` Moritz Fischer
@ 2020-09-17 1:33 ` Yuehaibing
0 siblings, 0 replies; 3+ messages in thread
From: Yuehaibing @ 2020-09-17 1:33 UTC (permalink / raw)
To: Moritz Fischer; +Cc: hao.wu, trix, yilun.xu, linux-fpga, linux-kernel
On 2020/9/17 0:10, Moritz Fischer wrote:
> Hi Yue,
>
> On Wed, Sep 16, 2020 at 10:25:36PM +0800, YueHaibing wrote:
>> Fix sparse warning:
>>
>> drivers/fpga/dfl-n3000-nios.c:392:23: warning:
>> symbol 'm10_n3000_info' was not declared. Should it be static?
>>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> ---
>> drivers/fpga/dfl-n3000-nios.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/fpga/dfl-n3000-nios.c b/drivers/fpga/dfl-n3000-nios.c
>> index 5088f8f0e0cd..686813b59d33 100644
>> --- a/drivers/fpga/dfl-n3000-nios.c
>> +++ b/drivers/fpga/dfl-n3000-nios.c
>> @@ -389,7 +389,7 @@ static int n3000_nios_init_done_check(struct n3000_nios *ns)
>> return ret;
>> }
>>
>> -struct spi_board_info m10_n3000_info = {
>> +static struct spi_board_info m10_n3000_info = {
>> .modalias = "m10-n3000",
>> .max_speed_hz = 12500000,
>> .bus_num = 0,
>> --
>> 2.17.1
>>
> Can you resend this with a [PATCH v2] or [PATCH v2 next], neither
> lore nor patchwork picks it up in its current form.
>
> This'll make sure it doesn't get lost.
>
> While at it could you change the first line to:
>
> "fpga: dfl: n3000-nios: Make m10_n3000_info static"
Sure, will resend.
>
> Thanks for the patch,
> Moritz
> .
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-17 1:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-16 14:25 [PATCH -next] fpga: dfl: Make m10_n3000_info static YueHaibing
2020-09-16 16:10 ` Moritz Fischer
2020-09-17 1:33 ` Yuehaibing
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).