* [PATCH] MIPS: Increase range of CONFIG_FORCE_MAX_ZONEORDER
@ 2020-09-17 13:35 Paul Cercueil
2020-09-22 16:02 ` Thomas Bogendoerfer
2020-09-27 9:04 ` Thomas Bogendoerfer
0 siblings, 2 replies; 4+ messages in thread
From: Paul Cercueil @ 2020-09-17 13:35 UTC (permalink / raw)
To: Thomas Bogendoerfer; +Cc: od, linux-mips, linux-kernel, Paul Cercueil
There is nothing that prevents us from using lower maximum values.
It's something that we actually want, when using bigger page sizes on
devices with low RAM.
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---
arch/mips/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index 632fe8fe68c4..dca2bbdbfc24 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -2251,7 +2251,7 @@ config FORCE_MAX_ZONEORDER
default "13" if MIPS_HUGE_TLB_SUPPORT && PAGE_SIZE_32KB
range 12 64 if MIPS_HUGE_TLB_SUPPORT && PAGE_SIZE_16KB
default "12" if MIPS_HUGE_TLB_SUPPORT && PAGE_SIZE_16KB
- range 11 64
+ range 0 64
default "11"
help
The kernel memory allocator divides physically contiguous memory
--
2.28.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] MIPS: Increase range of CONFIG_FORCE_MAX_ZONEORDER
2020-09-17 13:35 [PATCH] MIPS: Increase range of CONFIG_FORCE_MAX_ZONEORDER Paul Cercueil
@ 2020-09-22 16:02 ` Thomas Bogendoerfer
2020-09-22 17:11 ` Paul Cercueil
2020-09-27 9:04 ` Thomas Bogendoerfer
1 sibling, 1 reply; 4+ messages in thread
From: Thomas Bogendoerfer @ 2020-09-22 16:02 UTC (permalink / raw)
To: Paul Cercueil; +Cc: od, linux-mips, linux-kernel
On Thu, Sep 17, 2020 at 03:35:28PM +0200, Paul Cercueil wrote:
> There is nothing that prevents us from using lower maximum values.
> It's something that we actually want, when using bigger page sizes on
> devices with low RAM.
>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
> arch/mips/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index 632fe8fe68c4..dca2bbdbfc24 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -2251,7 +2251,7 @@ config FORCE_MAX_ZONEORDER
> default "13" if MIPS_HUGE_TLB_SUPPORT && PAGE_SIZE_32KB
> range 12 64 if MIPS_HUGE_TLB_SUPPORT && PAGE_SIZE_16KB
> default "12" if MIPS_HUGE_TLB_SUPPORT && PAGE_SIZE_16KB
> - range 11 64
> + range 0 64
Do we need the range at all ? Most other archs don't use a range...
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] MIPS: Increase range of CONFIG_FORCE_MAX_ZONEORDER
2020-09-22 16:02 ` Thomas Bogendoerfer
@ 2020-09-22 17:11 ` Paul Cercueil
0 siblings, 0 replies; 4+ messages in thread
From: Paul Cercueil @ 2020-09-22 17:11 UTC (permalink / raw)
To: Thomas Bogendoerfer; +Cc: od, linux-mips, linux-kernel
Hi Thomas,
Le mar. 22 sept. 2020 à 18:02, Thomas Bogendoerfer
<tsbogend@alpha.franken.de> a écrit :
> On Thu, Sep 17, 2020 at 03:35:28PM +0200, Paul Cercueil wrote:
>> There is nothing that prevents us from using lower maximum values.
>> It's something that we actually want, when using bigger page sizes
>> on
>> devices with low RAM.
>>
>> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
>> ---
>> arch/mips/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
>> index 632fe8fe68c4..dca2bbdbfc24 100644
>> --- a/arch/mips/Kconfig
>> +++ b/arch/mips/Kconfig
>> @@ -2251,7 +2251,7 @@ config FORCE_MAX_ZONEORDER
>> default "13" if MIPS_HUGE_TLB_SUPPORT && PAGE_SIZE_32KB
>> range 12 64 if MIPS_HUGE_TLB_SUPPORT && PAGE_SIZE_16KB
>> default "12" if MIPS_HUGE_TLB_SUPPORT && PAGE_SIZE_16KB
>> - range 11 64
>> + range 0 64
>
> Do we need the range at all ? Most other archs don't use a range...
The maximum contiguous block size cannot be lower than a huge page, so
that's why the 'range' are here.
Which makes me think that there should probably be a "range 11 64 if
MIPS_HUGE_TLB_SUPPORT && PAGE_SIZE_8KB" and the same for 4KB pages.
With a lower value and huge pages enabled in the config, the kernel
probably would not boot.
Cheers,
-Paul
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] MIPS: Increase range of CONFIG_FORCE_MAX_ZONEORDER
2020-09-17 13:35 [PATCH] MIPS: Increase range of CONFIG_FORCE_MAX_ZONEORDER Paul Cercueil
2020-09-22 16:02 ` Thomas Bogendoerfer
@ 2020-09-27 9:04 ` Thomas Bogendoerfer
1 sibling, 0 replies; 4+ messages in thread
From: Thomas Bogendoerfer @ 2020-09-27 9:04 UTC (permalink / raw)
To: Paul Cercueil; +Cc: od, linux-mips, linux-kernel
On Thu, Sep 17, 2020 at 03:35:28PM +0200, Paul Cercueil wrote:
> There is nothing that prevents us from using lower maximum values.
> It's something that we actually want, when using bigger page sizes on
> devices with low RAM.
>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
> arch/mips/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-09-27 9:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-17 13:35 [PATCH] MIPS: Increase range of CONFIG_FORCE_MAX_ZONEORDER Paul Cercueil
2020-09-22 16:02 ` Thomas Bogendoerfer
2020-09-22 17:11 ` Paul Cercueil
2020-09-27 9:04 ` Thomas Bogendoerfer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).