linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next] net: hns3: Supply missing hclge_dcb.h include file
@ 2020-09-18 13:06 Wang Hai
  2020-09-18 17:43 ` Saeed Mahameed
  2020-09-18 21:55 ` David Miller
  0 siblings, 2 replies; 3+ messages in thread
From: Wang Hai @ 2020-09-18 13:06 UTC (permalink / raw)
  To: yisen.zhuang, salil.mehta, davem, kuba, tanhuazhong, liaoguojia,
	liuyonglong, linyunsheng
  Cc: netdev, linux-kernel

If the header file containing a function's prototype isn't included by
the sourcefile containing the associated function, the build system
complains of missing prototypes.

Fixes the following W=1 kernel build warning(s):

drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_dcb.c:453:6: warning: no previous prototype for ‘hclge_dcb_ops_set’ [-Wmissing-prototypes]

Signed-off-by: Wang Hai <wanghai38@huawei.com>
---
 drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_dcb.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_dcb.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_dcb.c
index d6c3952aba04..f990f6915226 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_dcb.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_dcb.c
@@ -2,6 +2,7 @@
 // Copyright (c) 2016-2017 Hisilicon Limited.
 
 #include "hclge_main.h"
+#include "hclge_dcb.h"
 #include "hclge_tm.h"
 #include "hnae3.h"
 
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] net: hns3: Supply missing hclge_dcb.h include file
  2020-09-18 13:06 [PATCH net-next] net: hns3: Supply missing hclge_dcb.h include file Wang Hai
@ 2020-09-18 17:43 ` Saeed Mahameed
  2020-09-18 21:55 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: Saeed Mahameed @ 2020-09-18 17:43 UTC (permalink / raw)
  To: Wang Hai, yisen.zhuang, salil.mehta, davem, kuba, tanhuazhong,
	liaoguojia, liuyonglong, linyunsheng
  Cc: netdev, linux-kernel

On Fri, 2020-09-18 at 21:06 +0800, Wang Hai wrote:
> If the header file containing a function's prototype isn't included
> by
> the sourcefile containing the associated function, the build system
> complains of missing prototypes.
> 
> Fixes the following W=1 kernel build warning(s):
> 
> drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_dcb.c:453:6:
> warning: no previous prototype for ‘hclge_dcb_ops_set’ [-Wmissing-
> prototypes]
> 
> Signed-off-by: Wang Hai <wanghai38@huawei.com>
> ---

Reviewed-by: Saeed Mahameed <saeedm@nvidia.com>



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] net: hns3: Supply missing hclge_dcb.h include file
  2020-09-18 13:06 [PATCH net-next] net: hns3: Supply missing hclge_dcb.h include file Wang Hai
  2020-09-18 17:43 ` Saeed Mahameed
@ 2020-09-18 21:55 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2020-09-18 21:55 UTC (permalink / raw)
  To: wanghai38
  Cc: yisen.zhuang, salil.mehta, kuba, tanhuazhong, liaoguojia,
	liuyonglong, linyunsheng, netdev, linux-kernel

From: Wang Hai <wanghai38@huawei.com>
Date: Fri, 18 Sep 2020 21:06:53 +0800

> If the header file containing a function's prototype isn't included by
> the sourcefile containing the associated function, the build system
> complains of missing prototypes.
> 
> Fixes the following W=1 kernel build warning(s):
> 
> drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_dcb.c:453:6: warning: no previous prototype for ‘hclge_dcb_ops_set’ [-Wmissing-prototypes]
> 
> Signed-off-by: Wang Hai <wanghai38@huawei.com>

Applied.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-09-18 21:55 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-18 13:06 [PATCH net-next] net: hns3: Supply missing hclge_dcb.h include file Wang Hai
2020-09-18 17:43 ` Saeed Mahameed
2020-09-18 21:55 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).