* [PATCH v2] fbcon: Remove the superfluous break
@ 2020-09-18 1:05 Jing Xiangfeng
2020-09-18 12:45 ` Daniel Vetter
0 siblings, 1 reply; 2+ messages in thread
From: Jing Xiangfeng @ 2020-09-18 1:05 UTC (permalink / raw)
To: b.zolnierkie, gregkh, daniel.vetter, ndesaulniers, gustavoars,
jirislaby, george.kennedy, natechancellor, peda, krzysztof.h1,
akpm, adaplas
Cc: dri-devel, linux-fbdev, linux-kernel, jingxiangfeng
Remove the superfluous break, as there is a 'return' before it.
Fixes: bad07ff74c32 ("fbcon: smart blitter usage for scrolling")
Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
drivers/video/fbdev/core/fbcon.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c
index 0b49b0f44edf..623359aadd1e 100644
--- a/drivers/video/fbdev/core/fbcon.c
+++ b/drivers/video/fbdev/core/fbcon.c
@@ -1727,7 +1727,6 @@ static bool fbcon_scroll(struct vc_data *vc, unsigned int t, unsigned int b,
vc->vc_video_erase_char,
vc->vc_size_row * count);
return true;
- break;
case SCROLL_WRAP_MOVE:
if (b - t - count > 3 * vc->vc_rows >> 2) {
@@ -1818,7 +1817,6 @@ static bool fbcon_scroll(struct vc_data *vc, unsigned int t, unsigned int b,
vc->vc_video_erase_char,
vc->vc_size_row * count);
return true;
- break;
case SCROLL_WRAP_MOVE:
if (b - t - count > 3 * vc->vc_rows >> 2) {
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] fbcon: Remove the superfluous break
2020-09-18 1:05 [PATCH v2] fbcon: Remove the superfluous break Jing Xiangfeng
@ 2020-09-18 12:45 ` Daniel Vetter
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Vetter @ 2020-09-18 12:45 UTC (permalink / raw)
To: Jing Xiangfeng
Cc: b.zolnierkie, gregkh, daniel.vetter, ndesaulniers, gustavoars,
jirislaby, george.kennedy, natechancellor, peda, krzysztof.h1,
akpm, adaplas, dri-devel, linux-fbdev, linux-kernel
On Fri, Sep 18, 2020 at 09:05:21AM +0800, Jing Xiangfeng wrote:
> Remove the superfluous break, as there is a 'return' before it.
>
> Fixes: bad07ff74c32 ("fbcon: smart blitter usage for scrolling")
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
> Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
> Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Applied to drm-misc-next, thanks.
-Daniel
> ---
> drivers/video/fbdev/core/fbcon.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c
> index 0b49b0f44edf..623359aadd1e 100644
> --- a/drivers/video/fbdev/core/fbcon.c
> +++ b/drivers/video/fbdev/core/fbcon.c
> @@ -1727,7 +1727,6 @@ static bool fbcon_scroll(struct vc_data *vc, unsigned int t, unsigned int b,
> vc->vc_video_erase_char,
> vc->vc_size_row * count);
> return true;
> - break;
>
> case SCROLL_WRAP_MOVE:
> if (b - t - count > 3 * vc->vc_rows >> 2) {
> @@ -1818,7 +1817,6 @@ static bool fbcon_scroll(struct vc_data *vc, unsigned int t, unsigned int b,
> vc->vc_video_erase_char,
> vc->vc_size_row * count);
> return true;
> - break;
>
> case SCROLL_WRAP_MOVE:
> if (b - t - count > 3 * vc->vc_rows >> 2) {
> --
> 2.17.1
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-18 12:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-18 1:05 [PATCH v2] fbcon: Remove the superfluous break Jing Xiangfeng
2020-09-18 12:45 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).