linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dave Young <dyoung@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>,
	bhe@redhat.com, Eric Biederman <ebiederm@xmission.com>,
	linux-kernel@vger.kernel.org, kexec@lists.infradead.org
Subject: [PATCH] Only allow to set crash_kexec_post_notifiers on boot time
Date: Fri, 18 Sep 2020 11:25:46 +0800	[thread overview]
Message-ID: <20200918032546.GA4180@dhcp-128-65.nay.redhat.com> (raw)

crash_kexec_post_notifiers enables running various panic notifier
before kdump kernel booting. This increases risks of kdump failure.
It is well documented in kernel-parameters.txt. We do not suggest
people to enable it together with kdump unless he/she is really sure.
This is also not suggested to be enabled by default when users are
not aware in distributions.

But unfortunately it is enabled by default in systemd, see below
discussions in a systemd report, we can not convince systemd to change
it:
https://github.com/systemd/systemd/issues/16661

Actually we have got reports about kdump kernel hangs in both s390x
and powerpcle cases caused by the systemd change,  also some x86 cases
could also be caused by the same (although that is in Hyper-V code
instead of systemd, that need to be addressed separately).

Thus to avoid the auto enablement here just disable the param writable
permission in sysfs.

Signed-off-by: Dave Young <dyoung@redhat.com>
---
 kernel/panic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/panic.c b/kernel/panic.c
index aef8872ba843..bea44fc4eb3b 100644
--- a/kernel/panic.c
+++ b/kernel/panic.c
@@ -695,7 +695,7 @@ core_param(panic, panic_timeout, int, 0644);
 core_param(panic_print, panic_print, ulong, 0644);
 core_param(pause_on_oops, pause_on_oops, int, 0644);
 core_param(panic_on_warn, panic_on_warn, int, 0644);
-core_param(crash_kexec_post_notifiers, crash_kexec_post_notifiers, bool, 0644);
+core_param(crash_kexec_post_notifiers, crash_kexec_post_notifiers, bool, 0444);
 
 static int __init oops_setup(char *s)
 {
-- 
2.26.2


             reply	other threads:[~2020-09-18  3:26 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-18  3:25 Dave Young [this message]
2020-09-19  0:47 ` [PATCH] Only allow to set crash_kexec_post_notifiers on boot time Andrew Morton
2020-09-19  7:26   ` Dave Young
2020-09-21 20:18   ` Konrad Rzeszutek Wilk
2020-09-22  1:45     ` Eric W. Biederman
2020-09-23  2:43       ` Dave Young
2020-09-23 15:48         ` Konrad Rzeszutek Wilk
2020-09-24 16:15           ` Michael Kelley
2020-09-24 16:25             ` Eric W. Biederman
2020-09-24 16:43               ` Michael Kelley
2020-09-24 17:16                 ` boris.ostrovsky
2020-09-25  3:05                   ` Dave Young
2020-09-25 14:56                     ` Konrad Rzeszutek Wilk
2020-09-27  2:51                       ` Dave Young
2020-09-29 13:36                       ` Philipp Rudo
2020-09-29 19:10                         ` boris.ostrovsky
2020-09-22 10:58     ` Philipp Rudo
2020-09-22 14:50       ` boris.ostrovsky
2020-09-22 17:04         ` Guilherme G. Piccoli
2020-09-23  2:25     ` Dave Young

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200918032546.GA4180@dhcp-128-65.nay.redhat.com \
    --to=dyoung@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=bhe@redhat.com \
    --cc=ebiederm@xmission.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).