* [PATCH v2] usb: serial: option: Fix the lackage for Quectel EG95 LTE modem support
@ 2020-09-02 11:03 William Sung
2020-09-18 7:53 ` Johan Hovold
0 siblings, 1 reply; 2+ messages in thread
From: William Sung @ 2020-09-02 11:03 UTC (permalink / raw)
To: Johan Hovold, Greg Kroah-Hartman, linux-usb, linux-kernel,
AceLan Kao, Campion Kang, William Sung
* Add reset-resume callback for resetting USB devices after MCU exits
from suspend/sleep mode.
* Add zero packet support
Fixes: da6902e5b6db ("USB: serial: option: add Quectel EG95 LTE modem"
Signed-off-by: William Sung <william.sung@advantech.com.tw>
---
v2: * Add ZLP support
* Remove redundant code for reserving interface number 4
drivers/usb/serial/option.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index 89b3192af326..ba4dc67dab2f 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
@@ -1099,7 +1099,7 @@ static const struct usb_device_id option_ids[] = {
{ USB_DEVICE(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_EC25),
.driver_info = RSVD(4) },
{ USB_DEVICE(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_EG95),
- .driver_info = RSVD(4) },
+ .driver_info = RSVD(4) | ZLP },
{ USB_DEVICE(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_BG96),
.driver_info = RSVD(4) },
{ USB_DEVICE_AND_INTERFACE_INFO(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_EP06, 0xff, 0xff, 0xff),
@@ -2069,6 +2069,7 @@ static struct usb_serial_driver option_1port_device = {
#ifdef CONFIG_PM
.suspend = usb_wwan_suspend,
.resume = usb_wwan_resume,
+ .reset_resume = usb_wwan_resume,
#endif
};
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] usb: serial: option: Fix the lackage for Quectel EG95 LTE modem support
2020-09-02 11:03 [PATCH v2] usb: serial: option: Fix the lackage for Quectel EG95 LTE modem support William Sung
@ 2020-09-18 7:53 ` Johan Hovold
0 siblings, 0 replies; 2+ messages in thread
From: Johan Hovold @ 2020-09-18 7:53 UTC (permalink / raw)
To: William Sung
Cc: Johan Hovold, Greg Kroah-Hartman, linux-usb, linux-kernel,
AceLan Kao, Campion Kang
On Wed, Sep 02, 2020 at 07:03:01PM +0800, William Sung wrote:
> * Add reset-resume callback for resetting USB devices after MCU exits
> from suspend/sleep mode.
Looks like both your patches try to do this. Again, one logical change
per patch, please.
> * Add zero packet support
>
> Fixes: da6902e5b6db ("USB: serial: option: add Quectel EG95 LTE modem"
>
> Signed-off-by: William Sung <william.sung@advantech.com.tw>
> ---
>
> v2: * Add ZLP support
> * Remove redundant code for reserving interface number 4
>
> drivers/usb/serial/option.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> index 89b3192af326..ba4dc67dab2f 100644
> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> @@ -1099,7 +1099,7 @@ static const struct usb_device_id option_ids[] = {
> { USB_DEVICE(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_EC25),
> .driver_info = RSVD(4) },
> { USB_DEVICE(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_EG95),
> - .driver_info = RSVD(4) },
> + .driver_info = RSVD(4) | ZLP },
> { USB_DEVICE(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_BG96),
> .driver_info = RSVD(4) },
> { USB_DEVICE_AND_INTERFACE_INFO(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_EP06, 0xff, 0xff, 0xff),
> @@ -2069,6 +2069,7 @@ static struct usb_serial_driver option_1port_device = {
> #ifdef CONFIG_PM
> .suspend = usb_wwan_suspend,
> .resume = usb_wwan_resume,
> + .reset_resume = usb_wwan_resume,
> #endif
> };
Johan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-18 7:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-02 11:03 [PATCH v2] usb: serial: option: Fix the lackage for Quectel EG95 LTE modem support William Sung
2020-09-18 7:53 ` Johan Hovold
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).