From: David Miller <davem@davemloft.net>
To: zhengyongjun3@huawei.com
Cc: bryan.whitehead@microchip.com, UNGLinuxDriver@microchip.com,
kuba@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: microchip: Remove set but not used variable
Date: Sat, 19 Sep 2020 14:09:39 -0700 (PDT) [thread overview]
Message-ID: <20200919.140939.2137825862652726442.davem@davemloft.net> (raw)
In-Reply-To: <20200919023909.23716-1-zhengyongjun3@huawei.com>
From: Zheng Yongjun <zhengyongjun3@huawei.com>
Date: Sat, 19 Sep 2020 10:39:09 +0800
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/ethernet/microchip/lan743x_main.c: In function lan743x_pm_suspend:
> drivers/net/ethernet/microchip/lan743x_main.c:3041:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
>
> `ret` is set but not used, so check it's value.
Subject is still wrong, please fix this and take your time doing
so.
Thanks.
next prev parent reply other threads:[~2020-09-19 21:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-19 2:39 [PATCH net-next] net: microchip: Remove set but not used variable Zheng Yongjun
2020-09-19 3:08 ` 答复: " zhengyongjun
2020-09-19 21:09 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-09-19 2:37 Zheng Yongjun
2020-09-19 21:09 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200919.140939.2137825862652726442.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=UNGLinuxDriver@microchip.com \
--cc=bryan.whitehead@microchip.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=zhengyongjun3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).