* [PATCH] ARM: dts: exynos: revert "add input clock to CMU in Exynos4412 Odroid"
@ 2020-09-21 17:48 Krzysztof Kozlowski
2020-09-22 15:57 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-21 17:48 UTC (permalink / raw)
To: Rob Herring, Kukjin Kim, Krzysztof Kozlowski, devicetree,
linux-arm-kernel, linux-samsung-soc, linux-kernel
Cc: Marek Szyprowski
This reverts commit eaf2d2f6895d676dda6c95a652b58594f2887720.
The commit eaf2d2f6895d ("ARM: dts: exynos: add input clock to CMU in
Exynos4412 Odroid") breaks probing of usb3503 USB hub on Odroid U3.
It changes the order of clock drivers probe: the clkout (Exynos PMU)
driver is probed before the main clk-exynos4 driver. The clkout driver
on Exynos4412 depends on clk-exynos4 but it does not support deferred
probe, therefore this dependency and changed probe order causes probe
failure.
The usb3503 USB hub on Odroid U3 on the other hand requires clkout
clock. This can be seen in logs:
[ 5.007442] usb3503 0-0008: unable to request refclk (-517)
Reported-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
index ab291cec650a..2983e91bc7dd 100644
--- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
+++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
@@ -122,7 +122,6 @@
};
&clock {
- clocks = <&clock CLK_XUSBXTI>;
assigned-clocks = <&clock CLK_FOUT_EPLL>;
assigned-clock-rates = <45158401>;
};
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: dts: exynos: revert "add input clock to CMU in Exynos4412 Odroid"
2020-09-21 17:48 [PATCH] ARM: dts: exynos: revert "add input clock to CMU in Exynos4412 Odroid" Krzysztof Kozlowski
@ 2020-09-22 15:57 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-22 15:57 UTC (permalink / raw)
To: Rob Herring, Kukjin Kim, devicetree, linux-arm-kernel,
linux-samsung-soc, linux-kernel
Cc: Marek Szyprowski
On Mon, Sep 21, 2020 at 07:48:18PM +0200, Krzysztof Kozlowski wrote:
> This reverts commit eaf2d2f6895d676dda6c95a652b58594f2887720.
>
> The commit eaf2d2f6895d ("ARM: dts: exynos: add input clock to CMU in
> Exynos4412 Odroid") breaks probing of usb3503 USB hub on Odroid U3.
>
> It changes the order of clock drivers probe: the clkout (Exynos PMU)
> driver is probed before the main clk-exynos4 driver. The clkout driver
> on Exynos4412 depends on clk-exynos4 but it does not support deferred
> probe, therefore this dependency and changed probe order causes probe
> failure.
>
> The usb3503 USB hub on Odroid U3 on the other hand requires clkout
> clock. This can be seen in logs:
>
> [ 5.007442] usb3503 0-0008: unable to request refclk (-517)
>
> Reported-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 1 -
Applied.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-22 15:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-21 17:48 [PATCH] ARM: dts: exynos: revert "add input clock to CMU in Exynos4412 Odroid" Krzysztof Kozlowski
2020-09-22 15:57 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).