* [PATCH] MIPS: Make setup_elfcorehdr and setup_elfcorehdr_size static
@ 2020-09-11 2:01 Jason Yan
2020-09-21 20:26 ` Thomas Bogendoerfer
0 siblings, 1 reply; 2+ messages in thread
From: Jason Yan @ 2020-09-11 2:01 UTC (permalink / raw)
To: tsbogend, paulburton, linux-mips, linux-kernel; +Cc: Jason Yan, Hulk Robot
This addresses the following sparse warning:
arch/mips/kernel/setup.c:446:33: warning: symbol 'setup_elfcorehdr_size'
was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
arch/mips/kernel/setup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/kernel/setup.c b/arch/mips/kernel/setup.c
index 335bd188b8b4..c004a311aaab 100644
--- a/arch/mips/kernel/setup.c
+++ b/arch/mips/kernel/setup.c
@@ -443,7 +443,7 @@ static int __init early_parse_memmap(char *p)
early_param("memmap", early_parse_memmap);
#ifdef CONFIG_PROC_VMCORE
-unsigned long setup_elfcorehdr, setup_elfcorehdr_size;
+static unsigned long setup_elfcorehdr, setup_elfcorehdr_size;
static int __init early_parse_elfcorehdr(char *p)
{
phys_addr_t start, end;
--
2.25.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] MIPS: Make setup_elfcorehdr and setup_elfcorehdr_size static
2020-09-11 2:01 [PATCH] MIPS: Make setup_elfcorehdr and setup_elfcorehdr_size static Jason Yan
@ 2020-09-21 20:26 ` Thomas Bogendoerfer
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Bogendoerfer @ 2020-09-21 20:26 UTC (permalink / raw)
To: Jason Yan; +Cc: paulburton, linux-mips, linux-kernel, Hulk Robot
On Fri, Sep 11, 2020 at 10:01:32AM +0800, Jason Yan wrote:
> This addresses the following sparse warning:
>
> arch/mips/kernel/setup.c:446:33: warning: symbol 'setup_elfcorehdr_size'
> was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> ---
> arch/mips/kernel/setup.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-21 20:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-11 2:01 [PATCH] MIPS: Make setup_elfcorehdr and setup_elfcorehdr_size static Jason Yan
2020-09-21 20:26 ` Thomas Bogendoerfer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).