* [PATCH v4] powercap: include header to fix -Wmissing-prototypes
@ 2020-09-22 4:46 Pujin Shi
2020-09-25 14:49 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Pujin Shi @ 2020-09-22 4:46 UTC (permalink / raw)
To: Rafael J . Wysocki
Cc: linux-pm, linux-kernel, Herrington, shipujin.t, Pujin Shi
Include the linux/idle_inject.h header to fix W=1 build warning:
drivers/powercap/idle_inject.c:152:6: warning: no previous prototype for ‘idle_inject_set_duration’ [-Wmissing-prototypes]
drivers/powercap/idle_inject.c:167:6: warning: no previous prototype for ‘idle_inject_get_duration’ [-Wmissing-prototypes]
drivers/powercap/idle_inject.c:179:6: warning: no previous prototype for ‘idle_inject_set_latency’ [-Wmissing-prototypes]
drivers/powercap/idle_inject.c:195:5: warning: no previous prototype for ‘idle_inject_start’ [-Wmissing-prototypes]
drivers/powercap/idle_inject.c:227:6: warning: no previous prototype for ‘idle_inject_stop’ [-Wmissing-prototypes]
drivers/powercap/idle_inject.c:299:28: warning: no previous prototype for ‘idle_inject_register’ [-Wmissing-prototypes]
drivers/powercap/idle_inject.c:345:6: warning: no previous prototype for ‘idle_inject_unregister’ [-Wmissing-prototypes]
Signed-off-by: Pujin Shi <shipj@lemote.com>
---
drivers/powercap/idle_inject.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/powercap/idle_inject.c b/drivers/powercap/idle_inject.c
index 4310901a074e..6e1a0043c411 100644
--- a/drivers/powercap/idle_inject.c
+++ b/drivers/powercap/idle_inject.c
@@ -43,6 +43,7 @@
#include <linux/sched.h>
#include <linux/slab.h>
#include <linux/smpboot.h>
+#include <linux/idle_inject.h>
#include <uapi/linux/sched/types.h>
--
2.25.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v4] powercap: include header to fix -Wmissing-prototypes
2020-09-22 4:46 [PATCH v4] powercap: include header to fix -Wmissing-prototypes Pujin Shi
@ 2020-09-25 14:49 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2020-09-25 14:49 UTC (permalink / raw)
To: Pujin Shi
Cc: Rafael J . Wysocki, Linux PM, Linux Kernel Mailing List,
Herrington, Pujin Shi
On Tue, Sep 22, 2020 at 6:47 AM Pujin Shi <shipujin.t@gmail.com> wrote:
>
> Include the linux/idle_inject.h header to fix W=1 build warning:
>
> drivers/powercap/idle_inject.c:152:6: warning: no previous prototype for ‘idle_inject_set_duration’ [-Wmissing-prototypes]
> drivers/powercap/idle_inject.c:167:6: warning: no previous prototype for ‘idle_inject_get_duration’ [-Wmissing-prototypes]
> drivers/powercap/idle_inject.c:179:6: warning: no previous prototype for ‘idle_inject_set_latency’ [-Wmissing-prototypes]
> drivers/powercap/idle_inject.c:195:5: warning: no previous prototype for ‘idle_inject_start’ [-Wmissing-prototypes]
> drivers/powercap/idle_inject.c:227:6: warning: no previous prototype for ‘idle_inject_stop’ [-Wmissing-prototypes]
> drivers/powercap/idle_inject.c:299:28: warning: no previous prototype for ‘idle_inject_register’ [-Wmissing-prototypes]
> drivers/powercap/idle_inject.c:345:6: warning: no previous prototype for ‘idle_inject_unregister’ [-Wmissing-prototypes]
>
> Signed-off-by: Pujin Shi <shipj@lemote.com>
> ---
> drivers/powercap/idle_inject.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/powercap/idle_inject.c b/drivers/powercap/idle_inject.c
> index 4310901a074e..6e1a0043c411 100644
> --- a/drivers/powercap/idle_inject.c
> +++ b/drivers/powercap/idle_inject.c
> @@ -43,6 +43,7 @@
> #include <linux/sched.h>
> #include <linux/slab.h>
> #include <linux/smpboot.h>
> +#include <linux/idle_inject.h>
>
> #include <uapi/linux/sched/types.h>
>
> --
Note that the contact information in the S-o-b tag should match the
From: header exactly.
I've fixed that up manually this time and applied the patch (as 5.10
material), but please be more careful about it in the future.
Thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-25 14:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-22 4:46 [PATCH v4] powercap: include header to fix -Wmissing-prototypes Pujin Shi
2020-09-25 14:49 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).